Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1622552 - Review Request: golang-github-linuxdeepin-dbus-factory - GO DBus factory for Deepin Desktop Environment
Summary: Review Request: golang-github-linuxdeepin-dbus-factory - GO DBus factory for ...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Robert-André Mauchin 🐧
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: DeepinDEPackageReview
TreeView+ depends on / blocked
 
Reported: 2018-08-27 12:53 UTC by sensor.wen
Modified: 2019-02-27 10:25 UTC (History)
3 users (show)

Fixed In Version: golang-github-linuxdeepin-dbus-factory-0.0.7.1-1.20181114git0bb7f20.fc30
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2019-02-27 10:25:07 UTC
Type: Bug
Embargoed:
zebob.m: fedora-review+

Attachments (Terms of Use)

Description sensor.wen 2018-08-27 12:53:19 UTC 
SPEC: https://copr-be.cloud.fedoraproject.org/results/mosquito/deepin/fedora-rawhide-x86_64/00788972-golang-github-linuxdeepin-go-dbus-factory/golang-github-linuxdeepin-go-dbus-factory.spec

SRPM: https://copr-be.cloud.fedoraproject.org/results/mosquito/deepin/fedora-rawhide-x86_64/00788972-golang-github-linuxdeepin-go-dbus-factory/golang-github-linuxdeepin-go-dbus-factory-0-0.3.gite843337.fc29.src.rpm

Description: GO DBus factory for Deepin Desktop Environment

Fedora Account System Username: mosquito
Comment 1 Robert-André Mauchin 🐧 2018-08-27 16:11:37 UTC 
You need to use the new Go packaging method, see: https://fedoraproject.org/wiki/More_Go_packaging

You can see examples here: https://eclipseo.fedorapeople.org/golang/

You should get something like this:

===============================================================================
# https://github.com/linuxdeepin/go-dbus-factory
%global goipath         github.com/linuxdeepin/go-dbus-factory
%global commit          2a30fc6fb47b70b8879855df8e29c8f581c419aa

%gometa

Name:           %{goname}
Version:        0.0.7
Release:        1%{?dist}
Summary:        GO DBus factory for Deepin Desktop Environment
License:        GPLv3
URL:            %{gourl}
Source0:        %{gosource}

%description
%{summary}


%package devel
Summary:       %{summary}
BuildArch:     noarch

%description devel
%{summary}

This package contains library source intended for
building other packages which use import path with
%{goipath} prefix.


%prep
%forgeautosetup


%install
%goinstall


%check
%gochecks


%files devel -f devel.file-list
%doc README.md CHANGELOG.md


%changelog
* Fri Aug 10 2018 mosquito <sensor.wen> - 0.0.7-1.20180828git2a30fc6
- First package for Fedora
===============================================================================
Comment 2 sensor.wen 2018-08-27 18:27:41 UTC 
SPEC: https://copr-be.cloud.fedoraproject.org/results/mosquito/deepin/fedora-rawhide-x86_64/00791551-golang-github-linuxdeepin-dbus-factory/go.spec

SRPM: https://copr-be.cloud.fedoraproject.org/results/mosquito/deepin/fedora-rawhide-x86_64/00791551-golang-github-linuxdeepin-dbus-factory/golang-github-linuxdeepin-dbus-factory-0.0.7-1.20180827gite843337.fc30.src.rpm

I think it's very clear. nice
Comment 3 Robert-André Mauchin 🐧 2018-08-27 19:16:44 UTC 
Please note that the SPEC name should now be golang-github-linuxdeepin-dbus-factory.spec  The new Go packaging automatically removes "go" or "git" in package name.


 - License ok
 - Latest version packaged
 - Builds in mock
 - No rpmlint errors
 - Conforms to Packaging Guidelines

Package approved.
Comment 4 sensor.wen 2018-08-27 19:29:43 UTC 
OK, thank you for your help.
Comment 5 Gwyn Ciesla 2018-08-27 20:42:49 UTC 
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-linuxdeepin-dbus-factory
Note You need to log in before you can comment on or make changes to this bug.