Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1632634 - Foldcolumn is not redrawn for rows above the cursors current position.
Summary: Foldcolumn is not redrawn for rows above the cursors current position.
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: vim
Version: 28
Hardware: x86_64
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Karsten Hopp
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-09-25 09:32 UTC by asmjmisc
Modified: 2018-10-07 22:16 UTC (History)
3 users (show)

Fixed In Version: vim-8.1.450-1.fc28
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2018-10-07 22:16:04 UTC
Type: Bug
Embargoed:

Attachments (Terms of Use)
Fold column working (deleted)
2018-09-25 09:33 UTC, asmjmisc 		no flags Details
Fold column broken (deleted)
2018-09-25 09:34 UTC, asmjmisc 		no flags Details
Fold column partially redrawn (deleted)
2018-09-25 09:35 UTC, asmjmisc 		no flags Details
View All


Links
System ID Private Priority Status Summary Last Updated
Github vim vim issues 3484 0 None None None 2018-09-26 11:12:59 UTC

Description asmjmisc 2018-09-25 09:32:34 UTC 
vim, when configured to display the fold column of any depth (1 or more), fails to redraw above the current cursor positions line. Also, when within a foldable section, the fold indicator is missing its starting glyph, which reappears when the cursor lands on either the opening or closing symbol of the fold.

I'm observing this on vim from vim-enhanced 2:8.1.408-1.fc28

How reproducible:
To reproduce the behavior, make sure vim was compiled with +folding (see vim --version), and set the following minimum set of options:

set foldmethod=syntax (this will enable folding for recognized filetypes based on syntax; no need for extra fold symbols)
set foldcolumn=1 (or any other legal value above 1)

After having done that, open a file that has some sort of nested structure (or recognized programming language source, containing, for example, function definitions). Open all the folds by hitting zR in sequence and scroll through the file crossing folds and observe the foldcolumn on the left.

After hitting ctrl-l (redraw) - the fold column is redrawn properly, and subsequent movements again break the column.

I'm not sure if this bug has been introduced by Fedora patches or upstream (I haven't had the time to check yet), but I'm starting here.
Comment 1 asmjmisc 2018-09-25 09:33:36 UTC 
Created attachment 1486656 [details]
Fold column working
Comment 2 asmjmisc 2018-09-25 09:34:19 UTC 
Created attachment 1486657 [details]
Fold column broken
Comment 3 asmjmisc 2018-09-25 09:35:33 UTC 
Created attachment 1486658 [details]
Fold column partially redrawn

This happens when the cursor is moved back up the file, resulting in the foldcolumn being drawn only partially, starting from the cursor line.
Comment 4 asmjmisc 2018-09-26 05:42:32 UTC 
Someone filed a bug report on vim's official GitHub issues page, describing similar behavior: https://github.com/vim/vim/issues/3484. I forgot to check, but can now confirm, that the bug manifests when the 'relativenumber' option is set.
Comment 5 Zdenek Dohnal 2018-09-26 11:13:00 UTC 
Hi,

thank you for finding it out! I'll add the upstream issue.
Comment 6 asmjmisc 2018-10-03 07:38:10 UTC 
Good news. It appears that this is now fixed upstream, in patch 8.1.0449, commit here: https://github.com/vim/vim/commit/7701f308565fdc7b5096a6597d9c3b63de0bbcec. I haven't yet verified the patch and won't be able to for another 12 hours. If anyone can fire off a build on Koji to test later, that'd be extra great. :)
Comment 7 Zdenek Dohnal 2018-10-03 08:21:33 UTC 
I'm going to build the newest upstream patchlevel today, so it will be fixed in the next vim update. Thank you again for finding it out!
Comment 8 Fedora Update System 2018-10-03 10:46:34 UTC 
vim-8.1.450-1.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-fc1c68d21a
Comment 9 Fedora Update System 2018-10-03 15:02:15 UTC 
vim-8.1.450-1.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-fc1c68d21a
Comment 10 Fedora Update System 2018-10-07 22:16:04 UTC 
vim-8.1.450-1.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report.
Note You need to log in before you can comment on or make changes to this bug.