Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1649794 - Review Request: golang-github-fogleman-gg - Go Graphics - 2D rendering in Go with a simple API
Summary: Review Request: golang-github-fogleman-gg - Go Graphics - 2D rendering in Go ...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Robert-André Mauchin 🐧
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: DeepinDEPackageReview
TreeView+ depends on / blocked
 
Reported: 2018-11-14 14:28 UTC by sensor.wen
Modified: 2019-02-27 10:44 UTC (History)
3 users (show)

Fixed In Version: golang-github-fogleman-gg-1.1.0-1.20181120git0e0ff3a.fc30
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2019-02-27 10:44:37 UTC
Type: Bug
Embargoed:
zebob.m: fedora-review+

Attachments (Terms of Use)

Description sensor.wen 2018-11-14 14:28:43 UTC 
SPEC: https://copr-be.cloud.fedoraproject.org/results/mosquito/deepin/fedora-rawhide-x86_64/00819820-golang-github-fogleman-gg/golang-github-fogleman-gg.spec

SRPM: https://copr-be.cloud.fedoraproject.org/results/mosquito/deepin/fedora-rawhide-x86_64/00819820-golang-github-fogleman-gg/golang-github-fogleman-gg-1.1.0-1.20181106git0e0ff3a.fc30.src.rpm

Description: Go Graphics - 2D rendering in Go with a simple API

Fedora Account System Username: mosquito
Comment 1 Robert-André Mauchin 🐧 2018-11-14 15:13:50 UTC 
Long time no see, I hope you're doing great!


 - Latest version packaged
 - License ok
 - Builds in Mock
 - Conforms to the Packaging Guidelines


There are missing packages:

DEBUG util.py:490:  BUILDSTDERR:  Problem: conflicting requests
DEBUG util.py:490:  BUILDSTDERR:   - nothing provides golang(github.com/golang/freetype/raster) needed by golang-github-fogleman-gg-devel-1.1.0-1.20181114git0e0ff3a.fc30.noarch
DEBUG util.py:490:  BUILDSTDERR:   - nothing provides golang(github.com/golang/freetype/truetype) needed by golang-github-fogleman-gg-devel-1.1.0-1.20181114git0e0ff3a.fc30.noarch

You probably need to package github.com/golang/freetype for it to work.
Comment 2 sensor.wen 2018-11-14 19:36:07 UTC 
Hi Robert:

I think the golang(github.com/BurntSushi/freetype-go) is equal to the golang(github.com/golang/freetype) package. So i update it to provides alias. ( https://src.fedoraproject.org/rpms/golang-github-BurntSushi-freetype-go/c/2964cc9d11c689514924a03efea0a7ea689deb56?branch=master )

Unfortunately, Koji tell me the golang-github-freetype package not in list for tag f30-pending. Do i need to resubmit request for pkg_review?
Comment 3 Robert-André Mauchin 🐧 2018-11-14 20:49:32 UTC 
> Unfortunately, Koji tell me the golang-github-freetype package not in list for tag f30-pending. Do i need to resubmit request for pkg_review?


That's because you changed the name of the package!

Name:           %{goname}

You can't do that!
Comment 4 Robert-André Mauchin 🐧 2018-11-14 20:57:51 UTC 
If you want to rename the package you must resubmut a review with the new name and retire the old one.
Comment 5 Robert-André Mauchin 🐧 2018-11-14 22:24:18 UTC 
 - You must install the license with %license in %files:

%license LICENSE.md

 - The license field s wrong: it should be MIT, not GPLv3


I fixed the freetype package and requested buildroot override for each release.
Comment 6 sensor.wen 2018-11-14 22:40:04 UTC 
>  - You must install the license with %license in %files:
> 
> %license LICENSE.md
> 
>  - The license field s wrong: it should be MIT, not GPLv3
> 

I fixed. https://github.com/FZUG/deepin-desktop/commit/90e6dc829eed65c1751226195bc15509ccb67115

> 
> I fixed the freetype package and requested buildroot override for each
> release.

It's great! :)
Comment 7 sensor.wen 2018-11-14 22:45:26 UTC 
(In reply to Robert-André Mauchin from comment #5)
> 
> I fixed the freetype package and requested buildroot override for each
> release.

I'm going to take notes....
Comment 8 Robert-André Mauchin 🐧 2018-11-14 22:50:33 UTC 
All right, package approved.


Buildroot override for F29 and F28 are done. F27 is still waiting: koji wait-repo f27-build --build=golang-github-BurntSushi-freetype-go-0-0.5.20181114gite2365df.fc27
Comment 9 Gwyn Ciesla 2018-11-19 15:12:38 UTC 
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-fogleman-gg
Note You need to log in before you can comment on or make changes to this bug.