Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 165329 - Review Request: roundup
Summary: Review Request: roundup
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Aurelien Bompard
QA Contact: Fedora Package Reviews List
URL: http://roundup.sourceforge.net
Whiteboard:
Depends On:
Blocks: FE-ACCEPT
TreeView+ depends on / blocked
 
Reported: 2005-08-08 02:07 UTC by W. Michael Petullo
Modified: 2007-11-30 22:11 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2005-09-17 23:29:21 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description W. Michael Petullo 2005-08-08 02:07:58 UTC
Spec Name or Url: http://flyn.org/SRPMS/roundup.spec
SRPM Name or Url: http://flyn.org/SRPMS/roundup-0.8.4-1.src.rpm
Description: Roundup is a simple and flexible issue-tracking system with command line, web and email interfaces.  It is based on the winning design from Ka-Ping Yee in the Software Carpentry "Track" design competition.

Comment 1 Aurelien Bompard 2005-08-10 08:35:36 UTC
- You can use http://dl.sourceforge.net/roundup/roundup-%{version}.tar.gz in the
URL tag, so it can be wget'ed directly
- insead of $RPM_SOURCE_DIR/roundup.conf you should use %{SOURCE1}, same thing
for %{SOURCE2} (which I would rename in roundup.init, but do as you want)
- please use the -p switch of install to preserve timestamps
- I'm not sure you can hardcode UID 58 for your roundup user. It could be used
already on some system. Just remove it, the -r switch will create a system
account anyway (100 < UID < 500)
- scriptlets should never echo anything. It could crash some frontends, or
simply be ignored by frontends. So:
  - Make sure everything goes to /dev/null with : > /dev/null 2>&1 (e.g. for
roundup-admin).
  - Don't echo things, write a README.Fedora instead
- don't delete your user on %postun, since the UID could change if the package
is reinstalled and the files will be unowned.
- you may want to stop the service only on erase, not on upgrade. See this page
: http://fedoraproject.org/wiki/ScriptletSnippets for more info dealing with
initscripts.
- you can use %{_initrddir} instead of %{_sysconfdir}/rc.d/init.d (yes, the name
is misleading, but it's the same)
- you can use disttag if you want to.

Comment 2 Aurelien Bompard 2005-08-10 08:42:10 UTC
- one more thing : if you want to test for the presence of the /var/lib/roundup
directory, it's the -d switch, not -f.

Comment 3 W. Michael Petullo 2005-08-12 00:13:43 UTC
Spec Name or Url: http://flyn.org/SRPMS/roundup.spec
SRPM Name or Url: http://flyn.org/SRPMS/roundup-0.8.4-2.src.rpm
Description: Roundup is a simple and flexible issue-tracking system with command
line, web and email interfaces.  It is based on the winning design from Ka-Ping
Yee in the Software Carpentry "Track" design competition.

Comment 4 W. Michael Petullo 2005-08-14 19:55:24 UTC
This version finishes implementing Aurelien's recommendations by fixing the use
of useradd.

Spec Name or Url: http://flyn.org/SRPMS/roundup.spec
SRPM Name or Url: http://flyn.org/SRPMS/roundup-0.8.4-3.src.rpm
Description: Roundup is a simple and flexible issue-tracking system with command
line, web and email interfaces.  It is based on the winning design from Ka-Ping
Yee in the Software Carpentry "Track" design competition.

Comment 5 W. Michael Petullo 2005-08-21 20:07:14 UTC
Bug #166451 proposes a SELinux policy for this Roundup package.

Comment 6 Aurelien Bompard 2005-09-04 11:45:50 UTC
* The summary is too long, please change it to "Simple and flexible
issue-tracking system"
* The roundup service is enabled by default. We usually don't do that with
network-listening daemons, please change the "345" to "-" at the top of the init
script.
* man pages are placed in /usr/man instead of /usr/share/man
* The lang file are not tagged properly, please use the %{find_lang} macro
(those two points will prevent from using INSTALLED_FILES, sorry...)
* the package should contain the text of the license (COPYING.txt)
* %{_initrddir}/roundup should be tagged as %config(noreplace) because of the
port setting
* you could support condrestart in scriptlets:
  %post
    if [ "$1" -ge "1" ]; then
        /sbin/service <script> condrestart >/dev/null 2>&1
    fi

Comment 7 W. Michael Petullo 2005-09-04 19:59:01 UTC
This version implements Aurelien's new recommendations.

Spec Name or Url: http://flyn.org/SRPMS/roundup.spec
SRPM Name or Url: http://flyn.org/SRPMS/roundup-0.8.4-4.src.rpm
Description: Roundup is a simple and flexible issue-tracking system with command
line, web and email interfaces.  It is based on the winning design from Ka-Ping
Yee in the Software Carpentry "Track" design competition.

Comment 8 Aurelien Bompard 2005-09-04 21:35:32 UTC
- the service is still enabled by default. At the top of the init script, you
have to change the line:
  # chkconfig: 345 95 5
to :
  # chkconfig: - 95 5

- while you're at it, you may want to change "%{_mandir}/*" to
"%{_mandir}/man1/*", or your package will own a standard dir (which is not
really a problem, but it would make our friend rpmlint happier)

Everything else looks fine.

Comment 9 W. Michael Petullo 2005-09-04 23:29:54 UTC
This time I really fixed the chkconfig: line.

Spec Name or Url: http://flyn.org/SRPMS/roundup.spec
SRPM Name or Url: http://flyn.org/SRPMS/roundup-0.8.4-5.src.rpm
Description: Roundup is a simple and flexible issue-tracking system with command
line, web and email interfaces.  It is based on the winning design from Ka-Ping
Yee in the Software Carpentry "Track" design competition.

Comment 10 Aurelien Bompard 2005-09-05 15:05:44 UTC
Passed:
* RPM name is OK
* Source roundup-0.8.4.tar.gz is the same as upstream
* Builds fine in mock
* rpmlint of roundup looks OK
* File list of roundup looks OK
* Seems to work fine

Comment 11 W. Michael Petullo 2005-09-17 23:29:21 UTC
Added roundup package to CVS and requested build.

Comment 12 Christian Iseli 2007-01-03 00:15:35 UTC
Changed summary for tracking purposes.



Note You need to log in before you can comment on or make changes to this bug.