Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 165662 - Review Request: perl-Regexp-Common
Summary: Review Request: perl-Regexp-Common
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Paul Howarth
QA Contact: David Lawrence
URL: http://search.cpan.org/dist/Regexp-Co...
Whiteboard:
Depends On:
Blocks: FE-ACCEPT
TreeView+ depends on / blocked
 
Reported: 2005-08-11 09:24 UTC by Ralf Corsepius
Modified: 2007-11-30 22:11 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2005-08-20 01:51:00 UTC
Type: ---
Embargoed:

Attachments (Terms of Use)

Description Ralf Corsepius 2005-08-11 09:24:54 UTC 
Spec Name or Url: ftp://packman.iu-bremen.de/fedora/SRPMS/perl-Regexp-Common.spec
SRPM Name or Url: ftp://packman.iu-bremen.de/fedora/SRPMS/perl-Regexp-Common-2.120-1.src.rpm

Description :
Regexp::Common - Provide commonly requested regular expressions
Comment 1 Paul Howarth 2005-08-19 17:15:38 UTC 
Review:

- rpmlint not quite clean - see below
- package and spec file naming is OK
- package meets guidelines
- license is Artistic (only)
- spec file written in English and is legible
- source matches upstream
- builds OK on FC4 and in mock for devel
- BR's OK
- no locales, libraries, subpackages, pkgconfigs etc. to worry about
- not relocatable
- no directory ownership or permissions issues
- no duplicate files
- %clean section present and correct
- macro usage is consistent
- code, not content
- no large docs
- docs don't affect runtime

Issues:

- rpmlint output
W: perl-Regexp-Common incoherent-version-in-changelog 1.120-1 2.120-1
Your last entry in %changelog contains a version that is not coherent with the
current version of your package.

This is just a typo in both of the specfile changelog entries.

- BR: perl is redundant

- find of empty .bs files is redundant

- suggest for %files:
%{perl_vendorlib}/Regexp/
rather than
%{perl_vendorlib}/*

These can be fixed post-import.

Approved.
Note You need to log in before you can comment on or make changes to this bug.