$ rpmlint libAfterImage-1.07-1.src.rpm 
W: libAfterImage spelling-error-in-description powerfull powerful


> %package devel
> Summary:  Development package for %{name}

Ambiguous. Suggest "Files needed for software development with %{name}"


%defattr missing in -devel %files section.


Suspicious error during %install:
[...]
/usr/bin/install -c -m 644 xwrap.h
/home/qa/tmp/rpm/tmp/libAfterImage-1.07-1-root-qa/usr/include/libAfterImage
cd apps; make install; cd ..
make[1]: Entering directory `/home/qa/tmp/rpm/BUILD/libAfterImage-1.07/apps'
make[1]: *** No rule to make target `../../libAfterImage/asimage.c', needed by
`../../libAfterImage/libAfterImage.so'.  Stop.
make[1]: Leaving directory `/home/qa/tmp/rpm/BUILD/libAfterImage-1.07/apps'
+ cd apps
[...]


While --enable-gdb may prevent compiler option -g from being removed
from default $RPM_OPT_FLAGS, it enables debug output in the library
(see "grep NO_DEBUG_OUTPUT * -R" and configure.in).


afterimage-config.in includes a hardcoded check for /usr/lib
which is supposed to prevent a standard library search path from
being added to the linker command-line with -L
(on x86_64 this check will fail and add -L/usr/lib64)

I believe the configure script looks for X in /usr/X11R6/lib also
on 64-bit platforms and probably won't find X libraries.


Why --enable-xlocale?


MMX -> This is from the included README:

> !!!!!!!!!!!!!!!!!!!!!!!!! MMX NOTICE !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
> Note:
> libAfterImage gets compiled with inline MMX assembly enabled.
> If you have CPU that does not support it - you'll
> have to manually turn that off by using --disable-mmx-optimization
> option to configure script.
> Otherwise you gonna get wierd segfaults and Illigal Instruction
> exceptions.
> !!!!!!!!!!!!!!!!!!!!!!!!! MMX NOTICE !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!

All issues fixed except for the spelling error. The description has a powerful
wich is the right spelling and I cannot whatsoever find powerfull anywhere else
(except in one .h file but I don't think patching it is that important).

http://fedora.lowlatency.de/review/libAfterImage-1.07-2.src.rpm
http://fedora.lowlatency.de/review/libAfterImage.spec

There is one instance of "Powerfull" in the description, in the beginning of 
the last paragraph. 

*narf* never trust a case sensitive grep and a blind packager... thx

Other issues? Otherwise I will add this change upon import...

> --- old/libAfterImage.spec      2005-08-20 03:21:51.000000000 +0200
> +++ new/libAfterImage.spec      2005-08-20 03:21:51.000000000 +0200
> @@ -1,6 +1,8 @@
> +%define debug_package %{nil}
> +

No way! ;-P  By doing this, you're shipping unstripped packages.
Correct fix would be to either patch the source (so that it doesn't
remove -g from CFLAGS) or to simulate default build-mode and
add -DNO_DEBUG_OUTPUT to CFLAGS (might increase maintenance efforts
for future versions, though, when developers modify default -D flags).

Anyway, feel free to fix this in CVS.

Makes sense =)



Thx for the review.

> gcc -O3 -DNO_DEBUG_OUTPUT -Wall -fexceptions -m32 -march=i386 -mtune=pentium4
>  -f asynchronous-unwind-tables -fPIC  -I/usr/include/freetype2
>   -I/usr/X11R6/include  -c afterbase.c -o afterbase.o

The -O3 in there looks like it mangles the CFLAGS even more than just
dropping -g. RPM_OPT_FLAGS' default -g -O2 ought to be in there.

I noticed... I changed this after import so it will use rpm supplied opt flags
and this works for FC4/i386 (at least here) but bails out on x86_64 (error is
the same for fc{3,4,5}):

http://buildsys.fedoraproject.org/logs//development/241-libAfterImage-1.07-3.fc5/

Ideas?

Hint is in there:

> /usr/bin/ld: afterbase.o: relocation R_X86_64_32 against `a local symbol'
> can not be used when making a shared object; recompile with -fPIC
> afterbase.o: could not read symbols: Bad value

"recompile with -fPIC" means to add -fPIC to the CFLAGS for all
object files which make it into the shared library