RPMLint looks good:
>$ rpmlint /var/lib/mock/fedora-29-x86_64/result/*.rpm
>4 packages and 0 specfiles checked; 0 errors, 0 warnings.

The %setup macro has been superseded by %autosetup.
Replace with "%autosetup -n %{project_name}-%{version}".

replace "make %{?_smp_mflags}" with %make_build macro.

Typically the %make_install macro is used in %install, instead of "make install". Looking at other qt5 packages, however, the norm seems to be "make install INSTALL_ROOT=%{buildroot}" so let's leave that as an exception.


In my opinion, the package description could be better. If there was no better source of documentation then I'd certainly understand why the description is the same as the summary, but in this case the github project page has a nice detailed description. Recommend you use that:
https://github.com/tumic0/QtPBFImagePlugin/#description


Did you have a specific reason to exclude the libpbf.so from provides?
I see that same exclusion in the core qt5-qtbase specfile. However, I'm not sure this should be done for the qt5 plugins. For example, when I look at the specfile for qt5-qtsvg plugin, it does not exclude the libqsvg.so library the plugin package provides. 


The qt5-qtsvg plugin package ties itself to the version of qt5-qtbase it was built against with:
%{?_qt5:Requires: %{_qt5}%{?_isa} = %{_qt5_version}}

We should do the same for this package.


If you plan to build against anything older than Fedora 28, then you need to add %ldconfig_scriptlets to %install. 
See: https://fedoraproject.org/wiki/Changes/Removing_ldconfig_scriptlets

Let me know if you have any questions.

For reference, here is the output of Fedora-Review. I will take a closer look at this output later this evening when I get home from dayjob to see if it found anything:


This is a review *template*. Besides handling the [ ]-marked tests you are
also supposed to fix the template before pasting into bugzilla:
- Add issues you find to the list of issues on top. If there isn't such
  a list, create one.
- Add your own remarks to the template checks.
- Add new lines marked [!] or [?] when you discover new things not
  listed by fedora-review.
- Change or remove any text in the template which is plain wrong. In this
  case you could also file a bug against fedora-review
- Remove the "[ ] Manual check required", you will not have any such lines
  in what you paste.
- Remove attachments which you deem not really useful (the rpmlint
  ones are mandatory, though)
- Remove this text



Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
=======
- Header files in -devel subpackage, if present.
  Note: qt5-qtpbfimageformat-debugsource :
  /usr/src/debug/qt5-qtpbfimageformat-1.2-1.fc29.x86_64/protobuf/vector_tile.pb.h
  qt5-qtpbfimageformat-debugsource :
  /usr/src/debug/qt5-qtpbfimageformat-1.2-1.fc29.x86_64/src/color.h qt5
  -qtpbfimageformat-debugsource :
  /usr/src/debug/qt5-qtpbfimageformat-1.2-1.fc29.x86_64/src/font.h qt5
  -qtpbfimageformat-debugsource :
  /usr/src/debug/qt5-qtpbfimageformat-1.2-1.fc29.x86_64/src/function.h qt5
  -qtpbfimageformat-debugsource :
  /usr/src/debug/qt5-qtpbfimageformat-1.2-1.fc29.x86_64/src/gzip.h qt5
  -qtpbfimageformat-debugsource :
  /usr/src/debug/qt5-qtpbfimageformat-1.2-1.fc29.x86_64/src/pbf.h qt5
  -qtpbfimageformat-debugsource :
  /usr/src/debug/qt5-qtpbfimageformat-1.2-1.fc29.x86_64/src/pbfhandler.h
  qt5-qtpbfimageformat-debugsource :
  /usr/src/debug/qt5-qtpbfimageformat-1.2-1.fc29.x86_64/src/pbfplugin.h qt5
  -qtpbfimageformat-debugsource :
  /usr/src/debug/qt5-qtpbfimageformat-1.2-1.fc29.x86_64/src/sprites.h qt5
  -qtpbfimageformat-debugsource :
  /usr/src/debug/qt5-qtpbfimageformat-1.2-1.fc29.x86_64/src/style.h qt5
  -qtpbfimageformat-debugsource :
  /usr/src/debug/qt5-qtpbfimageformat-1.2-1.fc29.x86_64/src/text.h qt5
  -qtpbfimageformat-debugsource :
  /usr/src/debug/qt5-qtpbfimageformat-1.2-1.fc29.x86_64/src/textitem.h qt5
  -qtpbfimageformat-debugsource :
  /usr/src/debug/qt5-qtpbfimageformat-1.2-1.fc29.x86_64/src/textpathitem.h
  qt5-qtpbfimageformat-debugsource :
  /usr/src/debug/qt5-qtpbfimageformat-1.2-1.fc29.x86_64/src/textpointitem.h
  qt5-qtpbfimageformat-debugsource :
  /usr/src/debug/qt5-qtpbfimageformat-1.2-1.fc29.x86_64/src/tile.h
  See: http://fedoraproject.org/wiki/Packaging/Guidelines#DevelPackages
- All build dependencies are listed in BuildRequires, except for any that
  are listed in the exceptions section of Packaging Guidelines.
  Note: These BR are not needed: gcc-c++
  See: http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2


===== MUST items =====

C/C++:
[ ]: Package does not contain kernel modules.
[ ]: Package contains no static executables.
[ ]: Development (unversioned) .so files in -devel subpackage, if present.
     Note: Unversioned so-files in private %_libdir subdirectory (see
     attachment). Verify they are not in ld path.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[ ]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[ ]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated". 41 files have unknown license. Detailed
     output of licensecheck in
     /home/abauer/1663492-qt5-qtpbfimageformat/licensecheck.txt
[ ]: License file installed when any subpackage combination is installed.
[ ]: Package does not own files or directories owned by other packages.
     Note: Dirs in package are owned also by: /usr/lib/.build-id(libreport-
     plugin-kerneloops, libhbalinux, cups-client, efivar-libs, xml-
     security-c, lz4-libs, qemu-block-gluster, rpm-plugin-selinux, abrt,
     libmediaart, libimagequant, giflib, libreoffice-graphicfilter,
     trousers, qemu-ui-gtk, libdb-utils, tracker-miners, xorg-x11-font-
     utils, PackageKit-command-not-found, OpenEXR-libs, libcom_err,
     libseccomp, p11-kit, libabw, gtkspell, libvirt-daemon-driver-storage-
     iscsi, libmodman, argyllcms, parted, gnome-disk-utility, libdvdread,
     slang, zstd, bluez-libs, libwebp, libxslt, system-config-printer-udev,
     perl-Encode, elfutils, python2-cryptography, libevdev, libgpg-error,
     lvm2-libs, libpurple, perl-Digest-SHA, libsodium, docker-ce-cli,
     python3-unbound, libzstd, libdazzle, xdg-desktop-portal-gtk, lua-lpeg,
     symlinks, python3-crypto, libzip, cdparanoia-libs, e2fsprogs-libs,
     pulseaudio-libs, lcms2, qemu-guest-agent, annobin, ntfs-3g, libxcb,
     libyubikey, remmina-plugins-st, python3-pycurl, python3-brlapi,
     openconnect, rtkit, xcb-util-keysyms, m4, sushi, libgphoto2,
     cdparanoia, xcb-util, gvfs-fuse, udisks2-iscsi, python3-coverage,
     anaconda-widgets, http-parser, pulseaudio-utils, mariadb-rocksdb-
     engine, llvm5.0-libs, perl-PerlIO-utf8_strict, libeot, systemd-
     bootchart, perl-Time-Piece, dbusmenu-qt, ncurses-libs, libidn2, ldns,
     perl-Sys-Syslog, gnome-color-manager, fcoe-utils, libyui-mga-ncurses,
     xorg-x11-xkb-utils, ibus-hangul, NetworkManager-openvpn, libxkbfile,
     hplip-libs, libwvstreams, freerdp-libs, xmlrpc-c-client, sane-
     backends-drivers-cameras, python3-hawkey, libwpd, enchant2, libdc1394,
     libvirt-daemon-driver-qemu, perl-Time-HiRes, qemu-block-ssh, libwps,
     gssdp, fuse-overlayfs, gnome-calendar, libacl, xorg-x11-drv-ati,
     libSM, policycoreutils, mcelog, remmina-plugins-xdmcp, abrt-plugin-
     bodhi, libmusicbrainz5, perl-Digest-SHA3, perl-Digest-SHA1, sane-
     backends-drivers-scanners, libXxf86misc, foomatic, minizip, colord-
     gtk, libpath_utils, rpm-build, wodim, libvirt-daemon-driver-storage-
     sheepdog, libglvnd-gles, python3-audit, redhat-lsb-core, libmicrodns,
     zerofree, freeglut, gstreamer1, gom, gmime30, libtomcrypt, dbus-libs,
     libreoffice-gtk3, libreoffice-gtk2, librtmp, cairo-gobject, gnome-
     screenshot, libkkc, gutenprint, usermode, qpdf-libs, linux-atm-libs,
     libedit, openssh, atk, python3-cairo, python2-libdnf, accountsservice,
     isl, hfsplus-tools, perl-IPC-SysV, gssproxy, mesa-libGLU, libblockdev-
     btrfs, libatomic_ops, gupnp-av, clang6.0-libs, librepo, rubygem-io-
     console, python3-iscsi-initiator-utils, libyui-ncurses, libvirt-
     daemon-driver-interface, NetworkManager, libkate, liblangtag,
     libdatrie, glade-libs, setuptool, libcryptui, guile, pcre-utf16, tree,
     gvfs-goa, pipewire, glusterfs-libs, gnupg, libnsl2, xfsprogs,
     libhbaapi, authselect, libcroco, qt5-qtsensors, telepathy-glib,
     plymouth-plugin-label, colord-libs, aalib-libs, gstreamer1-libav,
     libcddb, efivar, gpgmepp, libgcab1, libzhuyin, gvnc, hypervfcopyd,
     cronie, qemu-user-static, rpm-libs, nettle, libcacard, libverto-libev,
     remmina-plugins-nx, colord, libpipeline, pkcs11-helper,
     accountsservice-libs, network-scripts, gnome-system-monitor,
     findutils, popt, python2-xpyb, qt5-qtx11extras, libsss_idmap,
     libraw1394, folks, gnome-clocks, iptables, iproute-tc, libipa_hbac,
     libupnp, remmina-plugins-secret, containerd.io, spice-glib, woff2,
     dotconf, libXfont, PackageKit-glib, patch, zabbix, lttng-ust, enchant,
     libXxf86dga, python2-smartcols, rhash, xdg-user-dirs-gtk, libwayland-
     client, pinentry-gnome3, libsmbios, libXres, mdadm, device-mapper,
     python2-librepo, libXtst, perl-Text-Soundex, gnome-terminal, GeoIP,
     clamav, libsigc++20, dconf-editor, avidemux-qt, libXrandr, newt,
     liba52, hplip, crda, libical, sheepdog, qt5-qtdeclarative, vo-
     amrwbenc, remmina-plugins-exec, libftdi, libXfont2, libblockdev-loop,
     libmfx, libssh2, NetworkManager-adsl, open-vm-tools-desktop,
     xmlsec1-nss, libXcursor, nftables, iio-sensor-proxy, dracut, procps-
     ng, plymouth-core-libs, perl-Mail-Transport-Dbx, telnet, libXpm,
     xorg-x11-drv-nouveau, bluez-obexd, zlib, libpeas, pam_krb5,
     gutenprint-cups, PackageKit-gstreamer-plugin, avahi, libselinux,
     ncurses-compat-libs, libassuan, nodejs, expat, cups-filters, iw,
     clutter-gtk, userspace-rcu, libblockdev-utils, libgudev, python3-yui,
     live555, ibus-libpinyin, setroubleshoot-server, make,
     python3-markupsafe, clutter-gst2, libnice, libcdr, libsoup, perl-
     Pango, glusterfs-api, fuse, perl-Net-SSLeay, perl-Filter, cups-libs,
     libappstream-glib, libsepol, totem-pl-parser, gzip, keyutils,
     isomd5sum, libfdisk, libdmx, openssl-libs, corosynclib, opencc,
     libreport-plugin-reportuploader, libguestfs-tools-c, remmina-plugins-
     vnc, gavl, libatasmart, perl-XML-Parser, ipset, x265-libs, unique,
     libyui-gtk, libcaca, keybinder3, deltarpm, fuse-libs, xorg-x11-xauth,
     libglvnd-glx, runc, gvfs-smb, gtkspell3, libcue, libXrender, json-
     glib, libX11-xcb, libfontenc, libicu, libgsf, xorg-x11-drv-vmware,
     sssd-common, NetworkManager-openconnect, libgtop2, btrfs-progs,
     SDL2_mixer, libserialport, wvdial, perl-Devel-PPPort, protobuf-c,
     xerces-c, mesa-libglapi, bolt, glx-utils, libtommath, evolution-data-
     server, PackageKit, daxctl-libs, libass, grsync, SDL_image, libstdc++,
     ppp, python2-crypto, libtiger, git, perl-Compress-Raw-Bzip2, jack-
     audio-connection-kit, mpg123-libs, opus, tcpdump, libxklavier,
     traceroute, cyrus-sasl-plain, libblockdev-crypto, libreoffice-
     pdfimport, mariadb-server-utils, rp-pppoe, libtheora, attr, mtr,
     libblockdev-part, plymouth, libcanberra-gtk3, mariadb-cracklib-
     password-check, autofs, mtdev, mailx, telepathy-logger, systemd-udev,
     brasero, libXvMC, cheese-libs, libXmu, capstone, jasper-libs, librbd1,
     device-mapper-libs, xorg-x11-xinit, gnome-initial-setup, libffi,
     libGLEW, python2-hawkey, diffutils, chrony, time, checkpolicy, mpfr,
     cyrus-sasl-md5, iputils, qt5-qtxmlpatterns, numactl-libs, libvirt-
     daemon-driver-nwfilter, libwmf-lite, tigervnc-server-minimal, gpgme,
     hypervvssd, xorg-x11-drv-openchrome, libmcpp, libibverbs, gdb-
     headless, dleyna-core, qemu-audio-pa, libgovirt, libqmi-utils,
     libmbim-utils, psacct, lame-libs, gnome-bluetooth-libs, usbredir,
     ghostscript, iproute, llvm4.0-libs, cryptsetup-libs, gnome-control-
     center, syslinux-extlinux, bind-libs, pygobject2, ghostscript-x11,
     lua-posix, libinput, libreport-cli, libpkgconf, python3-dmidecode,
     libyui-mga, abrt-gui-libs, gegl, libosinfo, libabigail, corosync,
     qt5-qtsvg, llvm3.9-libs, libreoffice-calc, sni-qt, libqmi, gawk,
     dmraid-events, pcsc-lite-libs, adwaita-gtk2-theme, libbasicobjects,
     baobab, rdma-core, vte291, libgweather, sssd-krb5, nmap,
     NetworkManager-strongswan-gnome, perl-Devel-Peek, brotli, libgrss,
     libdvbpsi, httpd, libsmbclient, libkcapi, libvdpau, compat-openssl10,
     opencore-amr, abrt-addon-kerneloops, libnftnl, gnome-maps, oddjob-
     mkhomedir, python3-libvirt, openCOLLADA, xcb-util-renderutil,
     libwinpr, sssd-ad, libpinyin, freetype, logrotate, rdist, scl-utils,
     libdnet, ntfsprogs, abrt-libs, efibootmgr, libgdither, samba-common-
     libs, libreswan, libpsl, python3-rpm, nautilus-sendto, fwupdate-libs,
     jimtcl, libuser, NetworkManager-libreswan, arduino-ctags, libnotify,
     abrt-retrace-client, avrdude, boost-date-time, tbb, satyr, pixman,
     gnome-font-viewer, wpa_supplicant, perl-Cairo, xorg-x11-drv-vesa,
     libbluray, brltty, libwmf, texlive-lib, libbabeltrace, vpnc, psmisc,
     net-snmp-libs, xorg-x11-drv-libinput, libsss_certmap, libblockdev-
     mpath, cairo, libgcc, gdisk, ilmbase, perl-Compress-Bzip2, poppler,
     pocl, libstemmer, djvulibre-libs, bison, ibus-libzhuyin, fftw-libs-
     double, avahi-gobject, libconfig, ModemManager, abrt-gui, ibus-m17n,
     podman, qemu-img, qt5-qtbase-gui, sgpio, orc, polkit, qt-devel,
     libuuid, faad2-libs, libarchive, libfreehand, ibus-gtk3, ibus-gtk2,
     cheese, udisks2, clucene-contribs-lib, paps-libs, tcp_wrappers, xz,
     libXcomposite, rpcbind, mtools, pygtk2, criu, vim-minimal, harfbuzz-
     icu, evolution, libplist, gstreamer-tools, xdg-user-dirs, perl-Glib,
     hwloc-libs, spice-server, libreport-plugin-logger, gdk-pixbuf2, gupnp,
     libreport, libevent, redland, libknet1-crypto-nss-plugin,
     python2-cccolutils, git-core, gnome-characters, slirp4netns,
     pypoppler, libblockdev, librdmacm, lua-socket, dconf, xz-libs, dbus-
     glib, PackageKit-gtk3-module, bash, libdvdnav, strongswan, libcap,
     libprojectM, libvirt-daemon-driver-storage-zfs, libwbclient, kmod,
     libvirt-daemon-driver-storage-gluster, numad, libbonobo, mod_http2,
     libthai, fakeroot, gnome-session, nss-tools, adcli, libetonyek,
     libtirpc, python2-gpg, libsmartcols, gsound, fakeroot-libs, libwpg,
     os-prober, ethtool, libreofficekit, vorbis-tools, libfprint, systemd-
     libs, cpio, libknet1, libfdt, util-linux, libburn, apr-util-bdb,
     krb5-libs, gnome-online-accounts, net-tools, enca, llvm6.0-libs,
     gtksourceview3, libpciaccess, clucene-core, libsss_autofs, compiler-
     rt, libxml++, NetworkManager-pptp, zabbix-agent, libguestfs,
     libcanberra-gtk2, libgs, libgnome, gnome-user-share, sssd-client,
     libgxps, systemd, webkit2gtk3-jsc, libpagemaker, highlight, js,
     libxkbcommon, device-mapper-multipath-libs, perl-XML-LibXML, yajl,
     lockdev, cups-filters-libs, poppler-utils, lpsolve, xorg-x11-server-
     utils, NetworkManager-bluetooth, gnupg2, libvirt-daemon-driver-
     storage-iscsi-direct, cracklib, evince-libs, libepubgen, libdnf, ruby,
     abrt-addon-pstoreoops, gnome-keyring, libdbusmenu-gtk3, libdbusmenu-
     gtk2, pulseaudio-libs-glib2, libnice-gstreamer1, lxpolkit, nm-
     connection-editor, python3-pyparted, libudisks2, gstreamer1-plugins-
     bad-free, NetworkManager-libreswan-gnome, python3-setools, clutter,
     zenity, rhythmbox, chkconfig, libgnome-keyring, hostname, iscsi-
     initiator-utils, gparted, pptp, librados2, libvirt-daemon-driver-
     storage-mpath, pam, python2-cffi, openldap, evince-nautilus, ipcalc,
     SDL, speex, libvirt-daemon-driver-storage-logical, ibus-wayland, neon,
     rest, libsamplerate, python2-lxml, NetworkManager-vpnc-gnome, boost-
     iostreams, geocode-glib, pakchois, zfs-fuse, libusbmuxd, perl-Unicode-
     Normalize, gperftools-libs, libimobiledevice, lzop, NetworkManager-
     wwan, polkit-pkla-compat, jbig2dec-libs, epiphany-runtime, libmtp,
     cyrus-sasl-lib, librevenge, nspr, gjs, python3-gobject-base, perl-
     Gtk2, gnome-settings-daemon, gnupg2-smime, dnsmasq, geoclue2-libs,
     libXfixes, libblkid, libcdio, libsss_sudo, rsync, gnome-software, lua-
     libs, perl-Params-Util, authselect-libs, soundtouch, xorg-x11-drv-
     evdev, libpeas-gtk, libXinerama, lirc-libs, libteam, libcmis,
     libesmtp, acl, cyrus-sasl-scram, libogg, libkadm5, libphodav,
     vid.stab, libgee, libXxf86vm, mesa-libEGL, python2-pyxattr, rpm-
     plugin-systemd-inhibit, systemd-pam, python2-libvirt, libyui-mga-qt,
     ftgl, perl-Storable, perl-Digest-MD5, libreoffice-ogltrans, lshw-gui,
     gvfs-gphoto2, perl-File-FcntlLock, perl-Sort-Key, libvirt-daemon-
     driver-storage-rbd, nss-util, libsemanage, marisa, mozjs52, systemd-
     container, libcomps, at, file, libdca, libblockdev-fs, java-1.8.0
     -openjdk-headless, libblockdev-nvdimm, libnma, gettext, perl-Sys-
     Guestfs, soxr, espeak, libvirt-gobject, libutempter, gnome-remote-
     desktop, libmetalink, java-1.8.0-openjdk, openblas-serial, gvfs-afp,
     usbutils, e2fsprogs, libcdio-paranoia, grub2-tools-minimal, cpp,
     libksba, libwayland-server, virglrenderer, gdbm, libchromaprint,
     osinfo-db-tools, libsndfile, libblockdev-vdo, libvisio, ruby-libs,
     bzip2-libs, openssl-pkcs11, gnutls, libyui-mga-gtk, mariadb-gssapi-
     server, device-mapper-persistent-data, python2-krbv, webkit2gtk3
     -plugin-process-gtk2, libselinux-utils, perl-Scalar-List-Utils,
     dosfstools, rng-tools, lightspark, gnome-abrt, libspectre, compat-
     openssl10-pkcs11-helper, icedax, keyutils-libs, libproxy, sssd-common-
     pac, libreoffice-math, libtimezonemap, perl-Data-Dumper, glusterfs-
     fuse, game-music-emu, pidgin, anaconda-core, libnfsidmap, nautilus-
     dropbox, mlocate, tmux, file-libs, grub2-tools, perl-Locale-gettext,
     avahi-glib, mokutil, libblockdev-swap, libnetfilter_conntrack,
     python3-gobject, libev, frei0r-plugins, fprintd-pam, libgepub,
     libusbx, NetworkManager-openvpn-gnome, qrencode-libs, libICE,
     libgexiv2, drpm, qemu-block-nfs, createrepo_c-libs, grilo, libgpod,
     perl-Compress-Raw-Zlib, libindicator-gtk3, speexdsp, upower,
     libreoffice-x11, nautilus, xcb-util-wm, clamav-lib, openssl, docker-
     ce, dbxtool, gnome-vfs2, alsa-lib, gstreamer1-plugins-good-gtk,
     libwnck3, x264-libs, python2-gobject, gtkmm24, libvirt-daemon-driver-
     storage-disk, brasero-libs, mesa-dri-drivers, pyliblzma, python3-abrt,
     libffado, mariadb, suitesparse, ibus-kkc, gdbm-libs, fribidi,
     libgnomekbd, libblockdev-kbd, ibus-rawcode, pciutils, libini_config,
     openssh-clients, libX11, celt051, beignet, kyotocabinet-libs,
     python3-pwquality, gvfs-mtp, python3-cryptography, gnome-bluetooth,
     clamav-update, u2f-hidraw-policy, libXcomp, libnl3, gimp-libs, libidn,
     grubby, openjpeg-libs, xorg-x11-server-Xephyr, python2-gssapi,
     python3-libreport, libdbusmenu, mariadb-server, libbytesize, libmpeg2,
     qemu-block-rbd, python3-systemd, iptables-libs, rpm-ostree-libs,
     libnl3-cli, ibus-libs, python2-libcomps, python2-pyyaml, audit-libs,
     bluez, gettext-libs, liborcus, cups, qt5-qtwayland, libref_array,
     gvfs-afc, switcheroo-control, astyle, fwupd, raptor2, gtk-update-icon-
     cache, libyui, plymouth-plugin-two-step, sbc, qt-x11, libsane-hpaio,
     libhangul, ocl-icd, poppler-glib, pcaudiolib, seahorse, libblockdev-
     lvm, libopenraw, lvm2, harfbuzz, lash-libs, libva, dmraid,
     python3-wrapt, gvfs-client, NetworkManager-libnm, python2-libs, ibus-
     qt, gnome-boxes, lrzsz, libglvnd-egl, libunwind, python3-newt, dhcp-
     libs, dpkg, libtalloc, libtar, hypervkvpd, libepoxy, libreoffice-
     impress, man-db, gedit, libvirt-daemon-driver-storage-core, perl-DBD-
     MySQL, libibumad, libgadu, boost-locale, timedatex, python3-dbus, xdg-
     desktop-portal, qt-mobility-location, python2-pynacl, rasqal,
     wireless-tools, libdb, passwd, cups-pk-helper, gnome-calculator, kmod-
     libs, NetworkManager-team, libdv, gutenprint-libs, libreoffice-writer,
     desktop-file-utils, libXdamage, xorg-x11-utils, libmwaw, libusal, gcc-
     gdb-plugin, dleyna-connector-dbus, gtkmm30, unbound-libs,
     clang5.0-libs, gobject-introspection, libpwquality, discord,
     fontconfig, compat-ffmpeg28, libblockdev-dm, meanwhile, avr-gcc-c++,
     perl-Math-BigInt-FastCalc, evince-djvu, libkcapi-hmaccalc, grep,
     libdaemon, mariadb-connector-c, tcl, flatpak, python3-librepo,
     pkgconf, vino, json-c, sed, sssd-ipa, jemalloc, perl-threads-shared,
     libaio, gdm, kpartx, libpng, sane-backends-libs, python3-pillow,
     ostree-libs, cyrus-sasl, hardlink, libcollection, libgcrypt, cairomm,
     perl-Unicode-UTF8, lash, geoclue2, lsof, at-spi2-atk, cronie-anacron,
     gnome-online-miners, twolame-libs, adwaita-qt4, avahi-ui-gtk3, gnome-
     shell, cups-ipptool, xorg-x11-server-Xorg, usbmuxd, libmbim, perl-IO,
     libomp, libverto, glibmm24, libXScrnSaver, realmd, libmspub, ncurses,
     nfs-utils, graphite2, python3-kerberos, perl-List-MoreUtils-XS,
     passwdqc-lib, libmad, libpng12, ndctl-libs, gmp, sssd-krb5-common,
     volume_key-libs, b43-fwcutter, farstream02, mariadb-backup,
     libzapojit, ffmpeg-libs, alsa-plugins-pulseaudio, perl-interpreter,
     bluez-cups, gimp, chromium-libs-media, libcurl, coreutils, libcap-ng,
     gvfs, dbus-x11, pinentry, libvirt-daemon-driver-storage-scsi,
     libmpcdec, nautilus-extensions, remmina-plugins-rdp, qemu-common, gsm,
     libuv, boost-filesystem, libtevent, libchamplain, libglvnd, gnome-
     documents-libs, boost-system, libpcap, qemu-block-iscsi, snappy,
     libindicator, clutter-gst3, mozjs60, libdrm, genisoimage, rubygem-
     bigdecimal, pcre2, shotwell, xmlrpc-c, jsoncpp, perl-TermReadKey,
     qt5-qtwebkit, espeak-ng, cogl, rygel, libpng-devel, perl-MIME-Base64,
     libvirt-glib, sssd-nfs-idmap, libmspack, perl-Unicode-Collate, libssh,
     libmodulemd, GConf2, glibc, wkhtmltopdf, proj, xz-lzma-compat,
     ttmkfdir, flatpak-libs, fipscheck, mactel-boot, bc, gtk-vnc2, quota,
     wget, libijs, zip, python2-unbound, libreport-web, libgomp, libexif,
     libvirt-daemon-driver-secret, php-cli, libgusb, glib2, hesiod, spirv-
     tools-libs, python2-libxml2, qemu-system-x86-core, libproxy-mozjs,
     pcre2-utf16, libmnl, gettext-devel, libzmf, libmng, nss, pcre,
     libchamplain-gtk, tcp_wrappers-libs, sane-backends, gstreamer1
     -plugins-base, spax, speech-dispatcher, php-common, cdrdao, pciutils-
     libs, libiptcdata, libmpc, libXi, file-roller, openjpeg2, libmatroska,
     flac-libs, libXt, libXv, rubygem-openssl, libexttextcat, info,
     libnfnetlink, libiec61883, gstreamer, rpm-sign-libs, device-mapper-
     event, libreport-plugin-bugzilla, avr-gcc, qt5-qtbase, libpskc, ibus,
     python3-lxml, gamin, jwhois, qemu-block-dmg, curl, yelp-libs, cmake,
     libdmapsharing, rubygem-json, fipscheck-lib, hivex, scrub,
     python2-pycurl, qt-mobility-sensors, dos2unix, paps, libqxp, abrt-tui,
     lzo-minilzo, ustr, abrt-addon-xorg, libdhash, gnome-keyring-pam, sssd-
     proxy, zchunk-libs, totem, gd, gc, python3-cups, libxshmfence, jssc,
     qemu-block-curl, libreport-plugin-systemd-journal, gstreamer1-plugins-
     ugly-free, atlas, p11-kit-server, unzip, apr-util-openssl, vlc, gtk2,
     gtk3, libwayland-egl, libv4l, atkmm, npth, abrt-addon-coredump-helper,
     libyaml, gspell, xcb-util-image, m17n-lib, libblockdev-mdraid,
     glusterfs, exiv2-libs, libebml, libunistring, postgresql-libs, dleyna-
     server, qgnomeplatform, gstreamer1-plugins-good, python2-rpm,
     libasyncns, perl-Sys-Virt, python2-pygpgme, device-mapper-multipath,
     c-ares, xmlsec1-openssl, pulseaudio-module-x11, python2-cairo,
     gfbgraph, NetworkManager-pptp-gnome, jansson, bind-utils, librsvg2,
     firefox, apr, libsss_nss_idmap, gupnp-dlna, trousers-lib, nxproxy,
     libnumbertext, libaom, libmp4v2, webrtc-audio-processing, bcache-
     tools, startup-notification, babl, libstaroffice, pinfo, bubblewrap,
     elfutils-libs, gcc-c++, speech-dispatcher-espeak-ng, libtasn1,
     jbigkit-libs, perl-libintl-perl, libe-book, alsa-utils, sqlite, tar,
     sudo, dhcp-client, fprintd, pinentry-gtk, gcc, dwz, xorg-x11-drv-qxl,
     gcr, oddjob, ebtables, libyui-qt, compat-libvpx4, avahi-libs,
     qtwebkit, pigz, python3-pyyaml, libappindicator-gtk3, libquvi, gvfs-
     archive, qemu-system-arm-core, libao, perl-libs, lz4, kbd, perl-hivex,
     jna, dbus-daemon, libreoffice-core, gupnp-igd, libwayland-cursor,
     openvpn, libpaper, squashfs-tools, chromium-libs, gstreamer1-plugins-
     ugly, xvidcore, libwacom, lzo, pango, gstreamer-plugins-base, libss,
     libshaderc, mod_dnssd, esmtp, polkit-libs, perl-threads, perl-Params-
     Validate, compat-readline6, pangomm, cryptsetup, mesa-libxatracker,
     nss-sysinit, LibRaw, libsphinxclient, nss-mdns, sqlite-libs,
     python3-cffi, at-spi2-core, libvirt-daemon-driver-network, gegl04,
     yum-metadata-parser, glibc-common, liblockfile, clang-libs, bind-
     export-libs, ndctl, xalan-c, libcxxabi, gnome-autoar, lshw,
     qt5-qtlocation, python3-libxml2, libnfs, avidemux-libs, libgfortran,
     stoken-libs, gnome-contacts, libiscsi, groff-base, mesa-libgbm,
     libusb, mesa-libGL, perl-HTML-Parser, abrt-addon-ccpp, libldb, libldm,
     bind-libs-lite, NetworkManager-vpnc, libmodplug, libvirt-daemon-
     driver-nodedev, libipt, libcanberra, grub2-tools-efi, wavpack,
     xorg-x11-drv-wacom, libsrtp, perl-Package-Stash-XS, samba-client-libs,
     which, boost-chrono, samba-client, perl-Variable-Magic, glib-
     networking, lua-expat, python3-cccolutils, libquadmath, qemu-ui-
     curses, libshout, libvirt-gconfig, brlapi, createrepo_c, libreport-
     gtk, liboauth, lmdb-libs, xmlsec1, isns-utils-libs, libmypaint,
     libIDL, libwsman1, krb5-workstation, nmap-ncat, ykpers, libglvnd-
     opengl, vlc-core, lksctp-tools, libgltf, usb_modeswitch,
     python3-libdnf, mythes, rubygem-psych, NetworkManager-wifi, qt, kexec-
     tools, teamd, libvorbis, NetworkManager-openconnect-gnome, vconfig,
     pcre-cpp, python3-libselinux, libodfgen, liblouis, exiv2, ORBit2,
     qt5-qtwebchannel, avr-binutils, lua, qt3, libpeas-loader-python3,
     llvm-libs, gnome-logs, pulseaudio-module-bluetooth, libvirt-libs,
     passwdqc, libXft, schroedinger, libattr, perl-DBI, hyphen, zvbi,
     containernetworking-plugins, rpm, qemu-audio-oss, syslinux, libxcrypt,
     sssd-ldap, iptstate, libreport-plugin-ureport, radvd, libplacebo,
     python3-libs, libappindicator, glusterfs-cli, perl-PathTools, ipset-
     libs, arduino-builder, remmina, perl-Devel-Size, plymouth-graphics-
     libs, mozjs38, gnome-menus, glusterfs-client-xlators, libreoffice-
     pyuno, hexedit, libxml2, gmime, libreoffice-ure, iscsi-initiator-
     utils-iscsiuio, cyrus-sasl-gssapi, mpage, libargon2, mesa-vulkan-
     drivers, mousetweaks, libvirt-daemon, protobuf-lite, libsecret,
     strongswan-charon-nm, libnet, p11-kit-trust, dcraw, nss-softokn,
     augeas-libs, libsysfs, audit, perl-Cpanel-JSON-XS, abrt-dbus, gnome-
     desktop3, gdk-pixbuf2-modules, binutils, xen-libs, libisofs, nss-pem,
     python2-kerberos, arduino-listSerialPortsC, less, cifs-utils, libvpx,
     evince, rpm-build-libs, libnghttp2, util-linux-user, totem-nautilus,
     libsolv, exempi, libxkbcommon-x11, chromium, libtdb, python3-gpg,
     libXdmcp, perl-Socket, apr-util, python2-bcrypt, aspell, libatomic,
     libvisual, python3, python2, gpm-libs, adwaita-qt5, mariadb-tokudb-
     engine, xorg-x11-server-Xwayland, supermin, perl-DB_File, dbus-tools,
     shared-mime-info, httpd-tools, SDL2, webkit2gtk3, libsigsegv, boost-
     thread, grilo-plugins, dvd+rw-tools, shadow-utils, boost-random,
     libcgroup, libXau, netcf-libs, libgdata, libspiro, dmidecode, qemu-
     audio-alsa, python3-libcomps, libjpeg-turbo, spice-gtk3, fuse3-libs,
     libmount, spice-vdagent, xorg-x11-drv-wacom-serial-support, xorg-x11
     -drv-fbdev, libqb, libavc1394, lldpad, libtiff, python3-libsemanage,
     libvncserver, sg3_utils-libs, ima-evm-utils, tracker, ed, python2
     -gobject-base, mesa-libOpenCL, grub2-tools-extra, qemu-audio-sdl,
     openssh-server, fluidsynth-libs, mutter, taglib, eog, libXext, mcpp,
     ModemManager-glib, bridge-utils, ostree, device-mapper-event-libs,
     initscripts, hunspell, libieee1284, libndp, pulseaudio, qemu-ui-sdl,
     lsscsi, bzip2, libcxx, elfutils-libelf, nss-softokn-freebl, open-vm-
     tools, evolution-ews, python3-smartcols, libtool-ltdl, readline,
     sphinx, yelp, xorg-x11-drv-intel, vulkan-loader, abrt-java-connector,
     perl-version), /usr/lib/.build-id/36(hyphen, kbd, libcdio, perl-
     interpreter, kyotocabinet-libs, util-linux, glibc, libnl3,
     python2-libs, gstreamer1-plugins-bad-free, mesa-libOpenCL, chromium-
     libs, sane-backends-drivers-scanners, vlc-core, cups-client, brltty,
     hypervfcopyd, libXrandr, evolution-data-server, PackageKit,
     openCOLLADA, cracklib, libmetalink)
[ ]: %build honors applicable compiler flags or justifies otherwise.
[ ]: Package contains no bundled libraries without FPC exception.
[ ]: Changelog in prescribed format.
[ ]: Sources contain only permissible code or content.
[ ]: Package contains desktop file if it is a GUI application.
[ ]: Development files must be in a -devel package
[ ]: Package uses nothing in %doc for runtime.
[ ]: Package consistently uses macros (instead of hard-coded directory
     names).
[ ]: Package is named according to the Package Naming Guidelines.
[ ]: Package does not generate any conflict.
[ ]: Package obeys FHS, except libexecdir and /usr/target.
[ ]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[ ]: Requires correct, justified where necessary.
[ ]: Spec file is legible and written in American English.
[ ]: Package contains systemd file(s) if in need.
[ ]: Useful -debuginfo package or justification otherwise.
[ ]: Package is not known to require an ExcludeArch tag.
[ ]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 10240 bytes in 1 files.
[ ]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: No rpmlint messages.
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[ ]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[ ]: Final provides and requires are sane (see attachments).
[ ]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in qt5
     -qtpbfimageformat-debuginfo , qt5-qtpbfimageformat-debugsource
[ ]: Package functions as described.
[ ]: Latest version is packaged.
[ ]: Package does not include license text files separate from upstream.
[ ]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[ ]: Package should compile and build into binary rpms on all supported
     architectures.
[ ]: %check is present and all tests pass.
[ ]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Uses parallel make %{?_smp_mflags} macro.
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on debuginfo package(s).
     Note: No rpmlint messages.
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: qt5-qtpbfimageformat-1.2-1.fc29.x86_64.rpm
          qt5-qtpbfimageformat-debuginfo-1.2-1.fc29.x86_64.rpm
          qt5-qtpbfimageformat-debugsource-1.2-1.fc29.x86_64.rpm
          qt5-qtpbfimageformat-1.2-1.fc29.src.rpm
4 packages and 0 specfiles checked; 0 errors, 0 warnings.




Rpmlint (debuginfo)
-------------------
Checking: qt5-qtpbfimageformat-debuginfo-1.2-1.fc29.x86_64.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

For some reason fedora-review is taking forever to run. I'll have more feedback once that completes.



Rpmlint (installed packages)
----------------------------
sh: /usr/bin/python: No such file or directory
qt5-qtpbfimageformat.x86_64: W: invalid-url URL: https://github.com/tumic0/QtPBFImagePlugin/ <urlopen error [Errno -2] Name or service not known>
qt5-qtpbfimageformat-debuginfo.x86_64: W: invalid-url URL: https://github.com/tumic0/QtPBFImagePlugin/ <urlopen error [Errno -2] Name or service not known>
qt5-qtpbfimageformat-debugsource.x86_64: W: invalid-url URL: https://github.com/tumic0/QtPBFImagePlugin/ <urlopen error [Errno -2] Name or service not known>
3 packages and 0 specfiles checked; 0 errors, 3 warnings.



Requires
--------
qt5-qtpbfimageformat (rpmlib, GLIBC filtered):
    libGL.so.1()(64bit)
    libQt5Core.so.5()(64bit)
    libQt5Core.so.5(Qt_5)(64bit)
    libQt5Core.so.5(Qt_5.11)(64bit)
    libQt5Gui.so.5()(64bit)
    libQt5Gui.so.5(Qt_5)(64bit)
    libc.so.6()(64bit)
    libgcc_s.so.1()(64bit)
    libgcc_s.so.1(GCC_3.0)(64bit)
    libm.so.6()(64bit)
    libprotobuf-lite.so.15()(64bit)
    libpthread.so.0()(64bit)
    libstdc++.so.6()(64bit)
    libstdc++.so.6(CXXABI_1.3)(64bit)
    libstdc++.so.6(CXXABI_1.3.9)(64bit)
    libz.so.1()(64bit)
    rtld(GNU_HASH)

qt5-qtpbfimageformat-debuginfo (rpmlib, GLIBC filtered):

qt5-qtpbfimageformat-debugsource (rpmlib, GLIBC filtered):



Provides
--------
qt5-qtpbfimageformat:
    qt5-qtpbfimageformat
    qt5-qtpbfimageformat(x86-64)

qt5-qtpbfimageformat-debuginfo:
    debuginfo(build-id)
    qt5-qtpbfimageformat-debuginfo
    qt5-qtpbfimageformat-debuginfo(x86-64)

qt5-qtpbfimageformat-debugsource:
    qt5-qtpbfimageformat-debugsource
    qt5-qtpbfimageformat-debugsource(x86-64)



Unversioned so-files
--------------------
qt5-qtpbfimageformat: /usr/lib64/qt5/plugins/imageformats/libpbf.so

Source checksums
----------------
https://github.com/tumic0/QtPBFImagePlugin/archive/1.2/QtPBFImagePlugin-1.2.tar.gz :
  CHECKSUM(SHA256) this package     : 9caf6d9074d5c740f73c114f9fb0e151ff9379e355020b1a3020e87b3bb6d485
  CHECKSUM(SHA256) upstream package : 9caf6d9074d5c740f73c114f9fb0e151ff9379e355020b1a3020e87b3bb6d485


Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02
Command line :/usr/bin/fedora-review -b 1663492
Buildroot used: fedora-29-x86_64
Active plugins: Generic, Shell-api, C/C++
Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP
Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6

(In reply to Andrew Bauer from comment #1)
> The %setup macro has been superseded by %autosetup.
> Replace with "%autosetup -n %{project_name}-%{version}".

I don't think %setup was superseded, but there is no reason not to use %autosetup here, so I'll replace it.

> Did you have a specific reason to exclude the libpbf.so from provides?
> I see that same exclusion in the core qt5-qtbase specfile. However, I'm not
> sure this should be done for the qt5 plugins. For example, when I look at
> the specfile for qt5-qtsvg plugin, it does not exclude the libqsvg.so
> library the plugin package provides. 

I believe plugins are supposed to be excluded from provides, and only libraries (with a SONAME) are supposed to be there.

> The qt5-qtsvg plugin package ties itself to the version of qt5-qtbase it was
> built against with:
> %{?_qt5:Requires: %{_qt5}%{?_isa} = %{_qt5_version}}
> 
> We should do the same for this package.

Good point, I'll fix that.

> If you plan to build against anything older than Fedora 28, then you need to
> add %ldconfig_scriptlets to %install. 

No, I don't.

Thanks, I'll make the changes ASAP.

I just found this, which explains the need to exclude libpbf.so:
https://fedoraproject.org/wiki/Packaging:AutoProvidesAndRequiresFiltering#Examples

The logic is that, because the .so file is in folder not searched by the system for library files, it should be excluded. I always learn something new during package reviews.

Updated package:

Spec URL: https://copr-be.cloud.fedoraproject.org/results/nforro/qt5-qtpbfimageformat/fedora-28-x86_64/00842883-qt5-qtpbfimageformat/qt5-qtpbfimageformat.spec
SRPM URL: https://copr-be.cloud.fedoraproject.org/results/nforro/qt5-qtpbfimageformat/fedora-28-x86_64/00842883-qt5-qtpbfimageformat/qt5-qtpbfimageformat-1.2-2.fc28.src.rpm

Looks good. Package Approved.

Thanks!

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/qt5-qtpbfimageformat

qt5-qtpbfimageformat-1.2-2.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2019-ba322679c2

qt5-qtpbfimageformat-1.2-2.fc29 has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2019-95a44330f1

qt5-qtpbfimageformat-1.2-2.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-ba322679c2

qt5-qtpbfimageformat-1.2-2.fc29 has been pushed to the Fedora 29 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-95a44330f1

qt5-qtpbfimageformat-1.2-2.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report.

qt5-qtpbfimageformat-1.2-2.fc29 has been pushed to the Fedora 29 stable repository. If problems still persist, please make note of it in this bug report.