It's always depended on python2; this isn't a new dependency. It was only changed to be explicit in the specfile because the RPM build for 8.00 was giving me warnings (or errors; I forget which).

This is only for building the HTML documentation. It's probably simple for someone with a bit more clue; I'd be very grateful for any assistance.

The offending code is http://git.infradead.org/users/dwmw2/openconnect.git/blob/HEAD:/www/html.py

Using python2 at build-time is fine for now. The docs generator doesn't look hard to port, we'll look at it as time permits. (Please keep the bug open, or file a new one, to track this.)


But the main issue is a runtime dependency.

There is a new script with the /usr/bin/python2 shebang: /usr/libexec/openconnect/tncc-wrapper.py
This makes rpmbuild automatically add python2 as a runtime dependency -- without it the script wouldn't be very useful.
If it's not meant to be executed, please either remove the file or clear its executable bit.


Actually, what's the purpose of the file? It looks like it downloads and runs some binary blob (with Java, which is not listed in dependencies either).

Ah, right. This is the "host checker" functionality: http://www.infradead.org/openconnect/tncc.html

Some VPN servers want the client to download a 'trojan' which performs some kind of security/configuration checking and uploads the results to the server, before allowing them to connect to the VPN.

The Juniper TNCC one is complex enough that I think the best option is to just drop it from the package. People are going to have to jump through hoops to make it work anyway, and they can download it for themselves.

That sounds quite scary, and not what I would expect in Fedora. The Packaging guidelines say: 

> Software which downloads code bundles from the internet in order to be functional or useful is not acceptable for inclusion in Fedora (regardless of whether the downloaded code would be acceptable to be packaged in Fedora as a proper dependency).

– https://docs.fedoraproject.org/en-US/packaging-guidelines/what-can-be-packaged/#_packages_which_are_not_useful_without_external_code


How intrusive would it be to remove them all?

openconnect-8.02-1.fc29 has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2019-41d9f2edc1

openconnect-8.02-2.fc29 has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2019-1294cc28b4

openconnect-8.02-2.fc29 has been pushed to the Fedora 29 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-1294cc28b4

openconnect-8.02-2.fc29 has been pushed to the Fedora 29 stable repository. If problems still persist, please make note of it in this bug report.