Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 166474 - Review request: perl-Class-ReturnValue - Class::ReturnValue Perl module
Summary: Review request: perl-Class-ReturnValue - Class::ReturnValue Perl module
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Paul Howarth
QA Contact: David Lawrence
URL: http://search.cpan.org/dist/Class-Ret...
Whiteboard:
Depends On: 165572
Blocks: FE-ACCEPT
TreeView+ depends on / blocked
 
Reported: 2005-08-22 08:33 UTC by Ralf Corsepius
Modified: 2007-11-30 22:11 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2005-08-31 16:07:25 UTC
Type: ---
Embargoed:

Attachments (Terms of Use)

Description Ralf Corsepius 2005-08-22 08:33:38 UTC 
Spec Name or Url:
ftp://packman.iu-bremen.de/fedora/SRPMS/perl-Class-ReturnValue.spec

SRPM Name or Url:
ftp://packman.iu-bremen.de/fedora/SRPMS/perl-Class-ReturnValue-0.53-1.src.rpm

Description:
A return-value object that lets you treat it as as a boolean, array or object.
Comment 1 Ralf Corsepius 2005-08-22 08:45:56 UTC 
This is a dependency of rt3
Comment 2 Paul Howarth 2005-08-25 11:33:40 UTC 
Review:

- rpmlint clean
- package and spec naming OK
- package meets guidelines
- license is same as perl, matches spec
- spec file written in English and is legible
- sources match upstream
- package builds OK on FC4 and in mock for rawhide (i386)
- BR's OK
- no locales, libraries, subpackages, pkgconfigs etc. to worry about
- not relocatable
- no directory ownership or permissions issues
- no duplicate files
- %clean section present and correct
- macro usage is consistent
- code, not content
- no large docs
- docs don't affect runtime
- no scriptlets

Nitpick:

- suggest adding Changes as %doc
- use %{?_smp_mflags} in make


APPROVED.
Note You need to log in before you can comment on or make changes to this bug.