Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 166698 - Review Request: perl-Time-Piece - Time objects from localtime and gmtime
Summary: Review Request: perl-Time-Piece - Time objects from localtime and gmtime
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Paul Howarth
QA Contact: David Lawrence
URL: http://www.chrisgrau.com/packages/per...
Whiteboard:
Depends On:
Blocks: FE-ACCEPT 166700
TreeView+ depends on / blocked
 
Reported: 2005-08-24 18:35 UTC by Chris Grau
Modified: 2007-11-30 22:11 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2005-08-25 16:34:45 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)
Patch addressing review nitpicks (1.40 KB, patch)
2005-08-24 20:07 UTC, Paul Howarth
no flags Details | Diff

Description Chris Grau 2005-08-24 18:35:25 UTC
Spec Name or Url: http://www.chrisgrau.com/packages/perl/perl-Time-Piece.spec
SRPM Name or Url: http://www.chrisgrau.com/packages/perl/perl-Time-Piece-1.08-1.src.rpm
Description:
The Time::Piece module replaces the standard localtime and gmtime functions
with implementations that return objects.  It does so in a backwards
compatible manner, so that using localtime or gmtime as documented in
perlfunc still behave as expected.

Comment 1 Paul Howarth 2005-08-24 20:05:46 UTC
Review:

- rpmlint clean
- package and spec naming OK
- package meets guidelines
- license is same as perl, correct in spec
- spec file written in English and legible
- sources match upstream
- package build ok in mock on FC4 (i386)
- no locales, libraries, subpackages, pkgconfigs etc. to worry about
- not relocatable
- no directory ownership or permissions issues
- no duplicate files
- %clean section present and correct
- macro usage is consistent
- code not content
- no large docs
- docs don't affect runtime
- no scriptlets

Nitpick:

- BR: perl is redundant
- I believe the CFLAGS setting in:
  CFLAGS="$RPM_OPT_FLAGS" %{__perl} Makefile.PL INSTALLDIRS=vendor
OPTIMIZE="$RPM_OPT_FLAGS"
  is redundant and you could use:
  %{__perl} Makefile.PL INSTALLDIRS=vendor OPTIMIZE="$RPM_OPT_FLAGS"
  instead.
- license text not included; suggest adding to %setup:
  perldoc -t perlgpl > COPYING
  perldoc -t perlartistic > Artistic
  and to %files:
  %doc COPYING Artistic



Comment 2 Paul Howarth 2005-08-24 20:07:41 UTC
Created attachment 118090 [details]
Patch addressing review nitpicks

Comment 3 Chris Grau 2005-08-24 20:58:34 UTC
(In reply to comment #1)
> - I believe the CFLAGS setting in:
>   CFLAGS="$RPM_OPT_FLAGS" %{__perl} Makefile.PL INSTALLDIRS=vendor
> OPTIMIZE="$RPM_OPT_FLAGS"
>   is redundant and you could use:
>   %{__perl} Makefile.PL INSTALLDIRS=vendor OPTIMIZE="$RPM_OPT_FLAGS"
>   instead.

Now that I take a closer look, that does seem awfully redundant.  Maybe the
spectemplate-perl.spec should be updated.  I had just copied that and moved the
OPTIMIZE argument based on the ExtUtils::MakeMaker documentation.

Nitpicks applied:
http://www.chrisgrau.com/packages/perl/perl-Time-Piece.spec
http://www.chrisgrau.com/packages/perl/perl-Time-Piece-1.08-2.src.rpm

I didn't use your patch, Paul (made the updates before I noticed it), but I
appreciate the effort.


Comment 4 Paul Howarth 2005-08-24 21:03:09 UTC
Approved.


Comment 5 Ville Skyttä 2005-08-25 05:53:23 UTC
Re: redundant: probably; it's there mainly for hysterical raisins, was  
needed some time, and has not been pruned yet.  The Perl spec template was 
initially designed so that it works with RH 7.3 (with an additional package 
providing perl(:MODULE_COMPAT_*) for it) and later.  I don't remember the 
exact details now though.  
  
Future versions of it will most likely have: 
  
    %{__perl} Makefile.PL INSTALLDIRS=vendor OPTIMIZE="$RPM_OPT_FLAGS" 
    make %{?_smp_mflags} 
 
...but what's still needed is to check whether Module::Build pass-through 
Makefile.PL's work with OPTIMIZE passed to them as well as if they need CFLAGS 
or not, and checking out the latest ExtUtils::MakeMaker from CPAN to see if it 
has changed anything. 


Note You need to log in before you can comment on or make changes to this bug.