Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1668504 - index.html in browse is broken
Summary: index.html in browse is broken
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: webkit2gtk3
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Eike Rathke
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2019-01-22 22:14 UTC by satellitgo
Modified: 2019-04-25 19:33 UTC (History)
15 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2019-04-25 19:33:38 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
browse display of index.hml (deleted)
2019-01-22 22:14 UTC, satellitgo
no flags Details
firefox display of index.html (deleted)
2019-02-13 18:39 UTC, satellitgo
no flags Details
webactivity.log-1 (deleted)
2019-02-13 19:38 UTC, satellitgo
no flags Details
webactivity-1.log (deleted)
2019-02-13 23:54 UTC, satellitgo
no flags Details
WebActivity-2.log (deleted)
2019-02-16 17:15 UTC, satellitgo
no flags Details

Description satellitgo 2019-01-22 22:14:53 UTC
Created attachment 1522523 [details]
browse display of index.hml

Description of problem:
index.hml in browse is broken
 does not display properly  (see screenshot)

Version-Release number of selected component (if applicable):
Fedora-SoaS-Live-x86_64-Rawhide-20190121.n.0.iso

How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 James Cameron 2019-01-22 22:46:21 UTC
this was working before.

the content of the file is displayed wrongly, so the file is present.  was anything in browse logs?

sugar-browse package hasn't changed for months.

webkit2gtk3 package changed to 2.23.3 eight days ago.

so a regression introduced by webkit2gtk3, so please change component.

Comment 2 satellitgo 2019-01-22 23:08:21 UTC
If I call firefox from sugar-terminal index.html works
from sugar-browse it does not start correctly

james cameron (Quozl_)suggested this may be due to webkit2gtk3 as component

cannot change this to this component from sugar-browse ...in Bugzilla

Comment 3 satellitgo 2019-01-22 23:29:04 UTC
changed component to webkit2gtk3

Comment 4 James Cameron 2019-01-22 23:57:41 UTC
i understand it does start correctly, but webkit2gtk3 is not properly rendering the static html in the view.

was anything reported by webkit2gtk3 or gtk3 in browse logs?  you can find stderr in .sugar/default/logs/org.laptop.WebActivity-*.log

Comment 5 satellitgo 2019-01-24 11:04:13 UTC
Log files
org.laptop.log-1.log:

/usr/share/activities/log.activity/logviewer.py:30:

PyGIWarning: GDK was imported without specifying version first.
Use gi.require_version('Gdk' . '3.0') before import to ensure that
the right version gets loaded.
 from gi.repository import Gdk

Comment 6 James Cameron 2019-01-25 00:16:09 UTC
Heh.  No, not the log file of the log viewing activity, the log file of the Browse activity.  Thanks.

Comment 7 satellitgo 2019-01-26 00:32:33 UTC
Fedora-Workstation-Live-x86_64-Rawhide-20190125.n.0.iso   with dnf groupinstall sugar-desktop; Browse ...index.html still does not display properly

Comment 8 satellitgo 2019-01-26 00:54:33 UTC
https://wiki.sugarlabs.org/go/File:Sugar-err_20190125.png

from logfile

Comment 9 James Cameron 2019-01-26 01:57:11 UTC
Again, that's the wrong log file.  I don't want the log file of the log viewing activity, I want the log file of the Browse activity.  And please don't use a screenshot, just copy and paste it here.  Thanks.

Comment 10 satellitgo 2019-01-28 00:18:28 UTC
Just installed Fedora-SoaS-Live-x86_64-Rawhide-20190127.n.0.iso  with liveinst -T (text); installer fails to start graphically

login to user and password set in text based install
su dnf install sddm
 password
sudo systemctl set-default graphical.target
reboot
login to soas:
 start Browse 202 which has a defective index.html 
 (see above)
 start 2nd tab in Browse and go to http://activities.sugarlabs.org
Index on top line lists Home wiki activites Donate  (which work)
download Browse 157.3.xo
Browse 157.3.xo started from journal works as https://sugarlabs.org
Home icon reverts to broken index.html web page.  This needs to be fixed!

Comment 11 James Cameron 2019-01-28 00:32:44 UTC
Thanks.  But some of that should be in 1668105.  Please don't give information about other tickets in this ticket.

You said the index.html is defective.  It isn't defective; you proved that by viewing it in Firefox.  The problem is that it is not displayed correctly by WebKit.

Again, you haven't given us the log file of Browse.  Please do so.

Comment 12 satellitgo 2019-02-13 18:39:03 UTC
Created attachment 1534524 [details]
firefox display of index.html

Comment 13 satellitgo 2019-02-13 19:38:14 UTC
Created attachment 1534544 [details]
webactivity.log-1

requested log file

Comment 14 James Cameron 2019-02-13 21:03:24 UTC
Thanks for the photograph of laptop with text editor, but this is only part of the log file.  I want to see the whole log file, as a text file attachment.  Sorry if that wasn't obvious.

I'd do this myself, but I'm in the Australian outback and don't have enough download quota for Fedora rawhide images.  I was hoping you or someone else would be able to do this instead.

Another question; does it work in Epiphany browser?

Comment 15 satellitgo 2019-02-13 23:54:06 UTC
Created attachment 1534605 [details]
webactivity-1.log

Comment 16 satellitgo 2019-02-16 17:15:08 UTC
Created attachment 1535531 [details]
WebActivity-2.log

from sugar-runner 2/16/2019

Comment 17 James Cameron 2019-02-18 01:09:36 UTC
Summary: WebKit does not render local file because of <!DOCTYPE

Thanks.  Only the first of your two logs was needed, but both logs confirm there were no errors to explain the failure to render.

Was able to get Fedora-SoaS-Live-x86_64-Rawhide-20190213.n.0.iso for testing.

The symptom you describe does occur for me on sugar-browse-202-2.fc30, but only via local file:/// method.  It also occurs with epiphany-3.31.90-1.fc30, but again only via local file:/// method.  Loading the index.html file via HTTP does not show the symptom.  

Both rely on webkit2gtk3-2.23.3-3.fc30, so my guess is the change is there.  I don't know how to easily test an older version.

No explanation in web inspector.

Workaround is to change first line of index.html from

<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">

to

<!DOCTYPE html>

But to be honest, it seems unwise to change this without knowing why it needs to be changed.  Is the older form now unsupported?

Comment 18 Eike Rathke 2019-02-18 09:47:33 UTC
I'm preparing webkit2gtk3-2.23.90, let's see if that'll fix this.

Comment 19 Michael Catanzaro 2019-02-18 16:58:23 UTC
(In reply to James Cameron from comment #17)
> The symptom you describe does occur for me on sugar-browse-202-2.fc30, but
> only via local file:/// method.  It also occurs with
> epiphany-3.31.90-1.fc30, but again only via local file:/// method.  Loading
> the index.html file via HTTP does not show the symptom.  

My guess is that content type sniffing takes precedence for loads via HTML but the filename takes precedence for local loads. That's weird and arguably a WebKit bug (especially since we don't know why the behavior changed).

Note shared-mime-info only allows the .html file extension for XHTML files since version 1.11/1.12, released five weeks ago. What version of shared-mime-info do you have? Does downgrading make a difference? See:

https://cgit.freedesktop.org/xdg/shared-mime-info/commit/?id=8ae13a589577e9bda12fb16465a03cd81b1cd349

Comment 20 James Cameron 2019-02-19 00:42:56 UTC
Eike, thanks.  Will test, but ...

Michael, shared-mime-info is 1.12-2.fc30, does now link *.html to MIME type of application/xml, and reverting 8ae13a589577e9bda12fb16465a03cd81b1cd349 and running update-mime-database does fix the problem.

So cause would appear to be in package shared-mime-info; with two MIME types using glob pattern of *.html, I'm not sure which one will match first.  But I'm fairly ignorant of how it works.

(By the way, the local file does have an extension of .html, not .hml; the bug reporter made a typo in title.)

Comment 21 James Cameron 2019-02-19 08:16:19 UTC
https://github.com/sugarlabs/browse-activity/commit/3d1e75b62feadf8fddff0baccf43dec9eb402884 will fix this for Browse, without fixing the underlying problem.  Other Sugar activities that use local load HTML will continue to be affected; such as Help activity.  But Help was orphaned and retired in Fedora, so no worries.

Comment 22 Eike Rathke 2019-02-19 10:27:58 UTC
Reading the above it probably won't change anything, but there's now webkit2gtk3-2.23.90-1.fc30 see https://koji.fedoraproject.org/koji/buildinfo?buildID=1212065

So this is a failure of shared-mime-info then?

Comment 23 Michael Catanzaro 2019-02-19 17:36:10 UTC
(In reply to Eike Rathke from comment #22)
> So this is a failure of shared-mime-info then?

Well I don't think so, it's just the change that surfaced the issue. Nobody here understands what's actually wrong.

Comment 25 Eike Rathke 2019-02-25 18:11:33 UTC
(In reply to satellitgo from comment #24)
> possible fix?

That's the same workaround as in coment 21.

Comment 26 satellitgo 2019-03-23 13:46:27 UTC
fixed in:
 Fedora-SoaS-Live-x86_64-Rawhide-20190323.n.0.iso

thanks

Comment 27 James Cameron 2019-03-24 21:20:09 UTC
Good that it works, but I wouldn't call it fixed until we know what change was made to fix it, and the problem did also affect epiphany and correctly formatted old-style HTML documents.

Comment 28 satellitgo 2019-04-22 23:32:01 UTC
fixed in sugar.013 with patch:
see:
 https://bodhi.fedoraproject.org/updates/FEDORA-2019-98a501f843

Comment 29 Fedora Update System 2019-04-23 07:44:05 UTC
sugar-0.113-2.fc30 sugar-artwork-0.113-1.fc30 sugar-browse-203-1.fc30 sugar-chat-85-1.fc30 sugar-clock-21-1.fc30 sugar-datastore-0.113-1.fc30 sugar-getiabooks-18.2-1.fc30 sugar-log-40-1.fc30 sugar-read-122-1.fc30 sugar-terminal-46-1.fc30 sugar-toolkit-gtk3-0.113-2.fc30 sugar-turtleart-218-2.fc30 sugar-write-100-1.fc30 xapian-bindings-1.4.10-1.fc30 has been submitted as an update to Fedora 30. https://bodhi.fedoraproject.org/updates/FEDORA-2019-98a501f843

Comment 30 Fedora Update System 2019-04-23 14:55:35 UTC
sugar-0.113-2.fc30, sugar-artwork-0.113-1.fc30, sugar-browse-203-1.fc30, sugar-chat-85-1.fc30, sugar-clock-21-1.fc30, sugar-datastore-0.113-1.fc30, sugar-getiabooks-18.2-1.fc30, sugar-log-40-1.fc30, sugar-read-122-1.fc30, sugar-terminal-46-1.fc30, sugar-toolkit-gtk3-0.113-2.fc30, sugar-turtleart-218-2.fc30, sugar-write-100-1.fc30, xapian-bindings-1.4.10-1.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-98a501f843

Comment 31 Fedora Update System 2019-04-25 19:33:38 UTC
sugar-0.113-2.fc30, sugar-artwork-0.113-1.fc30, sugar-browse-203-1.fc30, sugar-chat-85-1.fc30, sugar-clock-21-1.fc30, sugar-datastore-0.113-1.fc30, sugar-getiabooks-18.2-1.fc30, sugar-log-40-1.fc30, sugar-read-122-1.fc30, sugar-terminal-46-1.fc30, sugar-toolkit-gtk3-0.113-2.fc30, sugar-turtleart-218-2.fc30, sugar-write-100-1.fc30, xapian-bindings-1.4.10-1.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.