Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1670387 - update-crypto-policies reports success when called with invalid arguments
Summary: update-crypto-policies reports success when called with invalid arguments
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: crypto-policies
Version: 29
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Red Hat Crypto Team
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2019-01-29 13:21 UTC by Christian Heimes
Modified: 2019-10-29 10:58 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2019-10-29 10:58:11 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Christian Heimes 2019-01-29 13:21:03 UTC
Description of problem:
update-crypto-policies does not return an error code when it is called with invalid arguments. Invalid arguments should result in error code != 0.

Version-Release number of selected component (if applicable):
crypto-policies-20181026-1.gitd42aaa6.fc29.noarch


How reproducible:
always

Steps to Reproduce:
1. update-crypto-policies DEFAULT
2. echo $? 

Actual results:
output: 
usage: /usr/bin/update-crypto-policies --set [POLICY]
usage: /usr/bin/update-crypto-policies --show
usage: /usr/bin/update-crypto-policies --no-check
usage: /usr/bin/update-crypto-policies --is-applied
usage: /usr/bin/update-crypto-policies

exit code is 0

Expected results:
exit code is > 0

Additional info:

Comment 1 Tomas Mraz 2019-02-01 11:37:40 UTC
Fixed in upstream repository. Now it will return exit code 2.

Comment 2 Fedora Update System 2019-02-11 09:38:20 UTC
crypto-policies-20180211-1.gite3eacfc.fc29 has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2019-436ecd5423

Comment 3 Fedora Update System 2019-02-12 02:50:06 UTC
crypto-policies-20190211-2.gite3eacfc.fc29 has been pushed to the Fedora 29 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-436ecd5423

Comment 4 Fedora Update System 2019-02-13 02:47:19 UTC
crypto-policies-20190211-2.gite3eacfc.fc29 has been pushed to the Fedora 29 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.