Needs work.

Missing many BuildRequires: libtool, automake, autoconf, texinfo, pam-devel

Release is for the build of the rpm, not the upstream release version. So
Version is 1.2rc6 and Release is 1 (first build). And I don't see the point of
defining a macro for %{name}-%{release}


socket++ is not strictly a part of newscache. I recommend it be packaged seperately.

With the dependencies installed (see BuildRequires comments) it does build on
FC4. rpmlint shows

E: newscache executable-marked-as-config-file /etc/rc.d/init.d/newscache
E: newscache executable-marked-as-config-file /etc/cron.daily/newscache
E: newscache non-standard-dir-perm /var/cache/newscache 02755

%{_initdir} does not really contain config files and as such those scripts
shouldn't be marked %config.

> Summary: Free cache server for USENET News
Can there be any non-free cache server in Fedora?

> Missing many BuildRequires: libtool, automake, autoconf, texinfo, pam-devel
libtool already implies automake/autoconf, other will be added.

> Release is for the build of the rpm, not the upstream release version. So
> Version is 1.2rc6 and Release is 1 (first build).
See
http://fedoraproject.org/wiki/PackageNamingGuidelines#head-63c1c3d339e145e51777b81c9f9adc8120aa762f
"rc" should go to release field. And rpmlint requires such a way too...

> And I don't see the point of defining a macro for %{name}-%{release}
Hmmm... Where you have found it?.. :)
I guess it is about %{srcnamever}? "NewsCache" is a historical name. Now most of
things in the package are low-registered, but the tarball is still such...

> socket++ is not strictly a part of newscache. I recommend it be packaged
seperately.
I've already mention it in the spec file comments:
 # socket++ is a library from the same site as NewScache is.
 # While it is used by newscache only, there is no reason
 # to ship it separately.
I would like to not mess up FE by superfluous packages. Currently socket++ is
used by newscache only, distributed from the same site as newscache, and I
believe (with full respect for socket++ developers) that it hardly will be used
somewhere else in the near future.

Certainly if it will be needed, I'll exclude this library as a separate package.

> E: newscache executable-marked-as-config-file /etc/cron.daily/newscache
I just follow Fedora Core here: see for example "yum.spec" or "tmpwatch.spec".
Both "chmod +x" and then marked as "%config(noreplace)" ...
> E: newscache executable-marked-as-config-file /etc/rc.d/init.d/newscache
Similar (see "httpd.spec" for example)
It means that rpmlint and FC ways are differ. I would prefer FC now :)

> > Summary: Free cache server for USENET News
> Can there be any non-free cache server in Fedora?
Yep! In the additional repositories, or from the owner's sites (as java, flash) etc.
This summary has come from upstream. 

OK, upstream can't make up their mind, so we're going lowercase, with the macro
defining the source name.

Sorry, you're right, I forget the rules with alphabetic release versions.

If socket++ isn't used by anything else, then go ahead and put it in newscache.

OK, follow the example of Core when it comes to cron then.

Still needs a BuildReqires: texinfo pam-devel

Good:
- source matches upstream
- license (GPL) in %doc
- compiles on FC4 i386
- no locales
- not relocatable
- %clean OK
- define good BuildRoot
- use of macros

> Still needs a BuildReqires: texinfo pam-devel
done.

New SPEC: http://dmitry.butskoy.name/newscache/newscache.spec
New SRPM: http://dmitry.butskoy.name/newscache/newscache-1.2-0.2.rc6.src.rpm

Looks good. APPROVED