https://koji.fedoraproject.org/koji/taskinfo?taskID=33445301

(most OK but i686 and armv7hl builds failing tests with ENOMEM - needs some further investigation)

 - License ok
 - Latest version packaged
 - Conforms to Packaging Guidelines

 - %global commitdate	20170316

should be snapshotdate i.e. the day you made the snapshot not the day of the commit. 
Also it is automated by the macros, it is set to the date you upload the archive to dist-git.

 - the release field for a pre-release dev snapshot is not okay, it should start at 0.1:

Release:        0.1%{?dist}

 - use a better description:

%global common_description %{expand:
A package to calculate LCS of slices.}

[…]

%description
%{common_description}


%package devel
Summary:       %{summary}
BuildArch:     noarch

%description devel
%{common_description}

(In reply to Nathan Scott from comment #1)
> https://koji.fedoraproject.org/koji/taskinfo?taskID=33445301
> 
> (most OK but i686 and armv7hl builds failing tests with ENOMEM - needs some
> further investigation)

Please fill a bug with upstream for failure on 32bits arches. Or patch the tests so it doesn't try to allocate 100,000×100,000 int.

 - Don't mix tabs and spaces:

golang-github-yudai-golcs.src:5: W: mixed-use-of-spaces-and-tabs (spaces: line 5, tab: line 2)

The changelog should also reflect the release tag:

* Wed Mar 13 2019 Nathan Scott <nathans> - 0-0.1.20190313gitecda9a5

You don't need this either:

%global shortcommit	%(c=%{commit}; echo ${c:0:7})

(In reply to Robert-André Mauchin from comment #2)
> [...]
> should be snapshotdate i.e. the day you made the snapshot not the day of the
> commit. 
> Also it is automated by the macros, it is set to the date you upload the
> archive to dist-git.

Ah excellent - thanks for these and all the other clues.  I've fixed 'em
up, and will upload new spec/srpm files shortly.

> > (most OK but i686 and armv7hl builds failing tests with ENOMEM - needs some
> > further investigation)
> 
> Please fill a bug with upstream for failure on 32bits arches. Or patch the
> tests so it doesn't try to allocate 100,000×100,000 int.

I've opened https://github.com/yudai/golcs/issues/3

I also attempted some different settings in the test code, but have found
reducing the allocation sizes to also be problematic.  The array must be
of certain size that it takes >1sec to process for the test to function.

Reducing sizes results in some passes, but the test fails intermittently.
I'll patch just this one timing-sensitive test out of the build for now,
leaving other tests in place, and see if upstream can fix the issue for
the next release.

cheers.

Updated versions ...

Spec URL: https://nathans.fedorapeople.org/golcs/golang-github-yudai-golcs.spec
SRPM URL: https://nathans.fedorapeople.org/golcs/golang-github-yudai-golcs-0-0.1.20190313gitecda9a5.fc29.src.rpm
Koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=33469210

cheers.

LGTM, package approved.

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-yudai-golcs

golang-github-yudai-golcs-0-0.1.20190315gitecda9a5.fc29 has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2019-44c27f48cd

golang-github-yudai-golcs-0-0.1.20190315gitecda9a5.fc30 has been submitted as an update to Fedora 30. https://bodhi.fedoraproject.org/updates/FEDORA-2019-41c3abf325

golang-github-yudai-golcs-0-0.1.20190315gitecda9a5.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-41c3abf325

golang-github-yudai-golcs-0-0.1.20190315gitecda9a5.fc29 has been pushed to the Fedora 29 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-44c27f48cd

golang-github-yudai-golcs-0-0.1.20190315gitecda9a5.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report.

golang-github-yudai-golcs-0-0.1.20190315gitecda9a5.fc29 has been pushed to the Fedora 29 stable repository. If problems still persist, please make note of it in this bug report.