Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1689001 - Review Request: golang-github-opentracing - OpenTracing API for Go
Summary: Review Request: golang-github-opentracing - OpenTracing API for Go
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Nathan Scott
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1670656
TreeView+ depends on / blocked
 
Reported: 2019-03-14 21:12 UTC by Robert-André Mauchin 🐧
Modified: 2019-04-09 11:08 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2019-03-25 14:07:07 UTC
Type: ---
Embargoed:
nathans: fedora-review+


Attachments (Terms of Use)

Description Robert-André Mauchin 🐧 2019-03-14 21:12:28 UTC
Spec URL: https://eclipseo.fedorapeople.org/for-review/golang-github-opentracing.spec
SRPM URL: https://eclipseo.fedorapeople.org/for-review/golang-github-opentracing-1.0.2-1.20190314git25a84ff.fc31.src.rpm

Description:
 This package is a Go platform API for OpenTracing.

Fedora Account System Username: eclipseo

Comment 1 Robert-André Mauchin 🐧 2019-03-14 21:18:02 UTC
Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=33495257

Comment 2 Robert-André Mauchin 🐧 2019-03-15 06:07:09 UTC
*** Bug 1689080 has been marked as a duplicate of this bug. ***

Comment 3 Nathan Scott 2019-03-17 20:37:12 UTC
[ LGTM, package approved. ]


Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "*No copyright* Apache License (v2.0)", "Unknown or generated".
     28 files have unknown license. Detailed output of licensecheck in
     /source/git/golang/1689001-golang-github-opentracing/licensecheck.txt
[x]: Package must own all directories that it creates.
     Note: Directories without known owners: /usr/share/gocode/src,
     /usr/share/gocode
[x]: Package does not own files or directories owned by other packages.
     Note: Dirs in package are owned also by:
     /usr/share/gocode/src/github.com(golang-github-smartystreets-
     assertions-devel, golang-github-davecgh-go-spew-devel, golang-github-
     opentracing-devel, golang-github-rainycape-unidecode-devel, golang-
     github-unknwon-com-devel, golang-github-mattn-go-isatty-devel, golang-
     github-smartystreets-goconvey-devel, golang, golang-github-jtolds-gls-
     devel, golang-github-mattn-go-colorable-devel, golang-github-teris-io-
     shortid-devel, golang-github-stretchr-testify-devel, golang-github-
     stack-devel, golang-github-pmezard-go-difflib-devel)
[-]: %build honors applicable compiler flags or justifies otherwise.
[-]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[-]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 10240 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: golang-github-opentracing-devel-1.0.2-1.20190314git25a84ff.fc29.noarch.rpm
          golang-github-opentracing-1.0.2-1.20190314git25a84ff.fc29.src.rpm
golang-github-opentracing-devel.noarch: W: hidden-file-or-dir /usr/share/gocode/src/github.com/opentracing/opentracing-go/.goipath
golang-github-opentracing.src: W: no-%build-section
2 packages and 0 specfiles checked; 0 errors, 2 warnings.




Rpmlint (installed packages)
----------------------------
sh: /usr/bin/python: No such file or directory
golang-github-opentracing-devel.noarch: W: invalid-url URL: https://github.com/opentracing/opentracing-go <urlopen error [Errno -2] Name or service not known>
golang-github-opentracing-devel.noarch: W: hidden-file-or-dir /usr/share/gocode/src/github.com/opentracing/opentracing-go/.goipath
1 packages and 0 specfiles checked; 0 errors, 2 warnings.



Requires
--------
golang-github-opentracing-devel (rpmlib, GLIBC filtered):
    golang(github.com/stretchr/testify/assert)
    golang(github.com/stretchr/testify/suite)



Provides
--------
golang-github-opentracing-devel:
    golang(github.com/opentracing/opentracing-go)
    golang(github.com/opentracing/opentracing-go)(commit=25a84ff92183e2f8ac018ba1db54f8a07b3c0e04)
    golang(github.com/opentracing/opentracing-go/ext)
    golang(github.com/opentracing/opentracing-go/ext)(commit=25a84ff92183e2f8ac018ba1db54f8a07b3c0e04)
    golang(github.com/opentracing/opentracing-go/harness)
    golang(github.com/opentracing/opentracing-go/harness)(commit=25a84ff92183e2f8ac018ba1db54f8a07b3c0e04)
    golang(github.com/opentracing/opentracing-go/log)
    golang(github.com/opentracing/opentracing-go/log)(commit=25a84ff92183e2f8ac018ba1db54f8a07b3c0e04)
    golang(github.com/opentracing/opentracing-go/mocktracer)
    golang(github.com/opentracing/opentracing-go/mocktracer)(commit=25a84ff92183e2f8ac018ba1db54f8a07b3c0e04)
    golang-github-opentracing-devel
    golang-ipath(github.com/opentracing/opentracing-go)
    golang-ipath(github.com/opentracing/opentracing-go)(commit=25a84ff92183e2f8ac018ba1db54f8a07b3c0e04)



Source checksums
----------------
https://github.com/opentracing/opentracing-go/archive/25a84ff92183e2f8ac018ba1db54f8a07b3c0e04/opentracing-go-25a84ff92183e2f8ac018ba1db54f8a07b3c0e04.tar.gz :
  CHECKSUM(SHA256) this package     : 80dc5e3c790034a43dbaf38370ea34fdb29e6b1e29367ec566dfc2866e027b23
  CHECKSUM(SHA256) upstream package : 80dc5e3c790034a43dbaf38370ea34fdb29e6b1e29367ec566dfc2866e027b23


Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02
Command line :/usr/bin/fedora-review -b 1689001
Buildroot used: fedora-29-x86_64
Active plugins: Generic, Shell-api
Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP
Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6

Comment 4 Nathan Scott 2019-03-25 00:38:51 UTC
Robert-André, could you do the create-repo-plus-branches-plus-builds-close-bz dance for this package please?

In addition to rawhide, Mark and I are aiming to do Grafana builds for f29 and f30 as well at this stage, so if you could do at least those branches that'd be awesome.  Thanks!

Comment 5 Gwyn Ciesla 2019-03-25 13:03:47 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-opentracing

Comment 6 Robert-André Mauchin 🐧 2019-03-25 14:07:07 UTC
(In reply to Nathan Scott from comment #4)
> Robert-André, could you do the
> create-repo-plus-branches-plus-builds-close-bz dance for this package please?
> 
> In addition to rawhide, Mark and I are aiming to do Grafana builds for f29
> and f30 as well at this stage, so if you could do at least those branches
> that'd be awesome.  Thanks!

It is built for F29/F30/Rawhide. Buildroot override are in place for 15 days.


Note You need to log in before you can comment on or make changes to this bug.