Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1689076 - Review Request: golang-github-gosimple-slug - URL-friendly slugify with multiple languages support
Summary: Review Request: golang-github-gosimple-slug - URL-friendly slugify with multi...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Robert-André Mauchin 🐧
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1670656
TreeView+ depends on / blocked
 
Reported: 2019-03-15 05:45 UTC by Nathan Scott
Modified: 2019-04-27 21:25 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2019-03-15 22:40:56 UTC
Type: ---
Embargoed:
zebob.m: fedora-review+

Attachments (Terms of Use)

Description Nathan Scott 2019-03-15 05:45:52 UTC 
Spec URL: https://nathans.fedorapeople.org/slug/golang-github-gosimple-slug.spec
SRPM URL: https://nathans.fedorapeople.org/slug/golang-github-gosimple-slug-1.4.2-1.fc29.src.rpm

Description: URL-friendly slugify with multiple languages support
Fedora Account System Username: nathans
Comment 1 Nathan Scott 2019-03-15 05:57:26 UTC 
Koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=33503834

(currently failing as golang-github-rainycape-unidecode is not yet available in the rawhide buildroot)
Comment 2 Robert-André Mauchin 🐧 2019-03-15 06:55:16 UTC 
 - You need to add the BR even if it's not pacaged yet

BuildRequires:  golang(github.com/rainycape/unidecode)


   And you need to provide a Review Request for that package otherwise it can't be reviewed.
Comment 3 Nathan Scott 2019-03-15 07:12:35 UTC 
| BuildRequires:  golang(github.com/rainycape/unidecode)

Aha, that's all I was missing - thanks.

| And you need to provide a Review Request for that package

You reviewed it earlier this week.  ;-)

Updated SPEC and SRPM (same location as above), Koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=33504705
Comment 4 Robert-André Mauchin 🐧 2019-03-15 07:44:47 UTC 
I did? The package name was ringing a bell.

Anyhow:

 - Fix the line encoding of the README.md in %prep

golang-github-gosimple-slug-devel.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/golang-github-gosimple-slug-devel/README.md

See https://fedoraproject.org/wiki/Packaging_tricks#Remove_DOS_line_endings

 - License ok
 - Latest version packaged
 - Builds in mock
 - No rpmlint errors
 - Conforms to Packaging Guidelines

Package approved. Please fix the line issue before import.
Comment 5 Gwyn Ciesla 2019-03-15 20:31:42 UTC 
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-gosimple-slug
Comment 6 Nathan Scott 2019-03-15 22:40:56 UTC 
Thanks again Robert-André; I've added the line endings fix and have pushed through first builds now.
Comment 7 Fedora Update System 2019-04-16 06:24:54 UTC 
golang-github-gosimple-slug-1.4.2-1.fc30 has been submitted as an update to Fedora 30. https://bodhi.fedoraproject.org/updates/FEDORA-2019-8e60a710a7
Comment 8 Fedora Update System 2019-04-17 01:02:34 UTC 
golang-github-gosimple-slug-1.4.2-1.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-8e60a710a7
Comment 9 Fedora Update System 2019-04-21 23:57:43 UTC 
golang-github-gosimple-slug-1.4.2-1.fc29 has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2019-d3e1194a61
Comment 10 Fedora Update System 2019-04-22 19:48:03 UTC 
golang-github-gosimple-slug-1.4.2-1.fc29 has been pushed to the Fedora 29 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-d3e1194a61
Comment 11 Fedora Update System 2019-04-27 21:25:21 UTC 
golang-github-gosimple-slug-1.4.2-1.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report.
Note You need to log in before you can comment on or make changes to this bug.