Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1691623 - Review Request: golang-github-benbjohnson-clock - Go library for mocking time
Summary: Review Request: golang-github-benbjohnson-clock - Go library for mocking time
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Robert-André Mauchin 🐧
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1670656
TreeView+ depends on / blocked
 
Reported: 2019-03-22 06:07 UTC by Nathan Scott
Modified: 2019-04-22 05:09 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2019-03-25 07:42:01 UTC
Type: ---
Embargoed:
zebob.m: fedora-review+

Attachments (Terms of Use)

Description Nathan Scott 2019-03-22 06:07:04 UTC 
Spec URL: https://nathans.fedorapeople.org/clock/golang-github-benbjohnson-clock.spec
SRPM URL: https://nathans.fedorapeople.org/clock/golang-github-benbjohnson-clock-0-0.1.20190322git7dc7640.fc29.src.rpm

Description: Go library for mocking time
Fedora Account System Username: nathans
Comment 1 Nathan Scott 2019-03-22 06:16:32 UTC 
Koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=33684335

Note: %check upstream tests are patched to fix problems ranging from compilation failure to raciness seen on s390x.
Test is not sent upstream due to github project being archived.
Comment 2 Robert-André Mauchin 🐧 2019-03-23 16:23:14 UTC 
 - Always document your patches: add a comment explaining why they are needed, or a link to an upstream bug report or merge request.

Patch0:         clock_test.patch


 - License ok
 - Latest version packaged
 - Builds in mock
 - No rpmlint errors
 - Conforms to Packaging Guidelines

Package approved.


Please fix the aforementioned issue before import. People reading your SPEC need to know why the patch is there. It's specially useful for Golang SIG maintainers.
Comment 3 Igor Raits 2019-03-25 06:40:29 UTC 
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-benbjohnson-clock
Comment 4 Fedora Update System 2019-04-10 03:59:39 UTC 
golang-github-benbjohnson-clock-0-0.1.20190325git7dc7640.fc30 has been submitted as an update to Fedora 30. https://bodhi.fedoraproject.org/updates/FEDORA-2019-8a7931b352
Comment 5 Fedora Update System 2019-04-10 04:00:09 UTC 
golang-github-benbjohnson-clock-0-0.1.20190325git7dc7640.fc29 has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2019-21f6f28c28
Comment 6 Fedora Update System 2019-04-12 02:46:44 UTC 
golang-github-benbjohnson-clock-0-0.1.20190325git7dc7640.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-8a7931b352
Comment 7 Fedora Update System 2019-04-12 03:55:34 UTC 
golang-github-benbjohnson-clock-0-0.1.20190325git7dc7640.fc29 has been pushed to the Fedora 29 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-21f6f28c28
Comment 8 Fedora Update System 2019-04-16 03:54:44 UTC 
golang-github-benbjohnson-clock-0-0.1.20190325git7dc7640.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report.
Comment 9 Fedora Update System 2019-04-22 05:09:19 UTC 
golang-github-benbjohnson-clock-0-0.1.20190325git7dc7640.fc29 has been pushed to the Fedora 29 stable repository. If problems still persist, please make note of it in this bug report.
Note You need to log in before you can comment on or make changes to this bug.