Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 169927 - Review Request: scim-fcitx - Chinese IMEngine for SCIM
Summary: Review Request: scim-fcitx - Chinese IMEngine for SCIM
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: John Mahowald
QA Contact: David Lawrence
URL: http://www.scim-im.org/projects/imeng...
Whiteboard:
Depends On:
Blocks: FE-ACCEPT
TreeView+ depends on / blocked
 
Reported: 2005-10-05 11:01 UTC by Jens Petersen
Modified: 2007-11-30 22:11 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2006-01-10 01:33:52 UTC
Type: ---
Embargoed:

Attachments (Terms of Use)

Description Jens Petersen 2005-10-05 11:01:55 UTC 
Spec Name or Url: http://people.redhat.com/petersen/extras/scim-fcitx.spec
SRPM Name or Url: http://people.redhat.com/petersen/extras/scim-fcitx-3.1.1-1.src.rpm
Description:
scim-fcitx is a port of the fcitx Chinese input method for the SCIM input
method platform.  It provides Wubi, Erbi, Cangjie, and Pinyin styles of input.
Comment 1 John Mahowald 2005-12-13 04:39:38 UTC 
* RPM name is OK
* Source scim-fcitx.3.1.1.tar.bz2 is the same as upstream
* Builds fine in mock
* rpmlint of scim-fcitx-tools looks OK
* File list of scim-fcitx-tools looks OK

Needs work:
* Missing SMP flags. If it doesn't build with it, please add a comment
  (wiki: PackagingGuidelines#parallelmake)
* rpmlint of scim-fcitx: Don't need empty file NEWS.
* File list of scim-fcitx: %{_datadir}/scim and %{_libdir}/scim are already
owned by scim package
* %defattr(-, root, root)  really should be %defattr(-, root, root,-)
Comment 2 Jens Petersen 2005-12-19 08:32:15 UTC 
Thank you for the careful review.

I uploaded a new package which should fix all the points you found:

  http://people.redhat.com/petersen/extras/scim-fcitx-3.1.1-1.1.src.rpm
  http://people.redhat.com/petersen/extras/scim-fcitx.spec
Comment 3 John Mahowald 2005-12-19 21:13:20 UTC 
The careful review is mostly thanks to the fedora-qa script.

rpmlint
- rpmlint of scim-fcitx: Missing changelog entry, minor
- rpmlint of scim-fcitx-tools: No docs, ignore.

- package meets naming guidelines
- package meets packaging guidelines
- license (GPL) OK, text in %doc
- spec file legible, in am. english
- source matches upstream
- package compiles on FC4 i386
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file 


Note that I have not tested using this.

APPROVED
Comment 4 Konstantin Ryabitsev 2005-12-19 21:40:17 UTC 
I've tested it -- works very nicely. Better interface than the default pinyin
input method provided by scim, at least in my opinion. Looking forward to seeing
it in Extras.
Comment 5 Jens Petersen 2005-12-20 11:35:53 UTC 
Package imported into cvs, devel build and cvs branches requested.
Comment 6 Christian Iseli 2006-01-09 13:21:37 UTC 
(In reply to comment #5)
> Package imported into cvs, devel build and cvs branches requested.

Could you please set the ticket to CLOSED / NEXTRELEASE ?

Thanks.
Comment 7 Jens Petersen 2006-01-10 01:33:52 UTC 
Done, thanks.
Note You need to log in before you can comment on or make changes to this bug.