Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 169973 - Review Request: python-clientform - ClientForm
Summary: Review Request: python-clientform - ClientForm
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: John Mahowald
QA Contact: Fedora Package Reviews List
URL: http://wwwsearch.sourceforge.net/Clie...
Whiteboard:
Depends On:
Blocks: FE-ACCEPT
TreeView+ depends on / blocked
 
Reported: 2005-10-06 00:04 UTC by Josh Boyer
Modified: 2007-11-30 22:11 UTC (History)
0 users

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2005-11-04 03:51:10 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Josh Boyer 2005-10-06 00:04:35 UTC
Spec Name or Url: http://jdub.homelinux.org/files/ClientForm/ClientForm.spec
SRPM Name or Url: http://jdub.homelinux.org/files/ClientForm/lientForm-0.1.17-1.src.rpm

Description: <description here>

ClientForm is a Python module for handling HTML forms on the client side,
useful for parsing HTML forms, filling them in and returning the completed
forms to the server.  It developed from a port of Gisle Aas' Perl module
HTML::Form, from the libwww-perl library, but the interface is not the same.

Comment 1 Ville Skyttä 2005-10-06 15:37:56 UTC
I'd personally name it "python-clientform" (all lowercase).  Please at least 
add the "python-" prefix. 

Comment 2 Ignacio Vazquez-Abrams 2005-10-06 16:11:14 UTC
The module name is ClientForm so the proper name would be python-ClientForm.

Comment 3 Ville Skyttä 2005-10-06 16:19:12 UTC
The majority of python-* in Extras seem to disagree with that (based on 
quickly peeking into the source tarball names only). 

Comment 4 Tom "spot" Callaway 2005-10-06 16:20:56 UTC
The prefix is a MUST. The lowercase is up to the packager.

Comment 6 John Mahowald 2005-10-30 06:58:07 UTC
Needs work:

- *.pyo needs to be %ghost ed

Summary doesn't seem to match the package:
Summary:        Powerful extensions to the standard datetime module
Is this the right Summary?

Minor:
- typo in Source1, net not not:
http://wwwsearch.sourceforge.not/ClientForm/src/ClientForm-0.1.17.tar.gz

Good:
- BSD license, text included
- spec legible
- source matches upstream
- builds on FC4
- follows python template
- owns all it's files
- rpmlint clean

Comment 7 Josh Boyer 2005-10-30 20:36:08 UTC
(In reply to comment #6)
> Needs work:
> 
> - *.pyo needs to be %ghost ed

Ok, I think I fixed this... (first time packaging python)

> 
> Summary doesn't seem to match the package:
> Summary:        Powerful extensions to the standard datetime module
> Is this the right Summary?

No.  Blatant copy/paste error.  Fixed.

> 
> Minor:
> - typo in Source1, net not not:
> http://wwwsearch.sourceforge.not/ClientForm/src/ClientForm-0.1.17.tar.gz

Fixed.

Updated spec files and srpm at:

http://jdub.homelinux.org/files/ClientForm/python-clientform.spec

and

http://jdub.homelinux.org/files/ClientForm/python-clientform-0.1.17-3.src.rpm


Comment 8 John Mahowald 2005-10-31 06:44:40 UTC
Looks good. APPROVED

Comment 9 Josh Boyer 2005-11-04 03:51:10 UTC
branched, tagged, and built.  thanks for the review!

Comment 10 Christian Iseli 2006-10-18 12:41:35 UTC
Normalize summary field for easy parsing


Note You need to log in before you can comment on or make changes to this bug.