Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1712012 - python-units FTBFS with pytest4
Summary: python-units FTBFS with pytest4
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: Fedora
Classification: Fedora
Component: python-units
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
high
Target Milestone: ---
Assignee: Igor Raits
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: F31FTBFS PYTEST4 PYTHON38 1732841
TreeView+ depends on / blocked
 
Reported: 2019-05-20 15:31 UTC by Patrik Kopkan
Modified: 2019-07-31 22:40 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2019-07-28 16:05:01 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
Copr build log (89.94 KB, text/plain)
2019-05-20 15:31 UTC, Patrik Kopkan
no flags Details

Description Patrik Kopkan 2019-05-20 15:31:00 UTC
Created attachment 1571323 [details]
Copr build log

python-units-0.07-8 fails at collection(generating) of tests. Metafunc.addcall is removed  https://docs.pytest.org/en/latest/deprecations.html#metafunc-addcall. Use instead metafunc.parametrize()


==================================== ERRORS ====================================
______________ ERROR collecting units/tests/test_inequalities.py _______________
tests/test_inequalities.py:160: in pytest_generate_tests
    metafunc.addcall(funcargs=dict(quant1=lesser, quant2=greater))
E   AttributeError: 'Metafunc' object has no attribute 'addcall'
!!!!!!!!!!!!!!!!!!! Interrupted: 1 errors during collection !!!!!!!!!!!!!!!!!!!!
=========================== 1 error in 0.38 seconds ============================
error: Bad exit status from /var/tmp/rpm-tmp.YPbMrt (%check)
    Bad exit status from /var/tmp/rpm-tmp.YPbMrt (%check)

Comment 1 Miro Hrončok 2019-07-10 11:43:17 UTC
This blocks the Python 3.8 rebuild. Igor, please respond.

Comment 2 Igor Raits 2019-07-28 14:38:59 UTC
I could not find way to report issue to upstream. https://bitbucket.org/adonohue/units/src/default/ seems to have issues disabled. Upstream seems to be dead pretty much.

I think I can disable tests. What do you think?

Comment 3 Miro Hrončok 2019-07-28 15:48:36 UTC
I think we should not ship dead software. Let's retire it?

Comment 4 Igor Raits 2019-07-28 16:05:01 UTC
Ack.

Retired.


Note You need to log in before you can comment on or make changes to this bug.