Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1724145 - python-crochet fails to build with Python 3.8
Summary: python-crochet fails to build with Python 3.8
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: python-crochet
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
high
Target Milestone: ---
Assignee: Jeremy Cline
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: F32FTBFS F32FailsToInstall PYTHON38
TreeView+ depends on / blocked
 
Reported: 2019-06-26 10:48 UTC by Miro Hrončok
Modified: 2019-09-17 08:17 UTC (History)
2 users (show)

Fixed In Version: python-crochet-1.10.0-3.fc32
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2019-09-17 08:17:27 UTC
Type: Bug
Embargoed:

Attachments (Terms of Use)

Description Miro Hrončok 2019-06-26 10:48:48 UTC 
python-crochet fails to build with Python 3.8.0b1.

The error is:

======================================================================
FAIL: test_new_logging (crochet.tests.test_setup.LoggingTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/builddir/build/BUILD/crochet-1.10.0/crochet/tests/test_setup.py", line 370, in test_new_logging
    self.assertIn(
AssertionError: 'INFO logger-info\nCRITICAL logger-critical\nWARNING logger-warning\nDEBUG logger-debug\nINFO log-info\nCRITICAL log-error\n' not found in ''

----------------------------------------------------------------------
Ran 120 tests in 7.312s

FAILED (failures=1, skipped=3)


For the build logs, see:
https://copr-be.cloud.fedoraproject.org/results/@python/python3.8/fedora-rawhide-x86_64/00944356-python-crochet/

For all our attempts to build python-crochet with Python 3.8, see:
https://copr.fedorainfracloud.org/coprs/g/python/python3.8/package/python-crochet/

Testing and mass rebuild of packages is happening in copr. You can follow these instructions to test locally in mock if your package builds with Python 3.8:
https://copr.fedorainfracloud.org/coprs/g/python/python3.8/

Let us know here if you have any questions.
Comment 1 Jeremy Cline 2019-06-28 18:40:30 UTC 
This looks to be an issue with Twisted, the STDLibLogObserver is expecting just the stack info argument, but the stack depth argument was added to stdlib's findCaller in commit dde9fdbe4539 ("bpo-33165: Added stacklevel parameter to logging APIs. (GH-7424)") in CPython. I'll see about sending a fix to Twisted.
Comment 2 Jeremy Cline 2019-07-01 18:16:34 UTC 
Twisted ticket: https://twistedmatrix.com/trac/ticket/9668
Pull request: https://github.com/twisted/twisted/pull/1161

I'll see about getting whatever patch is accepted upstream into the twisted package so the 3.8 builds get fixed.
Comment 3 Ben Cotton 2019-08-13 16:49:01 UTC 
This bug appears to have been reported against 'rawhide' during the Fedora 31 development cycle.
Changing version to '31'.
Comment 4 Miro Hrončok 2019-08-14 22:24:26 UTC 
The coordinated rebuild of Python 3.8 has started in the `f32-python` side tag.

If you figure out how to rebuild this package, please don't rebuild it in regular rawhide, but use the side tag instead:

    on branch master:
    $ fedpkg build --target=f32-python

To wait for a build to show up in the side tag, do:

    $ koji wait-repo f32-python --build=<nvr>

Where <nvr> is name-version-release of the source package, e.g. python-foo-1.1-2.fc32.

An updated mock config is posted at:
http://copr.fedorainfracloud.org/coprs/g/python/python3.8/

Note that it will take a while before the essential packages are rebuilt, so don't expect all your dependencies to be available right away.

Thanks. Let us know if you need up to date info, or if you have any questions.



PS this message is mass posted to all the bugs that block the PYTHON38 bug. If this is also a Fedora 31 FTBFS bug and you manage to fix it, you can do a f31 build as usual:

    on branch f31:
    $ fedpkg build
Comment 5 Miro Hrončok 2019-08-21 16:35:10 UTC 
The f32-python side tag has been merged. In order to rebuild the package, do it in regular rawhide, but please wait until python3-3.8 is tagged:

  $ koji wait-repo f32-build --build python3-3.8.0~b3-3.fc32


If your built already started in f32-python, after it is finished, please tag it to rawhide with:

  $ koji tag-build f32-pending <nvr>

For example:

  $ koji tag-build f32-pending libreoffice-6.3.0.4-3.fc32

Thanks!

(This comment is mass posted to all bugzillas blocking the PYTHON38 tracking bug.)
Comment 6 Miro Hrončok 2019-08-21 17:29:14 UTC 
(Python 3.8 has landed in the rawhide buildroot.)
Comment 7 Miro Hrončok 2019-09-16 08:43:07 UTC 
(In reply to Jeremy Cline from comment #2)
> Twisted ticket: https://twistedmatrix.com/trac/ticket/9668
> Pull request: https://github.com/twisted/twisted/pull/1161
> 
> I'll see about getting whatever patch is accepted upstream into the twisted
> package so the 3.8 builds get fixed.

Should I backport this to twisted to unblock crochet
Comment 8 Jeremy Cline 2019-09-16 15:14:41 UTC 
Ah, it looks like Rawhide hasn't been updated to Twisted 19.7, that should contain the fix: https://src.fedoraproject.org/rpms/python-twisted/pull-request/13
Comment 9 Miro Hrončok 2019-09-17 08:17:27 UTC 
Thanks.
Note You need to log in before you can comment on or make changes to this bug.