Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 173553 - Review Request: xfce4-websearch-plugin
Summary: Review Request: xfce4-websearch-plugin
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Luya Tshimbalanga
QA Contact: David Lawrence
URL: http://xfce-goodies.berlios.de/
Whiteboard:
Depends On:
Blocks: FE-ACCEPT
TreeView+ depends on / blocked
 
Reported: 2005-11-18 02:01 UTC by Christoph Wickert
Modified: 2007-11-30 22:11 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2006-01-22 20:44:30 UTC
Type: ---
Embargoed:

Attachments (Terms of Use)

Description Christoph Wickert 2005-11-18 02:01:30 UTC 
Spec Name or Url: 
http://home.arcor.de/christoph.wickert/fedora/extras-review/SPECS/xfce4-websearch-plugin.spec
SRPM Name or Url: 
http://home.arcor.de/christoph.wickert/fedora/extras-review/SRPMS/xfce4-websearch-plugin-0.1.0-3.fc4.src.rpm
Description: 
Access searchengines from the XFCE panel.

Comments:
rpmlint is clean
License GPL and included
Comment 1 Christoph Wickert 2005-12-01 13:23:48 UTC 
- Add libxfcegui4-devel BuildReqs.
- Fix %defattr.

New SRPM:
http://home.arcor.de/christoph.wickert/fedora/extras-review/SRPMS/xfce4-websearch-plugin-0.1.0-4.fc4.src.rpm
Comment 2 Luya Tshimbalanga 2005-12-19 06:13:03 UTC 
Set to FE-ACCEPT.
Comment 3 Ralf Corsepius 2005-12-19 06:26:52 UTC 
(In reply to comment #2)
> Set to FE-ACCEPT.
Please read
http://fedoraproject.org/wiki/PackageReviewGuidelines#head-df547f180bcbcf2f2dd5d779246792ed70d0fa0b

As a reviewer, you are supposed to own the bug (assign the PR to you).

Pushing package back to FE-NEW
Comment 4 Luya Tshimbalanga 2005-12-19 11:10:34 UTC 
(In reply to comment #3)

I wish I could assign this bug myself but I cannot change the bug status.
Comment 5 Michael A. Peters 2005-12-19 11:30:49 UTC 
Are you in the approved group of reviewers?(In reply to comment #4)
> (In reply to comment #3)
> 
> I wish I could assign this bug myself but I cannot change the bug status.

Are you in the approved group of package reviewers?
Comment 6 Luya Tshimbalanga 2005-12-20 10:10:57 UTC 
(In reply to comment #5)
> Are you in the approved group of reviewers?(In reply to comment #4)
> > (In reply to comment #3)
> > 
> > I wish I could assign this bug myself but I cannot change the bug status.
> 
> Are you in the approved group of package reviewers?

Yes I am
Comment 7 Luya Tshimbalanga 2006-01-20 23:11:18 UTC 
+ mock succesfully built the SRPM package. No error reported
+ rpmlint did not complain about warning and error.
 SPEC file conforms to PackagingGuideline 
http://fedoraproject.org/wiki/PackagingGuidelines
+ tarball from source rpm matched source url listed on spec file. Both matched
by md5sum and sha1sum
+ name of package conforms to  PackageNameGuideline procedure:
http://fedoraproject.org/wiki/PackageNamingGuidelines
+ License listed on the SPEC file matches license on the tarball
+ no errors and crash reported after install and removal of the package

Therefore the package is ready to be included in Fedora Extras. Set to FE-ACCEPT.
Comment 8 Christoph Wickert 2006-01-21 21:50:35 UTC 
Thanks. Please don't forget to change the status to "Assigned" when you review a
package.
Comment 9 Christoph Wickert 2006-01-22 20:44:30 UTC 
Package builds fine fore core 3 and 4 so far, rawhide is inconsistent atm. Will
do the devel builds in a few days. Closing.
Note You need to log in before you can comment on or make changes to this bug.