Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1737028 - Review Request: python-pip-epel - A tool for installing and managing Python packages
Summary: Review Request: python-pip-epel - A tool for installing and managing Python p...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora EPEL
Classification: Fedora
Component: Package Review
Version: epel7
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Patrik Kopkan
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1734572
TreeView+ depends on / blocked
 
Reported: 2019-08-02 11:16 UTC by Miro Hrončok
Modified: 2019-08-10 08:32 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2019-08-10 08:32:36 UTC
Type: Bug
Embargoed:
pkopkan: fedora-review+

Attachments (Terms of Use)

Description Miro Hrončok 2019-08-02 11:16:18 UTC 
Spec URL: https://churchyard.fedorapeople.org/SRPMS/python-pip-epel.spec
SRPM URL: https://churchyard.fedorapeople.org/SRPMS/python-pip-epel-8.1.2-9.el7.src.rpm

Description:
Pip is a replacement for easy_install.  It uses mostly the
same techniques for finding packages, so packages that were made
easy_installable should be pip-installable as well.

Fedora Account System Username: churchyard

This is a split form python-pip, see the diff at https://src.fedoraproject.org/rpms/python-pip/pull-request/39
Comment 1 Patrik Kopkan 2019-08-06 16:45:42 UTC 
pip has vendored libraries so license in not only MIT.

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated", "Expat License", "Apache License
     (v2.0)", "Python Software Foundation License (v2 or later)", "Apache
     License (v2.0) BSD (unspecified)", "*No copyright* Apache License
     (v2.0)", "ISC License", "*No copyright* GNU Lesser General Public
     License (v2.1 or later)", "GNU Lesser General Public License (v2.1 or
     later)". 218 files have unknown license. Detailed output of
     licensecheck in /home/pkopkan/Documents/review/1737028-python-pip-
     epel/licensecheck.txt
[x]: Package does not own files or directories owned by other packages.
     Note: Dirs in package are owned also by: /usr/share/bash-
     completion(buildah, fedpkg, cmake3-data, gammu, bash-completion,
     rpmlint, python2-pip, pbuilder, ModemManager, python34-pip, gpaste,
     flatpak, cowsay, python-django-bash-completion, lightdm, bubblewrap,
     lxc, tracker, plowshare, yadifa, etckeeper, yum, libmbim, glib2, lxi-
     tools, 0install, libqmi, docker-compose, beaker-client, nnn, datamash,
     reprepro, python36-pip, unar, tio, the_silver_searcher, clufter-cli,
     dconf-editor, devscripts, driverctl, pdfgrep, yadifa-tools, skopeo),
     /usr/share/bash-completion/completions(buildah, fedpkg, cmake3-data,
     gammu, bash-completion, GMT-common, rpmlint, lastpass-cli, fwupdate,
     tig, python2-pip, pbuilder, ModemManager, python34-pip, ndctl, gpaste,
     flatpak, cowsay, python-django-bash-completion, lightdm, bubblewrap,
     lxc, tracker, plowshare, yadifa, etckeeper, yum, libmbim, glib2, lxi-
     tools, libappstream-glib, 0install, libqmi, docker-compose, bash-
     completion-extras, beaker-client, nnn, datamash, kompose, reprepro,
     python36-pip, unar, libguestfs-bash-completion, tio,
     the_silver_searcher, clufter-cli, dconf-editor, coccinelle-bash-
     completion, devscripts, firewalld, driverctl, pdfgrep, yadifa-tools,
     skopeo), /usr/lib/python3.4/site-packages/pip(python34-pip),
     /usr/lib/python3.4/site-packages/pip-8.1.2-py3.4.egg-
     info(python34-pip), /usr/lib/python3.4/site-
     packages/pip/__pycache__(python34-pip), /usr/lib/python3.4/site-
     packages/pip/_vendor(python34-pip), /usr/lib/python3.4/site-
     packages/pip/_vendor/__pycache__(python34-pip),
     /usr/lib/python3.4/site-
     packages/pip/_vendor/cachecontrol(python34-pip),
     /usr/lib/python3.4/site-
     packages/pip/_vendor/cachecontrol/__pycache__(python34-pip),
     /usr/lib/python3.4/site-
     packages/pip/_vendor/cachecontrol/caches(python34-pip),
     /usr/lib/python3.4/site-
     packages/pip/_vendor/cachecontrol/caches/__pycache__(python34-pip),
     /usr/lib/python3.4/site-packages/pip/_vendor/colorama(python34-pip),
     /usr/lib/python3.4/site-
     packages/pip/_vendor/colorama/__pycache__(python34-pip),
     /usr/lib/python3.4/site-packages/pip/_vendor/distlib(python34-pip),
     /usr/lib/python3.4/site-
     packages/pip/_vendor/distlib/__pycache__(python34-pip),
     /usr/lib/python3.4/site-
     packages/pip/_vendor/distlib/_backport(python34-pip),
     /usr/lib/python3.4/site-
     packages/pip/_vendor/distlib/_backport/__pycache__(python34-pip),
     /usr/lib/python3.4/site-packages/pip/_vendor/html5lib(python34-pip),
     /usr/lib/python3.4/site-
     packages/pip/_vendor/html5lib/__pycache__(python34-pip),
     /usr/lib/python3.4/site-
     packages/pip/_vendor/html5lib/filters(python34-pip),
     /usr/lib/python3.4/site-
     packages/pip/_vendor/html5lib/filters/__pycache__(python34-pip),
     /usr/lib/python3.4/site-
     packages/pip/_vendor/html5lib/serializer(python34-pip),
     /usr/lib/python3.4/site-
     packages/pip/_vendor/html5lib/serializer/__pycache__(python34-pip),
     /usr/lib/python3.4/site-
     packages/pip/_vendor/html5lib/treeadapters(python34-pip),
     /usr/lib/python3.4/site-
     packages/pip/_vendor/html5lib/treeadapters/__pycache__(python34-pip),
     /usr/lib/python3.4/site-
     packages/pip/_vendor/html5lib/treebuilders(python34-pip),
     /usr/lib/python3.4/site-
     packages/pip/_vendor/html5lib/treebuilders/__pycache__(python34-pip),
     /usr/lib/python3.4/site-
     packages/pip/_vendor/html5lib/treewalkers(python34-pip),
     /usr/lib/python3.4/site-
     packages/pip/_vendor/html5lib/treewalkers/__pycache__(python34-pip),
     /usr/lib/python3.4/site-
     packages/pip/_vendor/html5lib/trie(python34-pip),
     /usr/lib/python3.4/site-
     packages/pip/_vendor/html5lib/trie/__pycache__(python34-pip),
     /usr/lib/python3.4/site-packages/pip/_vendor/lockfile(python34-pip),
     /usr/lib/python3.4/site-
     packages/pip/_vendor/lockfile/__pycache__(python34-pip),
     /usr/lib/python3.4/site-packages/pip/_vendor/packaging(python34-pip),
     /usr/lib/python3.4/site-
     packages/pip/_vendor/packaging/__pycache__(python34-pip),
     /usr/lib/python3.4/site-
     packages/pip/_vendor/pkg_resources(python34-pip),
     /usr/lib/python3.4/site-
     packages/pip/_vendor/pkg_resources/__pycache__(python34-pip),
     /usr/lib/python3.4/site-packages/pip/_vendor/progress(python34-pip),
     /usr/lib/python3.4/site-
     packages/pip/_vendor/progress/__pycache__(python34-pip),
     /usr/lib/python3.4/site-packages/pip/_vendor/requests(python34-pip),
     /usr/lib/python3.4/site-
     packages/pip/_vendor/requests/__pycache__(python34-pip),
     /usr/lib/python3.4/site-
     packages/pip/_vendor/requests/packages(python34-pip),
     /usr/lib/python3.4/site-
     packages/pip/_vendor/requests/packages/__pycache__(python34-pip),
     /usr/lib/python3.4/site-
     packages/pip/_vendor/requests/packages/chardet(python34-pip),
     /usr/lib/python3.4/site-
     packages/pip/_vendor/requests/packages/chardet/__pycache__(python34-pip),
     /usr/lib/python3.4/site-
     packages/pip/_vendor/requests/packages/urllib3(python34-pip),
     /usr/lib/python3.4/site-
     packages/pip/_vendor/requests/packages/urllib3/__pycache__(python34-pip),
     /usr/lib/python3.4/site-
     packages/pip/_vendor/requests/packages/urllib3/contrib(python34-pip),
     /usr/lib/python3.4/site-
     packages/pip/_vendor/requests/packages/urllib3/contrib/__pycache__(python34-pip),
     /usr/lib/python3.4/site-
     packages/pip/_vendor/requests/packages/urllib3/packages(python34-pip),
     /usr/lib/python3.4/site-
     packages/pip/_vendor/requests/packages/urllib3/packages/__pycache__(python34-pip),
     /usr/lib/python3.4/site-
     packages/pip/_vendor/requests/packages/urllib3/packages/ssl_match_hostname(python34-pip),
     /usr/lib/python3.4/site-
     packages/pip/_vendor/requests/packages/urllib3/packages/ssl_match_hostname/__pycache__(python34-pip),
     /usr/lib/python3.4/site-
     packages/pip/_vendor/requests/packages/urllib3/util(python34-pip),
     /usr/lib/python3.4/site-
     packages/pip/_vendor/requests/packages/urllib3/util/__pycache__(python34-pip),
     /usr/lib/python3.4/site-packages/pip/commands(python34-pip),
     /usr/lib/python3.4/site-
     packages/pip/commands/__pycache__(python34-pip),
     /usr/lib/python3.4/site-packages/pip/compat(python34-pip),
     /usr/lib/python3.4/site-packages/pip/compat/__pycache__(python34-pip),
     /usr/lib/python3.4/site-packages/pip/models(python34-pip),
     /usr/lib/python3.4/site-packages/pip/models/__pycache__(python34-pip),
     /usr/lib/python3.4/site-packages/pip/operations(python34-pip),
     /usr/lib/python3.4/site-
     packages/pip/operations/__pycache__(python34-pip),
     /usr/lib/python3.4/site-packages/pip/req(python34-pip),
     /usr/lib/python3.4/site-packages/pip/req/__pycache__(python34-pip),
     /usr/lib/python3.4/site-packages/pip/utils(python34-pip),
     /usr/lib/python3.4/site-packages/pip/utils/__pycache__(python34-pip),
     /usr/lib/python3.4/site-packages/pip/vcs(python34-pip),
     /usr/lib/python3.4/site-packages/pip/vcs/__pycache__(python34-pip),
     /usr/share/doc/python34-pip-8.1.2(python34-pip),
     /usr/share/doc/python34-pip-8.1.2/docs(python34-pip),
     /usr/share/doc/python34-pip-8.1.2/docs/reference(python34-pip),
     /usr/share/licenses/python34-pip-8.1.2(python34-pip)

[?]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[!]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[!]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
This is fine because python3-pip in rhel obsoletes this.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 266240 bytes in 54 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
     process.
[x]: A package which is used by another package via an egg interface should
     provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[!]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise
     justified.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[?]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: python2-pip-8.1.2-9.el7.noarch.rpm
          python-pip-epel-8.1.2-9.el7.src.rpm
python2-pip.noarch: W: spelling-error %description -l en_US installable -> install able, install-able, uninstallable
python2-pip.noarch: W: pem-certificate /usr/lib/python2.7/site-packages/pip/_vendor/requests/cacert.pem
python2-pip.noarch: E: wrong-script-interpreter /usr/lib/python2.7/site-packages/pip/_vendor/requests/certs.py /usr/bin/env python
python2-pip.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/pip/_vendor/requests/certs.py 644 /usr/bin/env python
python2-pip.noarch: E: wrong-script-interpreter /usr/lib/python2.7/site-packages/pip/_vendor/requests/packages/chardet/chardetect.py /usr/bin/env python
python2-pip.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/pip/_vendor/requests/packages/chardet/chardetect.py 644 /usr/bin/env python
python2-pip.noarch: W: no-manual-page-for-binary pip
python2-pip.noarch: W: no-manual-page-for-binary pip2
python2-pip.noarch: W: no-manual-page-for-binary pip2.7
python-pip-epel.src: W: spelling-error %description -l en_US installable -> install able, install-able, uninstallable
python-pip-epel.src: E: specfile-error warning: line 108: Possible unexpanded macro in: %package -n python%{python3_other_pkgversion}-pip
2 packages and 0 specfiles checked; 5 errors, 6 warnings.




Rpmlint (installed packages)
----------------------------
python2-pip.noarch: W: invalid-url URL: http://www.pip-installer.org <urlopen error [Errno -2] Name or service not known>
python2-pip.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/pip/_vendor/requests/packages/chardet/chardetect.py 0644L /usr/bin/env
python2-pip.noarch: W: pem-certificate /usr/lib/python2.7/site-packages/pip/_vendor/requests/cacert.pem
python2-pip.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/pip/_vendor/requests/certs.py 0644L /usr/bin/env
python2-pip.noarch: W: no-manual-page-for-binary pip
python2-pip.noarch: W: no-manual-page-for-binary pip2.7
python2-pip.noarch: W: no-manual-page-for-binary pip2
1 packages and 0 specfiles checked; 2 errors, 5 warnings.



Source checksums
----------------
https://files.pythonhosted.org/packages/source/p/pip/pip-8.1.2.tar.gz :
  CHECKSUM(SHA256) this package     : 4d24b03ffa67638a3fa931c09fd9e0273ffa904e95ebebe7d4b1a54c93d7b732
  CHECKSUM(SHA256) upstream package : 4d24b03ffa67638a3fa931c09fd9e0273ffa904e95ebebe7d4b1a54c93d7b732


Requires
--------
python2-pip (rpmlib, GLIBC filtered):
    /usr/bin/python2
    python(abi)
    python-setuptools



Provides
--------
python2-pip:
    python-pip
    python2-pip
Comment 2 Miro Hrončok 2019-08-07 07:15:15 UTC 
Should by fixed by https://src.fedoraproject.org/fork/churchyard/rpms/python-pip/c/a8e895b153395e6201e0c3ef962a1b1325dd1d1a
Comment 3 Miro Hrončok 2019-08-07 07:19:52 UTC 
Sorry, https://src.fedoraproject.org/fork/churchyard/rpms/python-pip/c/7c76d5c44edf613038b79c7186e1b1c9f613d434
Comment 4 Patrik Kopkan 2019-08-07 16:23:59 UTC 
Package approved.
Comment 5 Fedora Update System 2019-08-08 06:37:14 UTC 
FEDORA-EPEL-2019-31bd12e515 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2019-31bd12e515
Comment 6 Fedora Update System 2019-08-08 06:37:15 UTC 
FEDORA-EPEL-2019-31bd12e515 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2019-31bd12e515
Comment 7 Fedora Update System 2019-08-09 00:11:04 UTC 
python-pip-epel-8.1.2-9.el7, python2-wheel-0.29.0-2.el7, python34-setuptools-39.2.0-4.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2019-31bd12e515
Comment 8 Fedora Update System 2019-08-10 08:32:36 UTC 
python-pip-epel-8.1.2-9.el7, python2-wheel-0.29.0-2.el7, python34-setuptools-39.2.0-4.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report.
Note You need to log in before you can comment on or make changes to this bug.