Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at
Bug 173924 - Review Request: xmlstarlet - command-line XML Swiss army knife
Summary: Review Request: xmlstarlet - command-line XML Swiss army knife
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
Target Milestone: ---
Assignee: Ignacio Vazquez-Abrams
QA Contact: David Lawrence
: 173923 (view as bug list)
Depends On:
TreeView+ depends on / blocked
Reported: 2005-11-22 18:09 UTC by Paul W. Frields
Modified: 2009-11-06 23:31 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Last Closed: 2005-11-28 16:45:50 UTC
Type: ---
kevin: fedora-cvs+

Attachments (Terms of Use)

Description Paul W. Frields 2005-11-22 18:09:54 UTC
Spec Name or Url:
SRPM Name or Url:
XMLStarlet is a set of command line utilities which can be used
to transform, query, validate, and edit XML documents and files
using simple set of shell commands in similar way it is done for
plain text files using UNIX grep, sed, awk, diff, patch, join, etc

In July 2005, Ignacio Vazquez-Abrams submitted this on-list for review, and withdrew it because there were numerous things that needed patching.  Thanks to Ignacio and Tommy Reynolds, I think this software can be offered again for FE review and inclusion.  Ignacio has graciously agreed to hand this off to me for shepherding.

This utility is intended to form part of the Fedora Documentation Project toolchain, since we deal primarily in DocBook XML, so we would appreciate a reviewer's attention.  Thank you!

Comment 1 Paul W. Frields 2005-11-22 18:11:10 UTC
*** Bug 173923 has been marked as a duplicate of this bug. ***

Comment 2 Daniel Veillard 2005-11-22 22:16:34 UTC
In general I think inclusion of xmlstarlet makes sense,


Comment 3 Paul W. Frields 2005-11-22 22:17:40 UTC
Oops, there was a small snafu between Tommy and me, so please disregard the
earlier URLs.  Here are the corrected versions:


Comment 4 Paul W. Frields 2005-11-22 23:43:48 UTC
Additional fixes to make the command name in the included docs consistent.  New


Comment 5 Ignacio Vazquez-Abrams 2005-11-23 02:53:22 UTC
I'm getting a 403 on the spec file.

Comment 6 Ignacio Vazquez-Abrams 2005-11-23 03:19:42 UTC
- Source0 should be{version}.tar.gz, replacing
%{name} in there is optional
- Files in %{_mandir} are already marked %doc
! Releases with subreleases (X.Y) might cause problems with the disttag
+ Upstream source (from proper location) matches
+ Correct permissions
+ Builds cleanly in mock
+ No rpmlint warnings or errors

Comment 7 Paul W. Frields 2005-11-23 12:53:36 UTC
Handled all your comments, Ignacio.  Sorry about the spec file mode -- I fixed
that as well.  I was only using the subreleases for my private packages but I've
gone ahead and removed them for this release, now 2%{?dist}.  They are available


Thanks for your prompt review!

Comment 8 Paul W. Frields 2005-11-26 01:09:19 UTC
Ignacio, any chance to look at the revision?

Comment 9 Ignacio Vazquez-Abrams 2005-11-26 10:30:49 UTC
Sorry, got distracted for a bit. APPROVED, unless someone else can think of a
reason to veto it.

Comment 10 Xavier Bachelot 2009-11-04 15:59:28 UTC
Paul, would you mind maintaining an EL5 branch for xmlstarlet ? I can offer to maintain the branch myself if you don't want to.


Comment 11 Paul W. Frields 2009-11-04 17:04:44 UTC
I don't mind; the code hasn't changed in a long time and appears to work well everywhere I've used it.  (IIRC there's a test suite that runs in the build process.)

Comment 12 Paul W. Frields 2009-11-04 17:08:02 UTC
Package Change Request
Package Name: xmlstarlet
New Branches: EL-5
Owners: pfrields

Comment 13 Kevin Fenzi 2009-11-06 20:46:22 UTC
cvs done.

Comment 14 Paul W. Frields 2009-11-06 23:31:14 UTC
Thank you Kevin -- tagged, built, and requested for EPEL testing. Xavier, after the next push for EPEL testing you should find the package there.  Please take the time to give it a +1 karma in bodhi if everything works for you:

Note You need to log in before you can comment on or make changes to this bug.