Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at
Bug 173979 - Review Request: Licq - A graphical ICQ Client for Linux
Summary: Review Request: Licq - A graphical ICQ Client for Linux
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
Target Milestone: ---
Assignee: Tomas Mraz
QA Contact: David Lawrence
Depends On:
TreeView+ depends on / blocked
Reported: 2005-11-23 12:12 UTC by Peter Vrabec
Modified: 2007-11-30 22:11 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Last Closed: 2006-01-18 15:50:58 UTC
Type: ---

Attachments (Terms of Use)

Description Peter Vrabec 2005-11-23 12:12:06 UTC
Spec Name or Url: licq.spec
SRPM Name or Url: licq-1.3.2-1.src.rpm
Description: Licq is a ICQ Client for the common ICQ network. It provides a graphical user interface based on QT and is enhanceable with many powerful plugins.

This build supports SSL and GPGME and contains these plugins:
* auto-reply
* osd
* qt-gui
* kde-gui

This is my first package, and I'm seeking a sponsor.

Comment 1 Kevin Kofler 2005-11-29 06:49:52 UTC
Nobody interested in this? :-( While it doesn't support as many protocols as 
GAIM, LICQ has its advantages over GAIM, e.g. support for ICQ user-to-user 
chats. It would be nice to see this back (it was part of Red Hat Linux back in 
the day) in Extras. 
If you want, I can: 
* run the package through the review checklist, 
* build the package, 
* run it and report any issues noticed that way. 
I can't however formally approve the package or sponsor you, we need someone 
with a higher trust level for that. 

Comment 2 Tomas Mraz 2005-11-29 11:15:47 UTC
rpmbuild fails:

Processing files: licq-1.3.2-1
error: File not found:

KDEDIR must be set to "/usr" before make install.

plugins/qt-gui/share/Makefile must be patched so in the install-data-local
target the writability test for $(KDEDIR) is changed to $(DESTDIR)$(KDEDIR) -
this should solve the build failure.

There are many missing build requires (kde, X) - install mock to find them.

In the build process the qt-gui is built twice - with-kde and without, I think
it is unnecessary and it clutters the spec file.

Comment 3 Peter Vrabec 2005-12-16 12:03:10 UTC
I have fixed these issues from comment #2. Tomas, could u review the new package.

Comment 4 Tomas Mraz 2005-12-16 14:32:17 UTC
rpmlint licq-1.3.2-1.i386.rpm
W: licq no-documentation
W: licq dangling-relative-symlink /usr/share/licq/qt-gui/locale/cs.qm cs_CZ.qm

The symlink means that the localization of the gui doesn't work, but that's
probably some problem with the Makefile.

However the documentation should be included - at least the licence must be
included (COPYING), but I recommend including other documentation as well.

rpmlint licq-kde-1.3.2-1.i386.rpm
W: licq-kde non-standard-group Networking/Instant messaging
W: licq-kde no-documentation

rpmlint licq-osd-1.3.2-1.i386.rpm
W: licq-osd non-standard-group Networking/Instant messaging
W: licq-osd no-documentation

Again the no doc (and licence) problem and also the group should be
Applications/Internet probably.

Comment 5 Peter Vrabec 2005-12-19 10:37:15 UTC
fixed, need 4 review

Comment 6 Tomas Mraz 2005-12-20 16:13:37 UTC
Sorry, still not right:
rpmlint -v ../RPMS/i386/licq-1.3.2-1.i386.rpm
I: licq checking
E: licq version-control-internal-file /usr/share/doc/licq-1.3.2/doc/CVS/Root
E: licq version-control-internal-file /usr/share/doc/licq-1.3.2/upgrade/CVS/Root
E: licq version-control-internal-file
E: licq version-control-internal-file /usr/share/doc/licq-1.3.2/doc/CVS/Entries
E: licq version-control-internal-file /usr/share/doc/licq-1.3.2/upgrade/CVS/Entries
E: licq version-control-internal-file /usr/share/doc/licq-1.3.2/doc/CVS/Repository

Please run rpmlint against your built files next time to save your and my time
;-) Note that only relevant doc files should be in the package, not everything.

Other problems:
- please add LICENSE file to %doc as well.
- %{_datadir}/locale/* in files - this is wrong '%find_lang xxxx' must be used
with %files -f xxxx.lang'. Also the locale apparently belong to the osd plugin
so they should be packaged with it.
- read DesktopFiles entry how
to cope with the .desktop file - It's also questionable if it should be included
within the -kde subpackage or within the main package (I'd prefer that.)
- the %post script seems completely bogus to me
- the package doesn't own %{_datadir}/licq and %{_libdir}/licq

Comment 7 Peter Vrabec 2006-01-02 13:24:12 UTC
Fixed and checked with rpmlint. I hope licq package is allright now.

Comment 8 Tomas Mraz 2006-01-02 20:47:32 UTC
The desktop file should be installed with desktop-file-install utility and
BuildRequires: desktop-file-utils should be added to the .spec. The rest seems
to be OK now.

Comment 9 Peter Vrabec 2006-01-03 15:38:57 UTC
OK, .desktop file is installed with desktop-file-install and not via Makefile.

Comment 10 Tomas Mraz 2006-01-03 22:43:47 UTC
Final review:
* RPM name is OK
* Source licq-1.3.2.tar.bz2 is the same as upstream
* This is the latest version
* Builds fine
* rpmlint looks OK
* Works fine

Possible improvement:
* Tag as %%lang the files /usr/share/licq/qt-gui/locale/*.qm


Comment 11 Kevin Kofler 2006-01-18 02:13:00 UTC
Package for devel is now out. Are we going to see an FC4 build of this? That 
would be nice, FC5 is still 2 months away from now. 

Comment 12 Peter Vrabec 2006-01-18 13:14:14 UTC
I'd like to build FC4 branch as soon as possible.

Note You need to log in before you can comment on or make changes to this bug.