Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at
Bug 174278 - Review Request: tcldom - XML DOM bindings for Tcl
Summary: Review Request: tcldom - XML DOM bindings for Tcl
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
Target Milestone: ---
Assignee: John Mahowald
QA Contact: David Lawrence
Depends On: 169754
Blocks: FE-ACCEPT 175463
TreeView+ depends on / blocked
Reported: 2005-11-27 07:00 UTC by Wart
Modified: 2008-06-20 15:20 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Last Closed: 2005-12-17 06:41:51 UTC
Type: ---
kevin: fedora-cvs+

Attachments (Terms of Use)

Description Wart 2005-11-27 07:00:55 UTC
Spec Name or Url:
SRPM Name or Url:

tcldom provides DOM bindings for the Tcl scripting language.  It provides DOM processing based on either a pure-tcl implemention or using the gnome libxml2 library.

Comment 2 John Mahowald 2005-12-13 21:46:50 UTC
- package meets naming guidelines
- package meets packaging guidelines
- license (BSD) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream
- package compiles on FC4 i386
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file 

- devel package ok
- devel requires base package n-v-r 

- Have you tested this on 64 bit? %{_libdir} may prove problematic
- BuildRoot should be cleaned at the beginning of %install. 
- A bunch of compiler warnings, particularly in tcldomlibxml2.c. Be sure to tell
upstream about this, and show them your patch.

Comment 3 Wart 2005-12-13 23:43:47 UTC
My primary development machine is dual x86_64, and I haven't noticed any build
or runtime problems with %{_libdir}.  But I did notice a minor problem loading
the pure-tcl dom library that has been fixed in an updated patch in this next

BuildRoot is now cleaned at the beginning of %install

All patches have been sent upstream, and I've notified the upstream developers
about the compiler warnings.  Upstream doesn't release new packages very often,
so I don't expect to see them adopt the patches anytime soon.

New spec file and src rpm:

Comment 4 John Mahowald 2005-12-15 02:40:50 UTC
Looks good.


Comment 5 Wart 2005-12-17 06:41:51 UTC
Many thanks for the review!

Comment 6 Wart 2008-06-20 12:09:53 UTC
Package Change Request
Package Name: tcldom
New Branches: EL-4 EL-5

Comment 7 Kevin Fenzi 2008-06-20 15:20:22 UTC
cvs done.

Note You need to log in before you can comment on or make changes to this bug.