Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 177038 - Review Request: perl-version: Perl extension for Version Objects
Summary: Review Request: perl-version: Perl extension for Version Objects
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Ralf Corsepius
QA Contact: David Lawrence
URL:
Whiteboard:
Depends On:
Blocks: FE-ACCEPT
TreeView+ depends on / blocked
 
Reported: 2006-01-05 17:24 UTC by Tom "spot" Callaway
Modified: 2007-11-30 22:11 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2006-03-01 14:42:39 UTC
Type: ---
Embargoed:

Attachments (Terms of Use)

Description Tom "spot" Callaway 2006-01-05 17:24:55 UTC 
Spec Name or Url: http://www.auroralinux.org/people/spot/review/perl-version.spec
SRPM Name or Url: http://www.auroralinux.org/people/spot/review/perl-version-0.50-1.src.rpm
Description: 
Perl extension for Version Objects

NOTE: This module is a new BuildRequires for perl-Class-DBI.
Comment 1 Ralf Corsepius 2006-01-06 10:47:03 UTC 
NEEDSWORK:

1. Missing 
BuildRequires: perl(Module::Build) >= 0.2611

2. shipping *.bs
3. Redundant CFLAGS
Comment 2 Tom "spot" Callaway 2006-01-06 15:15:03 UTC 
Fixed in -2:

SRPM: http://www.auroralinux.org/people/spot/review/perl-version-0.50-2.src.rpm
SPEC: http://www.auroralinux.org/people/spot/review/perl-version.spec
Comment 3 Jose Pedro Oliveira 2006-01-06 15:24:57 UTC 
By the way, version 0.51 is out (trivial update).

Diff from version-0.50 to version-0.51
http://search.cpan.org/diff?from=version-0.50&to=version-0.51

Another suggestion:
Tag the pod file listed in %files section as documentation.
Comment 4 Tom "spot" Callaway 2006-01-06 15:32:15 UTC 
Bump to 0.51, tag the pod file as doc:

SRPM: http://www.auroralinux.org/people/spot/review/perl-version-0.51-1.src.rpm
SPEC: http://www.auroralinux.org/people/spot/review/perl-version.spec
Comment 5 Ralf Corsepius 2006-01-06 16:55:39 UTC 
rpmlint isn't happy:

# rpmlint perl-version-0.51-1.i386.rpm
E: perl-version wrong-script-interpreter
/usr/lib/perl5/vendor_perl/5.8.6/i386-linux-thread-multi/version.pm "perl"E:
perl-version non-executable-script
/usr/lib/perl5/vendor_perl/5.8.6/i386-linux-thread-multi/version.pm 0644
E: perl-version wrong-script-interpreter
/usr/lib/perl5/vendor_perl/5.8.6/i386-linux-thread-multi/version/vxs.pm "perl"
E: perl-version non-executable-script
/usr/lib/perl5/vendor_perl/5.8.6/i386-linux-thread-multi/version/vxs.pm 0644
Comment 6 Tom "spot" Callaway 2006-01-08 18:21:15 UTC 
rpmlint complaints resolved in -2:

SRPM: http://www.auroralinux.org/people/spot/review/perl-version-0.51-2.src.rpm
SPEC: http://www.auroralinux.org/people/spot/review/perl-version.spec
Comment 7 Ralf Corsepius 2006-01-09 04:22:17 UTC 
Some remarks on this excerpt from the spec:
sed -i "s|#!perl|#!%{_bindir}/perl|g" lib/version.pm
sed -i "s|#!perl|#!%{_bindir}/perl|g" lib/version/vxs.pm

1. You'd better use %{__perl} instead of %{_bindir}/perl in the sed pattern above.

2. These 2 lines could be written as one:
sed -i ...  lib/version.pm lib/version/vxs.pm

3. The "global modifier" (.../g) in the sed pattern isn't necessary.

I'll approve the package when point 1 has been addressed.
Comment 8 Tom "spot" Callaway 2006-01-09 16:36:21 UTC 
-3 addresses all three points:

SRPM: http://www.auroralinux.org/people/spot/review/perl-version-0.51-3.src.rpm
SPEC: http://www.auroralinux.org/people/spot/review/perl-version.spec
Comment 9 Ralf Corsepius 2006-01-10 01:15:20 UTC 
APPROVED
Comment 10 Jose Pedro Oliveira 2006-01-28 04:06:52 UTC 
Tom,

I have just placed new build requests as the previous ones - 2764, 2765, 2766 -
had failed (the required Module::Build version wasn't available at the time).

jpo

PS - This module could also be updated to version 0.53

Diff from version-0.51 to version-0.53
http://search.cpan.org/diff?from=version-0.51&to=version-0.53
Comment 11 Ralf Corsepius 2006-03-01 14:42:39 UTC 
Closing, apparently Spot missed to close this PR
Note You need to log in before you can comment on or make changes to this bug.