Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 177249 - Review Request: jrtplib
Summary: Review Request: jrtplib
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: John Mahowald
QA Contact: Fedora Package Reviews List
URL:
Whiteboard:
Depends On: 177247
Blocks: FE-ACCEPT
TreeView+ depends on / blocked
 
Reported: 2006-01-08 07:42 UTC by Jeffrey C. Ollie
Modified: 2007-11-30 22:11 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2006-08-29 00:43:29 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)
Failed build log (deleted)
2006-03-05 22:47 UTC, John Mahowald
no flags Details

Description Jeffrey C. Ollie 2006-01-08 07:42:39 UTC
Spec Name or Url: http://www.ocjtech.us/jrtplib-3.3.0-1.spec
SRPM Name or Url: http://www.ocjtech.us/jrtplib-3.3.0-1.src.rpm
Description:

JRTPLIB is an object-oriented RTP library written in C++. It was first
developed at the School for Knowledge Technology (or 'School voor
Kennistechnologie' in Dutch), a cooperation between the Hasselt
University) and the Maastricht University.

Comment 1 John Mahowald 2006-03-05 22:45:34 UTC
Not building on FC5, x86_64.

rtprandom.cpp: In constructor 'RTPRandom::RTPRandom()':
rtprandom.cpp:61: error: cast from 'RTPRandom*' to 'u_int32_t' loses precision
make[1]: *** [rtprandom.lo] Error 1

Comment 2 John Mahowald 2006-03-05 22:47:47 UTC
Created attachment 125686 [details]
Failed build log

Also note that lastest release is 3.4.0

Comment 3 Jeffrey C. Ollie 2006-08-07 04:00:31 UTC
Nearly forgot about this one...

Spec: http://repo.ocjtech.us/misc/fedora/development/SRPMS/jrtplib-3.6.0-1.fc6.spec
SRPM:
http://repo.ocjtech.us/misc/fedora/development/SRPMS/jrtplib-3.6.0-1.fc6.src.rpm

%changelog
* Sat Aug  5 2006 Jeffrey C. Ollie <jeff> - 3.6.0-1
- Update to 3.6.0


Comment 4 John Mahowald 2006-08-15 16:30:17 UTC
+ built on devel x86_64
+ follows naming conventions
+ license (MIT)
+ source matches
+ BuildRequires sane
+ consistent use of macros
+ devel subpackage with the development files, requires base package n-v-r
+ calls to ldconfig
+ proper %clean
+ proper permissions
+ rm of *.a and *.la

rpmlint says:
E: jrtplib shlib-with-non-pic-code /usr/lib64/libjrtp-3.6.0.so

A result of not --disable-static or equivalent so I'll ignore. Rationale
commented in spec.

Bit of a typo in devel subpackage %description, mentions JThread. Cut and paste,
I see.

APPROVED

Comment 5 Patrice Dumas 2006-08-28 22:59:40 UTC
What is happening to that request? There seems to be nothing
in owners.list and in repo?

Comment 6 Jeffrey C. Ollie 2006-08-29 00:42:49 UTC
Thanks for reminding me!  Imported and built for FC-6.


Note You need to log in before you can comment on or make changes to this bug.