Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 177277 - Review Request: perl-SQL-Abstract-Limit : Portable LIMIT Emulation
Summary: Review Request: perl-SQL-Abstract-Limit : Portable LIMIT Emulation
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jason Tibbitts
QA Contact: David Lawrence
URL:
Whiteboard:
Depends On: 177276
Blocks: FE-ACCEPT
TreeView+ depends on / blocked
 
Reported: 2006-01-08 18:32 UTC by Tom "spot" Callaway
Modified: 2007-11-30 22:11 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2006-04-10 00:15:46 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Tom "spot" Callaway 2006-01-08 18:32:06 UTC
Spec Name or Url: http://www.auroralinux.org/people/spot/review/perl-SQL-Abstract-Limit.spec
SRPM Name or Url: http://www.auroralinux.org/people/spot/review/perl-SQL-Abstract-Limit-0.12-1.src.rpm
Description: 
Portable LIMIT Emulation

This package is a new BuildRequires for perl-Class-DBI-AbstractSearch.

Comment 1 Jason Tibbitts 2006-02-21 04:50:24 UTC
A couple of issues:

The %description is, well, not there.  I know the upstream package doesn't
supply any more detail than that, but perhaps you could write just a couple of
descriptive sentences.

BuildRequires:  perl >= 1:5.6.1  is a bit pointless; Extras only supports back
to FC3 which has perl 5.8.5; I think you have to go back to Red Hat 7.2 to find
a version that wouldn't satisfy that requirement.

Doesn't build in mock (i386, development) due to the inability to resolve a
dependency on perl(DBD::AnyData).  Perhaps this should depend on bug 177276?

Comment 2 Jason Tibbitts 2006-02-21 05:04:37 UTC
Also, can you change %build to:

%{__perl} Makefile.PL INSTALLDIRS=vendor OPTIMIZE="$RPM_OPT_FLAGS"
make %{?_smp_mflags}

I know that technically for a pure Perl module with just one file there's not
much point, but sticklers will want the template followed unless something
actually breaks when you try.

Comment 3 Tom "spot" Callaway 2006-04-01 05:46:26 UTC
New SRPM:
http://www.auroralinux.org/people/spot/review/perl-SQL-Abstract-Limit-0.12-2.src.rpm
New SPEC: http://www.auroralinux.org/people/spot/review/perl-SQL-Abstract-Limit.spec

Note that I didn't add RPM_OPT_FLAGS to a noarch package, as that is just silly.

Comment 4 Jason Tibbitts 2006-04-07 20:25:28 UTC
The package builds cleanly and rpmlint is silent.

* package meets naming and packaging guidelines.
* specfile is properly named, is cleanly written, uses macros consistently and
conforms to the Perl template.
* license field matches the actual license.
* license is open source-compatible.  It's not included separately in the
package, but this is not necessary as the upstream tarball does not include it.
* source files match upstream:
   127285b0a59f2a671fd4c411371d4877  SQL-Abstract-Limit-0.12.tar.gz
   127285b0a59f2a671fd4c411371d4877  SQL-Abstract-Limit-0.12.tar.gz-upstream
* package builds in mock.
* BuildRequires are proper.
* no shared libraries are present.
* package is not relocatable.
* owns the directory it creates.
* no duplicates in %files.
* file permissions are appropriate.
* %clean is present.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* no headers.
* no pkgconfig files.
* no libtool .la droppings.
* not a GUI app.
* The package owns %{perl_vendorlib}/SQL, which will probably also be owned by
any module under the SQL:: namespace.  However, none of the dependencies create
this directory so there is no alternative but for this package to own it.

APPROVED

Comment 5 Tom "spot" Callaway 2006-04-10 00:15:46 UTC
Built in repo.


Note You need to log in before you can comment on or make changes to this bug.