Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1774507 - strip segfaults on cryptlib
Summary: strip segfaults on cryptlib
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: binutils
Version: 31
Hardware: ppc64le
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Nick Clifton
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: PPCTracker
TreeView+ depends on / blocked
 
Reported: 2019-11-20 13:10 UTC by Dan Horák
Modified: 2019-12-04 03:23 UTC (History)
6 users (show)

Fixed In Version: binutils-2.31.1-36.fc30, binutils-2.32-29.fc31, binutils-2.33.1-8.fc32 binutils-2.32-29.fc31 binutils-2.31.1-36.fc30
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2019-11-25 01:50:31 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
lib (2.01 MB, application/octet-stream)
2019-11-20 13:10 UTC, Dan Horák
no flags Details

Description Dan Horák 2019-11-20 13:10:10 UTC
Created attachment 1638128 [details]
lib

Description of problem:

<mock-chroot> sh-5.0# /usr/bin/strip -R .comment -R .note /builddir/build/BUILDROOT/cryptlib-3.4.5-5.fc31.ppc64le/usr/lib64/libcl.so.3.4.5
Segmentation fault (core dumped)

<mock-chroot> sh-5.0# gdb /usr/bin/strip
Reading symbols from /usr/bin/strip...
Reading symbols from /usr/lib/debug/usr/bin/strip-2.32-26.fc31.ppc64le.debug...
(gdb) set args -R .comment -R .note /builddir/build/BUILDROOT/cryptlib-3.4.5-5.fc31.ppc64le/usr/lib64/libcl.so.3.4.5
(gdb) run
Starting program: /usr/bin/strip -R .comment -R .note /builddir/build/BUILDROOT/cryptlib-3.4.5-5.fc31.ppc64le/usr/lib64/libcl.so.3.4.5
Missing separate debuginfos, use: dnf debuginfo-install glibc-2.30-5.fc31.ppc64le

Program received signal SIGSEGV, Segmentation fault.
0x000000010000c2ac in copy_relocations_in_section (obfdarg=0x10006bbf0, isection=0x100063ea0, ibfd=0x100062cc0) at objcopy.c:4204
4204	      bfd_set_reloc (obfd, osection, relcount == 0 ? NULL : relpp, relcount);
(gdb) where
#0  0x000000010000c2ac in copy_relocations_in_section (obfdarg=0x10006bbf0, isection=0x100063ea0, ibfd=0x100062cc0) at objcopy.c:4204
#1  copy_relocations_in_section (ibfd=0x100062cc0, isection=0x100063ea0, obfdarg=0x10006bbf0) at objcopy.c:4116
#2  0x00007ffff7e1bf00 in bfd_map_over_sections (abfd=0x100062cc0, operation=0x10000bf30 <copy_relocations_in_section>, user_storage=0x10006bbf0) at section.c:1374
#3  0x000000010000e108 in copy_object (input_arch=<optimized out>, obfd=0x10006bbf0, ibfd=0x100062cc0) at objcopy.c:3189
#4  copy_object (ibfd=0x100062cc0, obfd=0x10006bbf0, input_arch=<optimized out>) at objcopy.c:2525
#5  0x0000000100010530 in copy_file (input_filename=0x7ffffffff767 "/builddir/build/BUILDROOT/cryptlib-3.4.5-5.fc31.ppc64le/usr/lib64/libcl.so.3.4.5", 
    output_filename=0x100062c60 "/builddir/build/BUILDROOT/cryptlib-3.4.5-5.fc31.ppc64le/usr/lib64/st8v44MH", input_target=<optimized out>, output_target=<optimized out>, input_arch=0x0)
    at objcopy.c:3729
#6  0x00000001000074dc in strip_main (argv=<optimized out>, argc=<optimized out>) at objcopy.c:4676
#7  main (argc=<optimized out>, argv=<optimized out>) at objcopy.c:5824



Version-Release number of selected component (if applicable):
binutils-2.32-26.fc31.ppc64le

How reproducible:
100%

Comment 1 Nick Clifton 2019-11-21 10:44:01 UTC
Hi Dan,

  Thanks for reporting this.  There was a buffer overflow bug in the new note merging code, and this was triggering the problem.

  The bug should be fixed in binutils-2.32-29.fc31 (or 2.31.1-36.fc30 or 2.33.1-8.fc31).  Please give one a go and let me know if the problem is fixed for you.

Cheers
  Nick

Comment 2 Dan Horák 2019-11-21 11:17:09 UTC
Looks good on F-30, tested against the attached lib. Interestingly some other change in the F-31 buildroot makes the build pass today (and strip doesn't segfault).

Comment 3 Fabio Valentini 2019-11-21 16:24:51 UTC
Are you going to submit bodhi updates with the fixed builds to fedora 31 and 30 too?

The broken build made it to stable, and now builds are starting to fail:
https://koschei.fedoraproject.org/affected-by/binutils?epoch1=0&version1=2.32&release1=24.fc31&epoch2=0&version2=2.32&release2=26.fc31&collection=f31

Thanks for working on the fix!

Comment 4 Fedora Update System 2019-11-22 12:10:55 UTC
FEDORA-2019-8aa040b253 has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2019-8aa040b253

Comment 5 Fedora Update System 2019-11-22 12:10:55 UTC
FEDORA-2019-9a102a5fa8 has been submitted as an update to Fedora 30. https://bodhi.fedoraproject.org/updates/FEDORA-2019-9a102a5fa8

Comment 6 Nick Clifton 2019-11-22 12:34:12 UTC
(In reply to Fabio Valentini from comment #3)
Hi Fabio,

> Are you going to submit bodhi updates with the fixed builds to fedora 31 and
> 30 too?

Thanks for the reminder.  I have now done this.

Cheers
  Nick

Comment 7 Fabio Valentini 2019-11-22 12:36:50 UTC
(In reply to Nick Clifton from comment #6)
> (In reply to Fabio Valentini from comment #3)
> Hi Fabio,
> 
> > Are you going to submit bodhi updates with the fixed builds to fedora 31 and
> > 30 too?
> 
> Thanks for the reminder.  I have now done this.
> 
> Cheers
>   Nick

Great, thanks for working on this :)

Comment 8 Fedora Update System 2019-11-23 02:20:42 UTC
binutils-2.31.1-36.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-9a102a5fa8

Comment 9 Fedora Update System 2019-11-23 02:38:33 UTC
binutils-2.32-29.fc31 has been pushed to the Fedora 31 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-8aa040b253

Comment 10 Fedora Update System 2019-11-25 01:50:31 UTC
binutils-2.32-29.fc31 has been pushed to the Fedora 31 stable repository. If problems still persist, please make note of it in this bug report.

Comment 11 Fedora Update System 2019-12-04 03:23:17 UTC
binutils-2.31.1-36.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.