Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 177636 - Review Request: rtorrent
Summary: Review Request: rtorrent
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Hans de Goede
QA Contact: David Lawrence
URL:
Whiteboard:
Depends On: 177635
Blocks: FE-ACCEPT
TreeView+ depends on / blocked
 
Reported: 2006-01-12 16:07 UTC by Chris Chabot
Modified: 2007-11-30 22:11 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2006-01-16 09:24:45 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Chris Chabot 2006-01-12 16:07:10 UTC
SPEC: http://www.xs4all.nl/~chabotc/rtorrent.spec
SRPM: http://www.xs4all.nl/~chabotc/rtorrent-0.4.2-1.src.rpm

Description:

A client frontend to libtorrent, which on high-bandwidth connections it is                                                   
able to seed at 3 times the speed of the official client, using                                                              
ncurses and is ideal for use with screen or dtach. It supports                                                               
saving of sessions and allows the user to add and remove torrents and scanning                                               
of directories for torrent files to seed and/or download.     

Depends on package libtorrent which can be found in bug #177635

Comment 1 Rudolf Kastl 2006-01-13 08:48:38 UTC
test build on x86_64 rawhide succeeded and spec looks good to me.

Comment 2 Hans de Goede 2006-01-14 20:03:22 UTC
Things which need to be changed:
-Summary must not start with "A ..." remove "A .."
-.so Requires are picked up by rpm automaticly, remove explicit requires
-rtorrent.rc.example should be installed with 644 not 664

Possible improvements:
-I would change "A client frontend to libtorrent" to "BitTorrent client using
 libtorrent"

Formal Review:
MUST review items:
- Builds cleanly on FC5 devel.
- rpmlint has no output / complaints
- Source included matches upsteam source (md5sum)
- Package name meets guidelines
- spec file name is in %{name}.spec format
- Licence (GPL) is fedora extra's compatible & is included in spec
- Spec file is in (american) english
- Does not list buildrequires that are excepted in the package guidelines
- All build dependencies are listed
- Proper use of ldconfig
- All files have proper permissions
- Package is not relocatable
- No duplicate files in %files section
- No missing files in %files section
- Has a proper %clean section with rm -rf $RPM_BUILD_ROOT
- Uses macro's described in PackagingGuidelines
- No entries in %doc that are required for standard program operation
- No -devel package needed
- No directory-ownerships needed

Should items:
- Includes upstream licence file (COPYING)
- No insane scriplets, or scriplets at all
- No unnescesarry requires

Looks good to me, changing blockerbug to FE-ACCEPT assuming that you will fix
all items listed under "Things which need to be changed".


Comment 3 Chris Chabot 2006-01-14 20:33:34 UTC
* Sat Jan 14 2006 - Chris Chabot <chabotc> - 0.4.2-2                 
                         
- Improved summary & description                                               
                         
- Removed explicit requires, leaving to rpm                                    
                         
- Changed mode of rtorrent.rc.example to 644 

New urls:
SPEC: http://www.xs4all.nl/~chabotc/rtorrent.spec
SRPM: http://www.xs4all.nl/~chabotc/rtorrent-0.4.2-2.src.rpm

Thanks!


Comment 4 Hans de Goede 2006-01-14 20:52:29 UTC
Really changing to FE-ACCEPT (forgot that last time). Approved, but please look
over the description again the sentences aren't fluid.


Comment 5 Chris Chabot 2006-01-14 21:18:28 UTC
Thanks! Changed the description around a littlebit to make it a bit more fluid,
that will teach me to use the description from the upstream homepage :-)

Comment 6 Chris Chabot 2006-01-16 09:24:45 UTC
Build cleanly for FC5 extra's. other brances pending CVSSync. Closing bug with
NEXTRELEASE.


Note You need to log in before you can comment on or make changes to this bug.