Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 178668 - Review Request: numpy: A fast multidimensional array facility for Python
Summary: Review Request: numpy: A fast multidimensional array facility for Python
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Ed Hill
QA Contact: David Lawrence
URL:
Whiteboard:
Depends On:
Blocks: FE-ACCEPT
TreeView+ depends on / blocked
 
Reported: 2006-01-23 04:15 UTC by Ignacio Vazquez-Abrams
Modified: 2007-11-30 22:11 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2006-02-16 16:34:59 UTC
Type: ---
Embargoed:

Attachments (Terms of Use)
rpmlint output (2.85 KB, text/plain)
2006-02-04 03:37 UTC, Ed Hill 		no flags Details
View All

Description Ignacio Vazquez-Abrams 2006-01-23 04:15:22 UTC 
Spec Name or Url: http://fedora.ivazquez.net/files/extras/numpy.spec
SRPM Name or Url: http://fedora.ivazquez.net/files/extras/numpy-0.9.4-1.src.rpm
Description: The Numeric Python extensions is a set of extensions to the Python programming language which allows Python programmers to efficiently manipulate large sets of objects organized in grid-like fashion. These sets of objects are called arrays, and they can have any number of dimensions: one dimensional arrays are similar to standard Python sequences, two-dimensional arrays are similar to matrices from linear algebra. Note that one-dimensional arrays are also different from any other Python sequence, and that two-dimensional matrices are also different from the matrices of linear algebra.

This package also contains a version of f2py that works properly with it.
Comment 1 Ed Hill 2006-01-23 05:19:55 UTC 
Hi Ignacio, this is just a very quick look, not a full review:

good:
 + source matches upstream
 + specfile looks sane
 + license looks OK

needswork:
 - the license should probably (?) be in %doc
 - in %build, CFLAGS is set twice (redundant)
 - build on FC-4 fails with this message:

+ /usr/bin/python -c 'import pkg_resources, numpy ; numpy.test(1, 1)'
Traceback (most recent call last):
  File "<string>", line 1, in ?
ImportError: No module named pkg_resources
error: Bad exit status from /var/tmp/rpm-tmp.44127 (%check)
Comment 2 Ignacio Vazquez-Abrams 2006-02-02 19:19:39 UTC 
Updated.
Comment 3 Ed Hill 2006-02-04 03:37:14 UTC 
Created attachment 124151 [details]
rpmlint output
Comment 4 Ed Hill 2006-02-04 04:39:00 UTC 
Hi Ignacio, heres a more thorough review:

good:
 + good parts from comment #1 still good
 + rpmlint produces a bunch of warnings and errors but taking a
     look at them it appears that they're all just brain-dead
     rpmlint annoyances
 + package builds in mock for fc4-i386
 + BR list looks good
 + shared libs looks good (no *.la)
 + dir ownership OK
 + no %files dupes
 + permissions OK
 + has correct clean bits
 + code not content
 + some headers and libs are included but its acceptable
 + ran some simple examples and no segfaults -- good

and I don't see any blockers so its APPROVED.
Comment 5 Ignacio Vazquez-Abrams 2006-02-16 16:34:59 UTC 
Built under FC4 and devel.
Note You need to log in before you can comment on or make changes to this bug.