Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1789146 - Review Request: systemd-extras - System and Service Manager (optional components)
Summary: Review Request: systemd-extras - System and Service Manager (optional compone...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora EPEL
Classification: Fedora
Component: Package Review
Version: epel8
Hardware: All
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Neal Gompa
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2020-01-08 21:13 UTC by Robert Scheck
Modified: 2020-03-21 02:13 UTC (History)
12 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-03-21 02:13:04 UTC
Type: Bug
Embargoed:
ngompa13: fedora-review+


Attachments (Terms of Use)

Description Robert Scheck 2020-01-08 21:13:15 UTC
Spec URL: https://labs.linuxnetz.de/bugzilla/systemd-networkd.spec
SRPM URL: https://labs.linuxnetz.de/bugzilla/systemd-networkd-244.1-1.el8.src.rpm
Description: systemd-networkd is a system service that manages networks. It detects and configures network devices as they appear, as well as creating virtual network devices.
Fedora Account System Username: robert

Important: This package is intended to be only for EPEL 8 in order to address bug #1650342. In difference to the frozen systemd v239 in RHEL 8, which obviously does not receive any systemd-networkd patches/backports, this package shall be updated with new systemd-networkd versions to cover bug and security fixes as well as new features (I'm likely unable to perform larger backports like Red Hat is doing for systemd in general). If a reviewer thinks the package should be then called systemd-networkd-latest (or similar), please let me know.

Comment 1 Felix Schwarz 2020-01-10 10:30:34 UTC
One problem I see is: What version should the package track?

For example CentOS 8 is currently lagging a bit behind RHEL 8 but CentOS 8 CR has the newer version already. So one way or another there will be users who can not use the EPEL version and get dnf conflicts.
(I'm facing the same problem with my src.rpm, see https://github.com/FelixSchwarz/epel8-networkd/issues/1)

Comment 2 Robert Scheck 2020-01-10 10:53:42 UTC
My plan is to track the latest systemd-networkd version in Fedora. The systemd-networkd package in this review does not have any dependency on specific systemd versions due to shared libraries etc. (like your package). In order to build a mostly statically linked systemd-networkd, I created patch https://github.com/systemd/systemd/commit/5ac8b50d58946156094f7d4e6da8eec1209d9c3a (merged upstream) which is also used in this package. Thus my package here should even work with both, CentOS 8.0 and RHEL 8.1 (or CentOS CR/Stream), while I just tried CentOS 8.0 and CR myself. So, the versions of systemd and systemd-networkd are simply de-coupled.

Comment 3 Robert Scheck 2020-02-09 01:25:44 UTC
Spec URL: https://labs.linuxnetz.de/bugzilla/systemd-extras.spec
SRPM URL: https://labs.linuxnetz.de/bugzilla/systemd-extras-244.1-1.el8.src.rpm
Description: The systemd-extras package provides optional systemd components as sub-packages, such as systemd-networkd and systemd-timesyncd, which are not part of Red Hat Enterprise Linux 8 (and possibly derivates).


As stated before the plan is still to track systemd in Fedora to ensure ongoing security and bug fixes. Both components have been decoupled on library level (as of writing: patches partially accepted by upstream) from the systemd packages in RHEL/CentOS 8 so that there is no strict versioned dependency (that should even cover upcoming already RHEL 8.2 vs. still CentOS 8.1 differences).

Comment 4 Neal Gompa 2020-02-09 01:54:23 UTC
I guess I'm taking this review... 😰

Comment 5 Robert Scheck 2020-02-11 21:45:49 UTC
Spec URL: https://labs.linuxnetz.de/bugzilla/systemd-extras.spec
SRPM URL: https://labs.linuxnetz.de/bugzilla/systemd-extras-244.1-2.el8.src.rpm

The updated package contains a patch to make the package build succeeding in local mock rather only in the Fedora buildsystem, however it's an upstream issue (and reported there already).

Comment 6 Daan De Meyer 2020-03-04 08:16:04 UTC
Any updates on this? It would be great to have systemd-networkd available in EPEL.

Comment 7 Robert Scheck 2020-03-04 10:18:38 UTC
Neal, do you have any preliminary feedback for us regarding the review? For me, the package works here since begin of January...

Comment 8 Neal Gompa 2020-03-06 02:16:25 UTC
Review notes:

* Package is named somewhat appropriately. It's essentially a fictitious source package to not conflict with the real one in RHEL 8, so that's fine.
* The licensing matches up with the main package it was split from (systemd)
* The package builds and installs successfully
* There are no notable issues from rpmlint beyond what's always been there from systemd
* Packaging generally follows Fedora/EPEL packaging guidelines

There's only a minor issue that you can resolve on import: "%{_localstatedir}/lib" should just be "%{_sharedstatedir}".

Otherwise looks good to me. 😵

PACKAGE APPROVED.

Comment 9 Robert Scheck 2020-03-06 11:09:24 UTC
Neal, thank you really very much for the review!

Comment 10 Gwyn Ciesla 2020-03-06 14:01:44 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/systemd-extras

Comment 11 Fedora Update System 2020-03-06 16:23:14 UTC
FEDORA-EPEL-2020-3fda065940 has been submitted as an update to Fedora EPEL 8. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2020-3fda065940

Comment 12 Fedora Update System 2020-03-06 23:58:53 UTC
systemd-extras-244.1-2.el8 has been pushed to the Fedora EPEL 8 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2020-3fda065940

Comment 13 Fedora Update System 2020-03-21 02:13:04 UTC
systemd-extras-244.1-2.el8 has been pushed to the Fedora EPEL 8 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.