Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1793034 - python-firehose fails to build with Python 3.9: module 'plistlib' has no attribute 'readPlist'
Summary: python-firehose fails to build with Python 3.9: module 'plistlib' has no attr...
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: Fedora
Classification: Fedora
Component: python-firehose
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Athos Ribeiro
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
: 1842120 (view as bug list)
Depends On:
Blocks: F33FTBFS PYTHON39
TreeView+ depends on / blocked
 
Reported: 2020-01-20 14:20 UTC by Miro Hrončok
Modified: 2023-09-12 02:16 UTC (History)
7 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-07-12 08:09:48 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Miro Hrončok 2020-01-20 14:20:26 UTC
python-firehose fails to build with Python 3.9.0a2.

======================================================================
ERROR: test_example_001 (tests.parsers.test_clanganalyzer_parser.TestParsePlist)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/builddir/build/BUILD/firehose-0.5/tests/parsers/test_clanganalyzer_parser.py", line 34, in test_example_001
    a = self.parse_example('report-001.plist')
  File "/builddir/build/BUILD/firehose-0.5/tests/parsers/test_clanganalyzer_parser.py", line 26, in parse_example
    a = parse_plist(os.path.join(os.path.dirname(__file__),
  File "/builddir/build/BUILD/firehose-0.5/firehose/parsers/clanganalyzer.py", line 48, in parse_plist
    plist = plistlib.readPlist(pathOrFile)
AttributeError: module 'plistlib' has no attribute 'readPlist'
======================================================================
ERROR: test_example_002 (tests.parsers.test_clanganalyzer_parser.TestParsePlist)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/builddir/build/BUILD/firehose-0.5/tests/parsers/test_clanganalyzer_parser.py", line 65, in test_example_002
    a = self.parse_example('report-002.plist')
  File "/builddir/build/BUILD/firehose-0.5/tests/parsers/test_clanganalyzer_parser.py", line 26, in parse_example
    a = parse_plist(os.path.join(os.path.dirname(__file__),
  File "/builddir/build/BUILD/firehose-0.5/firehose/parsers/clanganalyzer.py", line 48, in parse_plist
    plist = plistlib.readPlist(pathOrFile)
AttributeError: module 'plistlib' has no attribute 'readPlist'
======================================================================
ERROR: test_example_003 (tests.parsers.test_clanganalyzer_parser.TestParsePlist)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/builddir/build/BUILD/firehose-0.5/tests/parsers/test_clanganalyzer_parser.py", line 205, in test_example_003
    a = self.parse_example('report-003.plist')
  File "/builddir/build/BUILD/firehose-0.5/tests/parsers/test_clanganalyzer_parser.py", line 26, in parse_example
    a = parse_plist(os.path.join(os.path.dirname(__file__),
  File "/builddir/build/BUILD/firehose-0.5/firehose/parsers/clanganalyzer.py", line 48, in parse_plist
    plist = plistlib.readPlist(pathOrFile)
AttributeError: module 'plistlib' has no attribute 'readPlist'
----------------------------------------------------------------------


See https://docs.python.org/3.9/whatsnew/3.9.html#removed


"The old plistlib API has been removed, it was deprecated since Python 3.4. Use the load(), loads(), dump(), and dumps() functions. Additionally, the use_builtin_types parameter was removed, standard bytes objects are always used instead. "


For the build logs, see:
https://copr-be.cloud.fedoraproject.org/results/@python/python3.9/fedora-rawhide-x86_64/01161332-python-firehose/

For all our attempts to build python-firehose with Python 3.9, see:
https://copr.fedorainfracloud.org/coprs/g/python/python3.9/package/python-firehose/

Testing and mass rebuild of packages is happening in copr. You can follow these instructions to test locally in mock if your package builds with Python 3.9:
https://copr.fedorainfracloud.org/coprs/g/python/python3.9/

Let us know here if you have any questions.

Python 3.9 will be included in Fedora 33. To make that update smoother, we're building Fedora packages with early pre-releases of Python 3.9.
A build failure prevents us from testing all dependent packages (transitive [Build]Requires), so if this package is required a lot, it's important for us to get it fixed soon.
We'd appreciate help from the people who know this package best, but if you don't want to work on this now, let us know so we can try to work around it on our side.

Comment 1 Ben Cotton 2020-02-11 17:32:13 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 32 development cycle.
Changing version to 32.

Comment 2 Miro Hrončok 2020-03-16 13:07:49 UTC
Dave, could you please have look and report this upstream if needed? Thanks.

Comment 3 Miro Hrončok 2020-05-25 13:01:47 UTC
This comment is mass posted to all bugs blocking the Python 3.9 tracker, sorry if it is not 100 % relevant. When in doubt, please ask.


The Python 3.9 rebuild is in progress in a Koji side tag.

If you fix this bug, please don't rebuild the package in regular rawhide, but do it in the side tag with:

    $ fedpkg build --target=f33-python

The rebuild is progressing slowly and it is possible this package won't have all the required build dependencies yet. If that's the case, please just leave the fix committed and pushed and we will eventually rebuild it for you.

You are not asked to go and try rebuild all the missing dependencies yourself. If you know there is a bootstrap loop in the dependencies, let me know and we can untangle it together.

If you want to test your fix or reproduce the failure, you can still use the Copr repo mentioned in the initial comment of this bug: https://copr.fedorainfracloud.org/coprs/g/python/python3.9/

Comment 4 Miro Hrončok 2020-05-29 07:11:42 UTC
Python 3.9 update: The f33-python side tag is currently being merged.

New builds in f33-python are no longer possible, but python3 is not yet updated to Python 3.9 in rawhide. You can check when Python is Python 3.9 with:

    $ koji wait-repo f33-build --build python3.9-3.9.0~b1-3.fc3

And build the packages normally after that.

Comment 5 Miro Hrončok 2020-06-01 11:47:40 UTC
*** Bug 1842120 has been marked as a duplicate of this bug. ***

Comment 7 Fedora Admin user for bugzilla script actions 2020-06-30 02:49:04 UTC
This package has changed maintainer in the Fedora.
Reassigning to the new maintainer of this component.

Comment 8 Igor Raits 2020-06-30 06:23:37 UTC
Hello,

This is the first reminder (step 3 from https://docs.fedoraproject.org/en-US/fesco/Fails_to_build_from_source_Fails_to_install/#_package_removal_for_long_standing_ftbfs_and_fti_bugs).

If you know about this problem and are planning on fixing it, please acknowledge so by setting the bug status to ASSIGNED. If you don't have time to maintain this package, consider orphaning it, so maintainers of dependent packages realize the problem.

Comment 9 Igor Raits 2020-06-30 06:51:34 UTC
This package has been orphaned.

You can pick it up at https://src.fedoraproject.org/rpms/zypper by clicking button "Take". If nobody picks it up, it will be retired and removed from a distribution.

Comment 10 Athos Ribeiro 2020-07-04 15:49:49 UTC
Patched in rawhide and submitted patch upstream.

Comment 11 Igor Raits 2020-07-05 19:22:25 UTC
Hello,

Please note that this comment was generated automatically. If you feel that this output has mistakes, please contact me via email (ignatenkobrain).

All subpackages of a package agaisnt which this bug was filled are now installable or removed from Fedora 33.

Thanks for taking care of it!

Comment 12 Niccolò Belli 2020-09-02 13:11:57 UTC
I'm getting the same error on Fedora 33 while trying to run the kholia/OSX-KVM script (https://github.com/kholia/OSX-KVM):

$ ./fetch-macOS.py --big-sur
[+] Fetching https://swscan.apple.com/content/catalogs/others/index-10.16seed-10.16-10.15-10.14-10.13-10.12-10.11-10.10-10.9-mountainlion-lion-snowleopard-leopard.merged-1.sucatalog
Traceback (most recent call last):
  File "/home/niko/devel/OSX-KVM/./fetch-macOS.py", line 442, in <module>
    main()
  File "/home/niko/devel/OSX-KVM/./fetch-macOS.py", line 398, in main
    catalog = download_and_parse_sucatalog(
  File "/home/niko/devel/OSX-KVM/./fetch-macOS.py", line 220, in download_and_parse_sucatalog
    catalog = plistlib.readPlist(localcatalogpath)
AttributeError: module 'plistlib' has no attribute 'readPlist'

Any idea how to fix this?

Comment 13 Miro Hrončok 2020-09-02 13:14:05 UTC
See https://docs.python.org/3.9/whatsnew/3.9.html#removed


"The old plistlib API has been removed, it was deprecated since Python 3.4. Use the load(), loads(), dump(), and dumps() functions. Additionally, the use_builtin_types parameter was removed, standard bytes objects are always used instead. "

The script needs to be adapted for Python 3.9+

Comment 14 Red Hat Bugzilla 2023-09-12 02:16:54 UTC
The needinfo request[s] on this closed bug have been removed as they have been unresolved for 1000 days


Note You need to log in before you can comment on or make changes to this bug.