Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1794274 - python-pynetdicom fails to build with Python 3.9: test_associate_max_pdu fails
Summary: python-pynetdicom fails to build with Python 3.9: test_associate_max_pdu fails
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: python-pynetdicom
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Alessio
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
: 1841767 (view as bug list)
Depends On:
Blocks: F33FTBFS PYTHON39
TreeView+ depends on / blocked
 
Reported: 2020-01-23 07:45 UTC by Miro Hrončok
Modified: 2020-06-11 11:48 UTC (History)
6 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-06-11 11:48:41 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Miro Hrončok 2020-01-23 07:45:28 UTC
python-pynetdicom fails to build with Python 3.9.0a2.

_________________ TestAEGoodAssociation.test_associate_max_pdu _________________
self = <pynetdicom.tests.test_ae.TestAEGoodAssociation object at 0x7ff18cfe0d90>
    def test_associate_max_pdu(self):
        """ Check Association has correct max PDUs on either end """
        self.ae = ae = AE()
        ae.acse_timeout = 5
        ae.dimse_timeout = 5
        ae.network_timeout = 5
        ae.maximum_pdu_size = 54321
        ae.add_supported_context(VerificationSOPClass)
        scp = ae.start_server(('', 11112), block=False)
    
        scu_ae = AE()
        scu_ae.acse_timeout = 5
        scu_ae.dimse_timeout = 5
        scu_ae.network_timeout = 5
        scu_ae.add_requested_context(VerificationSOPClass)
        assoc = scu_ae.associate('localhost', 11112, max_pdu=12345)
        assert assoc.is_established
    
        assert scp.active_associations[0].acceptor.maximum_length == (
            54321
        )
        assert scp.active_associations[0].requestor.maximum_length == (
            12345
        )
        assert assoc.requestor.maximum_length == 12345
        assert assoc.acceptor.maximum_length == 54321
        assoc.release()
    
        # Check 0 max pdu value - max PDU value maps to 0x10000 internally
        assoc = scu_ae.associate('localhost', 11112, max_pdu=0)
        assert assoc.requestor.maximum_length == 0
>       assert scp.active_associations[0].requestor.maximum_length == 0
E       assert 12345 == 0
E        +  where 12345 = <pynetdicom.association.ServiceUser object at 0x7ff18cf9fbe0>.maximum_length
E        +    where <pynetdicom.association.ServiceUser object at 0x7ff18cf9fbe0> = <Association(AcceptorThread@20200122170341, started daemon 140675406731008)>.requestor
pynetdicom/tests/test_ae.py:388: AssertionError



For the build logs, see:
https://copr-be.cloud.fedoraproject.org/results/@python/python3.9/fedora-rawhide-x86_64/01173191-python-pynetdicom/

For all our attempts to build python-pynetdicom with Python 3.9, see:
https://copr.fedorainfracloud.org/coprs/g/python/python3.9/package/python-pynetdicom/

Testing and mass rebuild of packages is happening in copr. You can follow these instructions to test locally in mock if your package builds with Python 3.9:
https://copr.fedorainfracloud.org/coprs/g/python/python3.9/

Let us know here if you have any questions.

Python 3.9 will be included in Fedora 33. To make that update smoother, we're building Fedora packages with early pre-releases of Python 3.9.
A build failure prevents us from testing all dependent packages (transitive [Build]Requires), so if this package is required a lot, it's important for us to get it fixed soon.
We'd appreciate help from the people who know this package best, but if you don't want to work on this now, let us know so we can try to work around it on our side.

Comment 1 Alessio 2020-01-23 12:04:40 UTC
I'm not a mock expert, but following the instruction included here: https://copr.fedorainfracloud.org/coprs/g/python/python3.9/
the build works.

Test exit is as follow:

==== 2631 passed, 27 skipped, 2 deselected, 258 warnings in 780.85 seconds =====

Comment 2 Ben Cotton 2020-02-11 17:27:32 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 32 development cycle.
Changing version to 32.

Comment 3 Miro Hrončok 2020-03-16 13:41:36 UTC
https://copr.fedorainfracloud.org/coprs/g/python/python3.9/package/python-pynetdicom/

Is it possible the build is flaky and fails randomly?

Comment 4 Miro Hrončok 2020-05-25 13:02:20 UTC
This comment is mass posted to all bugs blocking the Python 3.9 tracker, sorry if it is not 100 % relevant. When in doubt, please ask.


The Python 3.9 rebuild is in progress in a Koji side tag.

If you fix this bug, please don't rebuild the package in regular rawhide, but do it in the side tag with:

    $ fedpkg build --target=f33-python

The rebuild is progressing slowly and it is possible this package won't have all the required build dependencies yet. If that's the case, please just leave the fix committed and pushed and we will eventually rebuild it for you.

You are not asked to go and try rebuild all the missing dependencies yourself. If you know there is a bootstrap loop in the dependencies, let me know and we can untangle it together.

If you want to test your fix or reproduce the failure, you can still use the Copr repo mentioned in the initial comment of this bug: https://copr.fedorainfracloud.org/coprs/g/python/python3.9/

Comment 5 Miro Hrončok 2020-05-29 07:12:08 UTC
Python 3.9 update: The f33-python side tag is currently being merged.

New builds in f33-python are no longer possible, but python3 is not yet updated to Python 3.9 in rawhide. You can check when Python is Python 3.9 with:

    $ koji wait-repo f33-build --build python3.9-3.9.0~b1-3.fc3

And build the packages normally after that.

Comment 6 Miro Hrončok 2020-06-01 12:15:20 UTC
*** Bug 1841767 has been marked as a duplicate of this bug. ***

Comment 8 Igor Raits 2020-06-01 14:22:23 UTC
Sorry, found yet another bug in automated handling.

Comment 9 Igor Raits 2020-06-06 08:09:26 UTC
Hello,

Please note that this comment was generated automatically. If you feel that this output has mistakes, please contact me via email (ignatenkobrain).

All subpackages of a package agaisnt which this bug was filled are now installable or removed from Fedora 33.

Thanks for taking care of it!

Comment 10 Miro Hrončok 2020-06-11 11:48:41 UTC
This is a bulk close of Python 3.9 bugzillas of packages that successfully built.
If this remained open for a reason, I am sorry and feel free to reopen.


Note You need to log in before you can comment on or make changes to this bug.