Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1794339 - rss2email fails to build with Python 3.9 (hangs): uses removed threading.Thread.isAlive()
Summary: rss2email fails to build with Python 3.9 (hangs): uses removed threading.Thre...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: rss2email
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: David Kaufmann
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: F33FTBFS PYTHON39
TreeView+ depends on / blocked
 
Reported: 2020-01-23 10:38 UTC by Miro Hrončok
Modified: 2020-06-01 14:09 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-06-01 14:09:02 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Miro Hrončok 2020-01-23 10:38:13 UTC
rss2email fails to build with Python 3.9.0a2. It produces the following error:

+ /usr/bin/python3 ./test/test.py
ETraceback (most recent call last):
  File "/builddir/build/BUILDROOT/rss2email-3.11-2.fc32.x86_64/usr/bin/r2e", line 5, in <module>
    rss2email.main.run()
  File "/builddir/build/BUILDROOT/rss2email-3.11-2.fc32.x86_64/usr/lib/python3.9/site-packages/rss2email/main.py", line 171, in run
    args.func(feeds=feeds, args=args)
  File "/builddir/build/BUILDROOT/rss2email-3.11-2.fc32.x86_64/usr/lib/python3.9/site-packages/rss2email/command.py", line 87, in run
    feed.run(send=args.send)
  File "/builddir/build/BUILDROOT/rss2email-3.11-2.fc32.x86_64/usr/lib/python3.9/site-packages/rss2email/feed.py", line 843, in run
    parsed = self._fetch()
  File "/builddir/build/BUILDROOT/rss2email-3.11-2.fc32.x86_64/usr/lib/python3.9/site-packages/rss2email/feed.py", line 360, in _fetch
    return f(self.url, self.etag, modified=self.modified, **kwargs)
  File "/builddir/build/BUILDROOT/rss2email-3.11-2.fc32.x86_64/usr/lib/python3.9/site-packages/rss2email/util.py", line 77, in __call__
    elif self.isAlive():
AttributeError: 'TimeLimitedFunction' object has no attribute 'isAlive'

And never finishes.

See https://docs.python.org/3.9/whatsnew/3.9.html#removed

"The isAlive() method of threading.Thread has been removed. It was deprecated since Python 3.8. Use is_alive() instead."



For the build logs, see:
https://copr-be.cloud.fedoraproject.org/results/@python/python3.9/fedora-rawhide-x86_64/01172226-rss2email/

For all our attempts to build rss2email with Python 3.9, see:
https://copr.fedorainfracloud.org/coprs/g/python/python3.9/package/rss2email/

Testing and mass rebuild of packages is happening in copr. You can follow these instructions to test locally in mock if your package builds with Python 3.9:
https://copr.fedorainfracloud.org/coprs/g/python/python3.9/

Let us know here if you have any questions.

Python 3.9 will be included in Fedora 33. To make that update smoother, we're building Fedora packages with early pre-releases of Python 3.9.
A build failure prevents us from testing all dependent packages (transitive [Build]Requires), so if this package is required a lot, it's important for us to get it fixed soon.
We'd appreciate help from the people who know this package best, but if you don't want to work on this now, let us know so we can try to work around it on our side.

Comment 1 Karthikeyan Singaravelan 2020-01-24 13:49:58 UTC
Reported upstream : https://github.com/rss2email/rss2email/issues/85 . I will raise a PR.

Comment 2 David Kaufmann 2020-01-24 19:53:22 UTC
Thanks! I've tested the patch already, it does build now. I'll probably package it as soon as there is a release (or if that takes too long, as snapshot-release)

As currently nothing depends on it I think we can wait for the patch being applied upstream.

Comment 3 Ben Cotton 2020-02-11 17:26:05 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 32 development cycle.
Changing version to 32.

Comment 4 Miro Hrončok 2020-05-25 13:01:21 UTC
This comment is mass posted to all bugs blocking the Python 3.9 tracker, sorry if it is not 100 % relevant. When in doubt, please ask.


The Python 3.9 rebuild is in progress in a Koji side tag.

If you fix this bug, please don't rebuild the package in regular rawhide, but do it in the side tag with:

    $ fedpkg build --target=f33-python

The rebuild is progressing slowly and it is possible this package won't have all the required build dependencies yet. If that's the case, please just leave the fix committed and pushed and we will eventually rebuild it for you.

You are not asked to go and try rebuild all the missing dependencies yourself. If you know there is a bootstrap loop in the dependencies, let me know and we can untangle it together.

If you want to test your fix or reproduce the failure, you can still use the Copr repo mentioned in the initial comment of this bug: https://copr.fedorainfracloud.org/coprs/g/python/python3.9/

Comment 5 Miro Hrončok 2020-05-29 07:11:25 UTC
Python 3.9 update: The f33-python side tag is currently being merged.

New builds in f33-python are no longer possible, but python3 is not yet updated to Python 3.9 in rawhide. You can check when Python is Python 3.9 with:

    $ koji wait-repo f33-build --build python3.9-3.9.0~b1-3.fc3

And build the packages normally after that.

Comment 6 David Kaufmann 2020-06-01 14:09:02 UTC
fixed by patching downstream, there is no new release yet.


Note You need to log in before you can comment on or make changes to this bug.