Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at
Bug 179710 - Review Request: dap-netcdf_handler - NetCDF 3 data handler for the OPeNDAP Data server
Summary: Review Request: dap-netcdf_handler - NetCDF 3 data handler for the OPeNDAP D...
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
Target Milestone: ---
Assignee: Ed Hill
QA Contact: Fedora Package Reviews List
Depends On:
Blocks: FE-ACCEPT 179707
TreeView+ depends on / blocked
Reported: 2006-02-02 10:04 UTC by Patrice Dumas
Modified: 2007-11-30 22:11 UTC (History)
0 users

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Last Closed: 2006-02-20 12:41:23 UTC
Type: ---

Attachments (Terms of Use)

Description Patrice Dumas 2006-02-02 10:04:38 UTC
SRPM Name or Url:

This is the netcdf data handler for our data server. It reads netcdf 3
files and returns DAP responses that are compatible with DAP2 and the
dap-server 3.5 software.

Comment 1 Patrice Dumas 2006-02-02 10:08:43 UTC
This bug depends on #179707, but circular dependencies are not allowed.

Comment 2 Ed Hill 2006-02-16 03:42:02 UTC
Hi Patrice, I took a quick look at this package and noticed two blockers:

 - License is LGPL not GPL
 - The package naming does not follow the packaging guidelines in two
     1) the "_" delimiter is not permitted
     2) this is an addon package so its name should be 
        "dap-server-netcdf-handler" or similar

Comment 3 Patrice Dumas 2006-02-16 08:18:07 UTC
There is an exception when there is a _ in the upstream name:

"packages where the upstream name naturally contains an underscore are excluded
from this."

But I agree that there should be dap somewhere in the name. After some thinking,
I  am not convinced anymore that the handlers should depend on dap-server.
Although it is unlikely, they could be used as stand alone apps, so I propose
removing dependency on dap-server and calling the handler


and so on, to retain the upstream _ but have a more informative name. Would this
suit you?

Comment 4 Ed Hill 2006-02-19 16:35:11 UTC
Hi Patrice, yes the "dap-netcdf_handler" name is fine so please go ahead 
and post an updated SRPM and I'll continue with the review.

Comment 5 Patrice Dumas 2006-02-20 00:00:33 UTC
Here is the updated srpm:

Comment 6 Ed Hill 2006-02-20 01:48:10 UTC
Looks good, I don't see any blockers:

8d4d9ff2cca772f840b3b5449addeefc  dap-netcdf_handler-3.5.2-1.src.rpm

 + source matches upstream
 + builds in mock on FC4
 + rpmlint reports no warnings or errors
 + spec is simple and easily read
 + dir ownership is good
 + license is good, and correctly included
 + no shared libs


Comment 7 Christian Iseli 2006-10-18 13:16:50 UTC
Normalize summary field for easy parsing

Note You need to log in before you can comment on or make changes to this bug.