Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1803691 - caddy FTBFS in F31
Summary: caddy FTBFS in F31
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: caddy
Version: 31
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Carl George 🤠
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 1803692
Blocks:
TreeView+ depends on / blocked
 
Reported: 2020-02-17 09:16 UTC by Elliott Sales de Andrade
Modified: 2020-08-20 01:11 UTC (History)
3 users (show)

Fixed In Version: caddy-1.0.5-1.fc31 caddy-1.0.5-1.fc32
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-08-20 01:04:12 UTC
Type: Bug
Embargoed:

Attachments (Terms of Use)

Description Elliott Sales de Andrade 2020-02-17 09:16:38 UTC 
I'm trying to rebuild because of GHSA-jf24-p9p9-4rjh, but caddy FTBFS on F31: https://koji.fedoraproject.org/koji/taskinfo?taskID=41534785

# github.com/caddyserver/caddy/caddytls
_build/src/github.com/caddyserver/caddy/caddytls/tls.go:80:42: not enough arguments in call to certmagic.NewDefault().RevokeCert
	have (string, bool)
	want (context.Context, string, bool)

There's also an error in quic-go.
Comment 1 Robert-André Mauchin 🐧 2020-02-17 16:16:30 UTC 
I've got several open bugs to update quic and caddy

golang-github-marten-seemann-chacha20
golang-github-marten-seemann-qpack
golang-github-alangpierce-forceexport
  golang-github-lucas-clemente-quic
    caddy
Comment 2 Carl George 🤠 2020-02-17 23:56:05 UTC 
Based on the code, it looks like caddy 1.0.3 requires certmagic < 0.9.0.

https://github.com/caddyserver/caddy/blob/v1.0.3/caddytls/tls.go#L80
https://github.com/mholt/certmagic/commit/1c70bb8ce48a7b09a98ef43f03c6bcf56550d559#diff-d0b7f86cea13f90d3cc0cc2338da8d5fR439

It's the same way in caddy 1.0.4 and on the master branch.  My guess (haven't confirmed yet) is that certmagic 0.9.0+ is intended for caddy v2, which is still in beta development.  I think the certmagic 0.9.3 update for Fedora 31 be unpushed.
Comment 3 Robert-André Mauchin 🐧 2020-02-18 23:06:33 UTC 
No I have a caddy 1.0.4 in COPR: https://copr.fedorainfracloud.org/coprs/eclipseo/smallstep/build/1238609/
Comment 4 Carl George 🤠 2020-04-02 22:09:31 UTC 
It appears in your COPR you are applying a patch to resolve this.

https://copr-dist-git.fedorainfracloud.org/cgit/eclipseo/smallstep/caddy.git/tree/add-context-to-certmagic.patch

I'm happy to include that in the Fedora package to resolve the build error, but have you sent that patch upstream yet?
Comment 5 Robert-André Mauchin 🐧 2020-04-02 22:36:34 UTC 
I need several packages first to update caddy

golang-github-viant-afs
golang-github-viant-assertly
golang-github-francoispqt-gojay
  golang-github-lucas-clemente-quic
    caddy
Comment 6 Carl George 🤠 2020-04-02 23:18:51 UTC 
We can add that patch just to fix the FTBFS on the current version for now, I'd just like to see it as an upstream pull request first.  I thought about doing the pull request myself but since I didn't write the patch I'll leave it up to you.
Comment 7 Fedora Update System 2020-07-07 19:44:59 UTC 
FEDORA-2020-d08b388b4f has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-d08b388b4f
Comment 8 Fedora Update System 2020-07-07 20:57:23 UTC 
FEDORA-2020-57794b6c05 has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2020-57794b6c05
Comment 9 Fedora Update System 2020-07-08 01:17:14 UTC 
FEDORA-2020-57794b6c05 has been pushed to the Fedora 31 testing repository.
In short time you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2020-57794b6c05`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-57794b6c05

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
Comment 10 Fedora Update System 2020-07-08 01:49:30 UTC 
FEDORA-2020-d08b388b4f has been pushed to the Fedora 32 testing repository.
In short time you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2020-d08b388b4f`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-d08b388b4f

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
Comment 11 Fedora Update System 2020-08-11 18:38:44 UTC 
FEDORA-2020-cb6bb38817 has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2020-cb6bb38817
Comment 12 Fedora Update System 2020-08-11 18:38:44 UTC 
FEDORA-2020-8fb6c772f1 has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-8fb6c772f1
Comment 13 Fedora Update System 2020-08-12 01:26:38 UTC 
FEDORA-2020-8fb6c772f1 has been pushed to the Fedora 32 testing repository.
In short time you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2020-8fb6c772f1`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-8fb6c772f1

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
Comment 14 Fedora Update System 2020-08-12 01:32:14 UTC 
FEDORA-2020-cb6bb38817 has been pushed to the Fedora 31 testing repository.
In short time you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2020-cb6bb38817`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-cb6bb38817

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
Comment 15 Fedora Update System 2020-08-20 01:04:12 UTC 
FEDORA-2020-cb6bb38817 has been pushed to the Fedora 31 stable repository.
If problem still persists, please make note of it in this bug report.
Comment 16 Fedora Update System 2020-08-20 01:11:26 UTC 
FEDORA-2020-8fb6c772f1 has been pushed to the Fedora 32 stable repository.
If problem still persists, please make note of it in this bug report.
Note You need to log in before you can comment on or make changes to this bug.