Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 181013 - Review Request: qgit - a GUI browser for local git repositories
Summary: Review Request: qgit - a GUI browser for local git repositories
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: John Mahowald
QA Contact: Fedora Package Reviews List
URL:
Whiteboard:
Depends On:
Blocks: FE-ACCEPT
TreeView+ depends on / blocked
 
Reported: 2006-02-11 18:13 UTC by Dan Horák
Modified: 2007-11-30 22:11 UTC (History)
0 users

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2006-08-29 13:09:13 UTC
Type: ---
Embargoed:
wtogami: fedora-cvs+

Attachments (Terms of Use)

Description Dan Horák 2006-02-11 18:13:53 UTC 
Spec Name or Url: http://www.danny.cz/qgit.spec
SRPM Name or Url: http://www.danny.cz/qgit-1.1-0.1.rc3.3.srpm
Description:

QGit is a GUI browser for local git repositories written using the QT library.

I have gone through the MUST steps for reviewers and it should be OK. The only thing about qgit's full function is a requirement for git newer then current 1.1.6. I am in contact with the developer and he is aware of it.
Comment 1 Jochen Schmitt 2006-02-12 20:32:17 UTC 
Sorry, I will got a 404 when I try to download the SRPM file. Downloading the
SPEC file worked fine.

Best Regards:

Jochen Schmitt
Comment 2 Dan Horák 2006-02-12 21:03:47 UTC 
Updated SRPM Url: http://www.danny.cz/qgit-1.1-0.1.rc3.3.src.rpm
Comment 3 Dan Horák 2006-02-13 14:32:21 UTC 
Just checked that it builds in mock for devel.
Comment 4 Dan Horák 2006-02-19 08:36:34 UTC 
update for final release 1.1

spec Name or Url: http://www.danny.cz/qgit.spec
SRPM Name or Url: http://www.danny.cz/qgit-1.1-1.src.rpm
Comment 5 John Mahowald 2006-02-26 20:40:31 UTC 
Good:

- rpmlint clean
- package meets naming guidelines
- package meets packaging guidelines
- license (GPL) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream
- package compiles on devel (x86_64)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- proper .desktop file 
- works with a kernel tree

The only thing I can think of is that it could use an icon. Something to bug
upstream about I suppose.

APPROVED
Comment 6 Dan Horák 2006-03-03 21:52:03 UTC 
qgit is succesfully build for devel and I have asked the author to add an icon
Comment 7 John Mahowald 2006-08-29 13:09:13 UTC 
Assigning to me.
Comment 8 Dan Horák 2007-06-13 12:19:51 UTC 
Package Change Request
======================
Package Name: qgit
New Branches: EL-4 EL-5
Note You need to log in before you can comment on or make changes to this bug.