Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1816266 - http-parser update to 2.9.3 breaks ABI
Summary: http-parser update to 2.9.3 breaks ABI
Keywords:
Status: CLOSED EOL
Alias: None
Product: Fedora
Classification: Fedora
Component: http-parser
Version: 31
Hardware: x86_64
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Stephen Gallagher
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2020-03-23 17:04 UTC by Bob Rentschler
Modified: 2020-11-24 20:12 UTC (History)
8 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-11-24 20:12:54 UTC
Type: Bug
Embargoed:

Attachments (Terms of Use)

Description Bob Rentschler 2020-03-23 17:04:41 UTC 
Description of problem: 

After an upgrade of http-parser to http-parser-2.9.3-1.fc31.x86_64 ocserv is no longer able to establish connections with openconnect clients, exiting with "reason unspecified"

This seems similar but likely unrelated to https://bugzilla.redhat.com/show_bug.cgi?id=1413463


Version-Release number of selected component (if applicable):

ocserv-0.12.6-3

How reproducible:

I was able to recreate the issue on a second F31 system.

Steps to Reproduce:
1. Update to http-parser-2.9.3-1.

2. Attempt a connection to ocserv


Actual results:


Client fails to connect.

Expected results:

VPN tunnel established.

Additional info:

Downgrading http-parser and adding it to versionlock restored functionality for the time being.
Comment 1 Nikos Mavrogiannopoulos 2020-03-24 07:41:08 UTC 
I'm re-assigning to http-parser as this shouldn't happen with shared libraries in a stable fedora release.
Comment 2 Igor Raits 2020-03-24 08:21:43 UTC 
https://bodhi.fedoraproject.org/updates/FEDORA-2020-d3edca71be
Comment 3 Fedora Update System 2020-03-30 20:38:35 UTC 
FEDORA-2020-02849aa88a has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2020-02849aa88a
Comment 4 Nikos Mavrogiannopoulos 2020-03-30 20:43:04 UTC 
I do not know what is the http-parser update above and it doesn't seem to address the issue, Bob can you confirm? If not please try the build at https://bodhi.fedoraproject.org/updates/FEDORA-2020-02849aa88a
and add karma if that works.
Comment 5 Fedora Update System 2020-03-31 02:25:41 UTC 
FEDORA-2020-02849aa88a has been pushed to the Fedora 31 testing repository.
In short time you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2020-02849aa88a`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-02849aa88a

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
Comment 6 Bob Rentschler 2020-03-31 11:06:29 UTC 
(In reply to Nikos Mavrogiannopoulos from comment #4)
> I do not know what is the http-parser update above and it doesn't seem to
> address the issue, Bob can you confirm? If not please try the build at
> https://bodhi.fedoraproject.org/updates/FEDORA-2020-02849aa88a
> and add karma if that works.

I will test this today, thanks!
Comment 7 Bob Rentschler 2020-03-31 16:07:39 UTC 
Updating ocserv with `dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2020-02849aa88a` fixed the issue after upgrading to http-parser-2.9.2-2.fc31 again.
Comment 8 Bob Rentschler 2020-03-31 16:07:59 UTC 
Updating ocserv with `dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2020-02849aa88a` fixed the issue after upgrading to http-parser-2.9.2-2.fc31 again.
Comment 9 Bob Rentschler 2020-03-31 16:09:19 UTC 
(In reply to Bob Rentschler from comment #8)
> Updating ocserv with `dnf upgrade --enablerepo=updates-testing
> --advisory=FEDORA-2020-02849aa88a` fixed the issue after upgrading to
> http-parser-2.9.2-2.fc31 again.

Sorry I pasted the wrong version, http-parser-2.9.3-1 was installed prior to testing with the new version of ocserv.
Comment 10 Bob Rentschler 2020-03-31 16:09:24 UTC 
(In reply to Bob Rentschler from comment #8)
> Updating ocserv with `dnf upgrade --enablerepo=updates-testing
> --advisory=FEDORA-2020-02849aa88a` fixed the issue after upgrading to
> http-parser-2.9.2-2.fc31 again.

Sorry I pasted the wrong version, http-parser-2.9.3-1 was installed prior to testing with the new version of ocserv.
Comment 11 David Woodhouse 2020-04-06 15:41:08 UTC 
http-parser 2.9.4 has been released, which fixes the ABI breakage of 2.9.3.

If you release a rebuilt ocserv, surely that's going to break *again* if http-parser is updated again?
Comment 12 Fedora Update System 2020-04-07 03:23:16 UTC 
FEDORA-2020-02849aa88a has been pushed to the Fedora 31 stable repository.
If problem still persists, please make note of it in this bug report.
Comment 13 David Woodhouse 2020-04-07 16:30:57 UTC 
Reopening, because http-parser has still broken its ABI in Fedora 31 and all its *other* users are surely still broken?

We need to upgrade it to 2.9.4 to fix the ABI breakage.

And now we need to do it in lock-step with an ocserv upgrade, with appropriate Conflicts/Requires, because the latest build of ocserv is going to *break* when we do.
Comment 14 David Woodhouse 2020-04-25 09:17:40 UTC 
Also I think ocserv in Fedora 30 is still broken?

https://download.copr.fedorainfracloud.org/results/dwmw2/openconnect/fedora-30-x86_64/01347642-openconnect/build.log.gz
Comment 15 David Woodhouse 2020-05-01 10:10:03 UTC 
Hm, that's new....

remote: Fall-through deny
remote: Denied push for ref 'refs/heads/f30' for user 'dwmw2'
remote: All changes have been rejected
To ssh://pkgs.fedoraproject.org/rpms/ocserv
 ! [remote rejected] f30 -> f30 (pre-receive hook declined)
error: failed to push some refs to 'ssh://dwmw2.org/rpms/ocserv'
Comment 16 David Woodhouse 2020-05-01 10:11:22 UTC 
epel-7-aarch64 is also failing in my COPR builds. How is it that koji builds epel7 for x86 and ppc64le, while COPR builds for x86 and aarch64?
Comment 17 Ben Cotton 2020-11-03 17:09:03 UTC 
This message is a reminder that Fedora 31 is nearing its end of life.
Fedora will stop maintaining and issuing updates for Fedora 31 on 2020-11-24.
It is Fedora's policy to close all bug reports from releases that are no longer
maintained. At that time this bug will be closed as EOL if it remains open with a
Fedora 'version' of '31'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora 31 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora, you are encouraged  change the 'version' to a later Fedora 
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.
Comment 18 Ben Cotton 2020-11-24 20:12:54 UTC 
Fedora 31 changed to end-of-life (EOL) status on 2020-11-24. Fedora 31 is
no longer maintained, which means that it will not receive any further
security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of
Fedora please feel free to reopen this bug against that version. If you
are unable to reopen this bug, please file a new report against the
current release. If you experience problems, please add a comment to this
bug.

Thank you for reporting this bug and we are sorry it could not be fixed.
Note You need to log in before you can comment on or make changes to this bug.