Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1817713 - python-gast fails to build with Python 3.9: required field "lineno" missing from expr (and more)
Summary: python-gast fails to build with Python 3.9: required field "lineno" missing f...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: python-gast
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Miro Hrončok
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
: 1842123 (view as bug list)
Depends On: 1817678
Blocks: F33FTBFS F33FailsToInstall PYTHON39 1818006 1842113 1844892
TreeView+ depends on / blocked
 
Reported: 2020-03-26 19:22 UTC by Miro Hrončok
Modified: 2020-09-01 08:50 UTC (History)
6 users (show)

Fixed In Version: python-gast-0.3.3-3.fc33
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-08-05 14:07:40 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github serge-sans-paille gast issues 46 0 None closed Test failures with Python 3.9 2020-09-23 06:46:26 UTC
Github serge-sans-paille gast pull 47 0 None closed Support Python 3.9 2020-09-23 06:46:26 UTC

Description Miro Hrončok 2020-03-26 19:22:36 UTC
python-gast fails to build with Python 3.9.0a5.

======================================================================
ERROR: testCompile (tests.test_self.SelfTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/builddir/build/BUILD/gast-0.3.2/tests/test_self.py", line 26, in testCompile
    compile(gast.gast_to_ast(gnode), src_py, 'exec')
TypeError: required field "lineno" missing from expr

======================================================================
ERROR: test_increment_lineno (tests.test_api.APITestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/builddir/build/BUILD/gast-0.3.2/tests/test_api.py", line 64, in test_increment_lineno
    gast.increment_lineno(tree)
  File "/builddir/build/BUILD/gast-0.3.2/gast/gast.py", line 376, in increment_lineno
    child.end_lineno = getattr(child, 'end_lineno', 0) + n
TypeError: unsupported operand type(s) for +: 'NoneType' and 'int'

======================================================================
ERROR: test_ExtSlice (tests.test_compat.CompatTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/builddir/build/BUILD/gast-0.3.2/tests/test_compat.py", line 249, in test_ExtSlice
    compile(gast.gast_to_ast(tree), '<test>', 'exec')
TypeError: required field "lineno" missing from expr

======================================================================
ERROR: test_ExtSlices (tests.test_compat.CompatTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/builddir/build/BUILD/gast-0.3.2/tests/test_compat.py", line 264, in test_ExtSlices
    compile(gast.gast_to_ast(tree), '<test>', 'exec')
TypeError: required field "lineno" missing from expr

======================================================================
FAIL: test_Ellipsis (tests.test_compat.CompatTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/builddir/build/BUILD/gast-0.3.2/tests/test_compat.py", line 289, in test_Ellipsis
    self.assertEqual(gast.dump(tree), norm)
AssertionError: "Modu[300 chars]lice=Constant(value=Ellipsis, kind=None), ctx=[77 chars]=[])" != "Modu[300 chars]lice=Index(value=Constant(value=Ellipsis, kind[90 chars]=[])"
- Module(body=[FunctionDef(name='foo', args=arguments(args=[Name(id='a', ctx=Param(), annotation=None, type_comment=None)], posonlyargs=[], vararg=None, kwonlyargs=[], kw_defaults=[], kwarg=None, defaults=[]), body=[Expr(value=Subscript(value=Name(id='a', ctx=Load(), annotation=None, type_comment=None), slice=Constant(value=Ellipsis, kind=None), ctx=Load()))], decorator_list=[], returns=None, type_comment=None)], type_ignores=[])
?                                                                                                                                                                                                                                                                                                                                                         ^
+ Module(body=[FunctionDef(name='foo', args=arguments(args=[Name(id='a', ctx=Param(), annotation=None, type_comment=None)], posonlyargs=[], vararg=None, kwonlyargs=[], kw_defaults=[], kwarg=None, defaults=[]), body=[Expr(value=Subscript(value=Name(id='a', ctx=Load(), annotation=None, type_comment=None), slice=Index(value=Constant(value=Ellipsis, kind=None)), ctx=Load()))], decorator_list=[], returns=None, type_comment=None)], type_ignores=[])
?                                                                                                                                                                                                                                                                                                                    ++++++++++++                                     ^^


======================================================================
FAIL: test_ExtSliceEllipsis (tests.test_compat.CompatTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/builddir/build/BUILD/gast-0.3.2/tests/test_compat.py", line 305, in test_ExtSliceEllipsis
    self.assertEqual(gast.dump(tree), norm)
AssertionError: "Modu[300 chars]lice=Tuple(elts=[Constant(value=1, kind=None),[133 chars]=[])" != "Modu[300 chars]lice=Index(value=Tuple(elts=[Constant(value=1,[146 chars]=[])"
- Module(body=[FunctionDef(name='foo', args=arguments(args=[Name(id='a', ctx=Param(), annotation=None, type_comment=None)], posonlyargs=[], vararg=None, kwonlyargs=[], kw_defaults=[], kwarg=None, defaults=[]), body=[Expr(value=Subscript(value=Name(id='a', ctx=Load(), annotation=None, type_comment=None), slice=Tuple(elts=[Constant(value=1, kind=None), Constant(value=Ellipsis, kind=None)], ctx=Load()), ctx=Load()))], decorator_list=[], returns=None, type_comment=None)], type_ignores=[])
?                                                                                                                                                                                                                                                                                                                                                                                                                 ^
+ Module(body=[FunctionDef(name='foo', args=arguments(args=[Name(id='a', ctx=Param(), annotation=None, type_comment=None)], posonlyargs=[], vararg=None, kwonlyargs=[], kw_defaults=[], kwarg=None, defaults=[]), body=[Expr(value=Subscript(value=Name(id='a', ctx=Load(), annotation=None, type_comment=None), slice=Index(value=Tuple(elts=[Constant(value=1, kind=None), Constant(value=Ellipsis, kind=None)], ctx=Load())), ctx=Load()))], decorator_list=[], returns=None, type_comment=None)], type_ignores=[])
?                                                                                                                                                                                                                                                                                                                    ++++++++++++                                                                                             ^^


======================================================================
FAIL: test_Index (tests.test_compat.CompatTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/builddir/build/BUILD/gast-0.3.2/tests/test_compat.py", line 244, in test_Index
    self.assertEqual(gast.dump(tree), norm)
AssertionError: "Modu[300 chars]lice=Constant(value=1, kind=None), ctx=Load())[70 chars]=[])" != "Modu[300 chars]lice=Index(value=Constant(value=1, kind=None))[83 chars]=[])"
Diff is 1563 characters long. Set self.maxDiff to None to see it.

----------------------------------------------------------------------
Ran 34 tests in 0.178s

FAILED (failures=3, errors=4)

For the build logs, see:
https://copr-be.cloud.fedoraproject.org/results/@python/python3.9/fedora-rawhide-x86_64/01321089-python-gast/

For all our attempts to build python-gast with Python 3.9, see:
https://copr.fedorainfracloud.org/coprs/g/python/python3.9/package/python-gast/

Testing and mass rebuild of packages is happening in copr. You can follow these instructions to test locally in mock if your package builds with Python 3.9:
https://copr.fedorainfracloud.org/coprs/g/python/python3.9/

Let us know here if you have any questions.

Python 3.9 will be included in Fedora 33. To make that update smoother, we're building Fedora packages with early pre-releases of Python 3.9.
A build failure prevents us from testing all dependent packages (transitive [Build]Requires), so if this package is required a lot, it's important for us to get it fixed soon.
We'd appreciate help from the people who know this package best, but if you don't want to work on this now, let us know so we can try to work around it on our side.

Comment 1 Miro Hrončok 2020-05-25 13:01:45 UTC
This comment is mass posted to all bugs blocking the Python 3.9 tracker, sorry if it is not 100 % relevant. When in doubt, please ask.


The Python 3.9 rebuild is in progress in a Koji side tag.

If you fix this bug, please don't rebuild the package in regular rawhide, but do it in the side tag with:

    $ fedpkg build --target=f33-python

The rebuild is progressing slowly and it is possible this package won't have all the required build dependencies yet. If that's the case, please just leave the fix committed and pushed and we will eventually rebuild it for you.

You are not asked to go and try rebuild all the missing dependencies yourself. If you know there is a bootstrap loop in the dependencies, let me know and we can untangle it together.

If you want to test your fix or reproduce the failure, you can still use the Copr repo mentioned in the initial comment of this bug: https://copr.fedorainfracloud.org/coprs/g/python/python3.9/

Comment 2 Miro Hrončok 2020-05-29 07:11:41 UTC
Python 3.9 update: The f33-python side tag is currently being merged.

New builds in f33-python are no longer possible, but python3 is not yet updated to Python 3.9 in rawhide. You can check when Python is Python 3.9 with:

    $ koji wait-repo f33-build --build python3.9-3.9.0~b1-3.fc3

And build the packages normally after that.

Comment 3 Miro Hrončok 2020-05-30 22:42:20 UTC
*** Bug 1842123 has been marked as a duplicate of this bug. ***

Comment 5 Miro Hrončok 2020-05-31 10:17:34 UTC
I'll work on this later. It blocks just the pythran stack.

Comment 6 serge_sans_paille 2020-07-17 12:32:32 UTC
Miro, could you give a try to https://github.com/serge-sans-paille/gast/pull/47 ?

Comment 7 Miro Hrončok 2020-07-17 13:07:33 UTC
That fixes it, thanks!

Comment 8 Miro Hrončok 2020-08-05 14:07:40 UTC
Patched.

Comment 9 serge_sans_paille 2020-09-01 08:50:49 UTC
FYI, the patch has landed as gast 0.4.0


Note You need to log in before you can comment on or make changes to this bug.