Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1818007 - kdevelop-python fails to build with Python 3.9: 'Python::Ast* Python::PythonAstTransformer::visitNode' conflicts with a previous declaration
Summary: kdevelop-python fails to build with Python 3.9: 'Python::Ast* Python::PythonA...
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: kdevelop-python
Version: 33
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Minh Ngo
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: F33FTBFS PYTHON39
TreeView+ depends on / blocked
 
Reported: 2020-03-27 12:27 UTC by Miro Hrončok
Modified: 2020-08-24 12:24 UTC (History)
9 users (show)

Fixed In Version: kdevelop-python-5.5.2-4.fc33, kdevelop-python-5.5.2-4.fc34
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-08-24 11:57:27 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
KDE Software Compilation 419290 0 NOR RESOLVED Fails to build against Python 3.9 2020-08-21 08:49:23 UTC

Description Miro Hrončok 2020-03-27 12:27:16 UTC
kdevelop-python fails to build with Python 3.9.0a5.

[ 16%] Building CXX object parser/CMakeFiles/kdevpythonparser.dir/cythonsyntaxremover.cpp.o
cd /builddir/build/BUILD/kdev-python-5.5.0/x86_64-redhat-linux-gnu/parser && /usr/bin/c++  -DKCOREADDONS_LIB -DQT_CONCURRENT_LIB -DQT_CORE_LIB -DQT_DBUS_LIB -DQT_GUI_LIB -DQT_NETWORK_LIB -DQT_NO_DEBUG -DQT_WIDGETS_LIB -DQT_XML_LIB -DTRANSLATION_DOMAIN=\"kdevpython\" -D_GNU_SOURCE -D_LARGEFILE64_SOURCE -Dkdevpythonparser_EXPORTS -I/builddir/build/BUILD/kdev-python-5.5.0/x86_64-redhat-linux-gnu/parser -I/builddir/build/BUILD/kdev-python-5.5.0/parser -I/builddir/build/BUILD/kdev-python-5.5.0/x86_64-redhat-linux-gnu/parser/kdevpythonparser_autogen/include -I/builddir/build/BUILD/kdev-python-5.5.0/x86_64-redhat-linux-gnu -I/builddir/build/BUILD/kdev-python-5.5.0 -I/builddir/build/BUILD/kdev-python-5.5.0/duchain -I/usr/include/python3.9 -isystem /usr/include/kdevplatform -isystem /usr/include/KF5/KWidgetsAddons -isystem /usr/include/KF5 -isystem /usr/include/qt5 -isystem /usr/include/qt5/QtWidgets -isystem /usr/include/qt5/QtGui -isystem /usr/include/qt5/QtCore -isystem /usr/lib64/qt5/mkspecs/linux-g++ -isystem /usr/include/KF5/KI18n -isystem /usr/include/KF5/KTextEditor -isystem /usr/include/KF5/KParts -isystem /usr/include/KF5/KIOWidgets -isystem /usr/include/KF5/KIOCore -isystem /usr/include/KF5/KCoreAddons -isystem /usr/include/KF5/KService -isystem /usr/include/KF5/KConfigCore -isystem /usr/include/qt5/QtNetwork -isystem /usr/include/qt5/QtConcurrent -isystem /usr/include/qt5/QtDBus -isystem /usr/include/KF5/KJobWidgets -isystem /usr/include/KF5/KCompletion -isystem /usr/include/KF5/KXmlGui -isystem /usr/include/qt5/QtXml -isystem /usr/include/KF5/KConfigWidgets -isystem /usr/include/KF5/KCodecs -isystem /usr/include/KF5/KConfigGui -isystem /usr/include/KF5/KAuth -isystem /usr/include/KF5/KTextWidgets -isystem /usr/include/KF5/SonnetUi -isystem /usr/include/KF5/ThreadWeaver  -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fexceptions -fstack-protector-strong -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -fno-operator-names -fno-exceptions -Wall -Wextra -Wcast-align -Wchar-subscripts -Wformat-security -Wno-long-long -Wpointer-arith -Wundef -Wnon-virtual-dtor -Woverloaded-virtual -Werror=return-type -Wvla -Wdate-time -Wsuggest-override -Wlogical-op -DNDEBUG -fPIC -fvisibility=hidden -fvisibility-inlines-hidden   -fPIC -std=gnu++11 -o CMakeFiles/kdevpythonparser.dir/cythonsyntaxremover.cpp.o -c /builddir/build/BUILD/kdev-python-5.5.0/parser/cythonsyntaxremover.cpp
In file included from /builddir/build/BUILD/kdev-python-5.5.0/parser/astbuilder.cpp:44:
/builddir/build/BUILD/kdev-python-5.5.0/parser/generated.h: At global scope:
/builddir/build/BUILD/kdev-python-5.5.0/parser/generated.h:484:10: error: expected ';' at end of member declaration
  484 |     Ast* visitNode(_slice* node) {
      |          ^~~~~~~~~
      |                   ;
/builddir/build/BUILD/kdev-python-5.5.0/parser/generated.h:484:20: error: 'Python::Ast* Python::PythonAstTransformer::visitNode' conflicts with a previous declaration
  484 |     Ast* visitNode(_slice* node) {
      |                    ^~~~~~
/builddir/build/BUILD/kdev-python-5.5.0/parser/generated.h:474:10: note: previous declaration 'Python::PythonAstTransformer::visitNode'
  474 |     Ast* visitNode(_keyword* node) {
      |          ^~~~~~~~~
/builddir/build/BUILD/kdev-python-5.5.0/parser/generated.h:484:26: error: expected ')' before '*' token
  484 |     Ast* visitNode(_slice* node) {
      |                   ~      ^
      |                          )
make[2]: *** [parser/CMakeFiles/kdevpythonparser.dir/build.make:161: parser/CMakeFiles/kdevpythonparser.dir/astbuilder.cpp.o] Error 1

For the build logs, see:
https://copr-be.cloud.fedoraproject.org/results/@python/python3.9/fedora-rawhide-x86_64/01321688-kdevelop-python/

For all our attempts to build kdevelop-python with Python 3.9, see:
https://copr.fedorainfracloud.org/coprs/g/python/python3.9/package/kdevelop-python/

Testing and mass rebuild of packages is happening in copr. You can follow these instructions to test locally in mock if your package builds with Python 3.9:
https://copr.fedorainfracloud.org/coprs/g/python/python3.9/

Let us know here if you have any questions.

Python 3.9 will be included in Fedora 33. To make that update smoother, we're building Fedora packages with early pre-releases of Python 3.9.
A build failure prevents us from testing all dependent packages (transitive [Build]Requires), so if this package is required a lot, it's important for us to get it fixed soon.
We'd appreciate help from the people who know this package best, but if you don't want to work on this now, let us know so we can try to work around it on our side.

Comment 1 Jan Grulich 2020-03-27 12:36:55 UTC
I opened upstream bug: https://bugs.kde.org/show_bug.cgi?id=419290

Comment 2 Miro Hrončok 2020-05-25 13:02:42 UTC
This comment is mass posted to all bugs blocking the Python 3.9 tracker, sorry if it is not 100 % relevant. When in doubt, please ask.


The Python 3.9 rebuild is in progress in a Koji side tag.

If you fix this bug, please don't rebuild the package in regular rawhide, but do it in the side tag with:

    $ fedpkg build --target=f33-python

The rebuild is progressing slowly and it is possible this package won't have all the required build dependencies yet. If that's the case, please just leave the fix committed and pushed and we will eventually rebuild it for you.

You are not asked to go and try rebuild all the missing dependencies yourself. If you know there is a bootstrap loop in the dependencies, let me know and we can untangle it together.

If you want to test your fix or reproduce the failure, you can still use the Copr repo mentioned in the initial comment of this bug: https://copr.fedorainfracloud.org/coprs/g/python/python3.9/

Comment 3 Miro Hrončok 2020-05-29 07:12:21 UTC
Python 3.9 update: The f33-python side tag is currently being merged.

New builds in f33-python are no longer possible, but python3 is not yet updated to Python 3.9 in rawhide. You can check when Python is Python 3.9 with:

    $ koji wait-repo f33-build --build python3.9-3.9.0~b1-3.fc3

And build the packages normally after that.

Comment 4 Igor Raits 2020-06-11 05:38:09 UTC
Hello,

Please note that this comment was generated automatically. If you feel that this output has mistakes, please contact me via email (ignatenkobrain).

All subpackages of a package agaisnt which this bug was filled are now installable or removed from Fedora 33.

Thanks for taking care of it!

Comment 5 Miro Hrončok 2020-08-04 23:28:24 UTC
The following builds were made after this report was opened: kdevelop-python-5.5.1-1.fc33

Comment 6 Miro Hrončok 2020-08-07 12:47:38 UTC
Sorry, closed by accident, this package still fails to build.

Comment 7 Ben Cotton 2020-08-11 13:15:35 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 33 development cycle.
Changing version to 33.

Comment 8 Francis Herne 2020-08-19 21:04:41 UTC
This is fixed upstream in both master and 5.6 branches (but unfortunately not the recent 5.6-beta1).

Comment 9 Miro Hrončok 2020-08-22 10:31:02 UTC
Hello. This comment is mass posted to all 16 bugzillas for packages that failed to rebuild with Python 3.9 (and, in most cases, also fail to install on Fedora 33 and 34). Apologies if some of the suggestions or questions don't apply 100%.

Fedora 33 Beta Freeze starts next week on Tuesday, 2020-08-25. I haven't spammed this bugzilla because it is in ASSIGNED, or I've seen upstream has been notified.

Please consider what to do here. Is this failure critical? For example, can a test be temporarily skipped to make this package build? Is it possible to fix or workaround the failure before Fedora 33 Beta? Or before Fedora 33 Final? If not, would it make sense to retire the package (even temporarily) before the release to unblock updates from Fedora 31 or Fedora 32?

In case you need any assistance with a Python-related problem with the build, don't hesitate to let me know and I'll try to have a look.

Thank you!

Comment 10 Francis Herne 2020-08-22 11:47:35 UTC
Given that KDevelop/kdev-python 5.6 final won't be released for a few weeks, and thus will presumably miss the Fedora freeze, I've tested and pushed a 5.5-python39 branch with the necessary patches. The changes are too intrusive to justify backporting to 5.5.x proper.

Comment 11 Jan Grulich 2020-08-24 05:57:20 UTC
(In reply to Francis Herne from comment #10)
> Given that KDevelop/kdev-python 5.6 final won't be released for a few weeks,
> and thus will presumably miss the Fedora freeze, I've tested and pushed a
> 5.5-python39 branch with the necessary patches. The changes are too
> intrusive to justify backporting to 5.5.x proper.

Can you open a PR so we can push it at least to rawhide?

Comment 12 Francis Herne 2020-08-24 10:17:01 UTC
(In reply to Jan Grulich from comment #11)

> Can you open a PR so we can push it at least to rawhide?

What system do you want a PR on? The branch in question is in the repo, you can browse it at https://invent.kde.org/kdevelop/kdev-python/-/tree/5.5-python39

[to avoid possible confusion, I'm the current upstream maintainer of kdev-python, but not very familiar with Fedora's processes]

Comment 13 Jan Grulich 2020-08-24 11:57:27 UTC
(In reply to Francis Herne from comment #12)
> (In reply to Jan Grulich from comment #11)
> 
> > Can you open a PR so we can push it at least to rawhide?
> 
> What system do you want a PR on? The branch in question is in the repo, you
> can browse it at
> https://invent.kde.org/kdevelop/kdev-python/-/tree/5.5-python39
> 
> [to avoid possible confusion, I'm the current upstream maintainer of
> kdev-python, but not very familiar with Fedora's processes]

I thought you have a branch in Fedora dist-git. Anyway, I took your changes and pushed them to Rawhide. It builds now, thanks for your help.

Comment 14 Miro Hrončok 2020-08-24 12:24:28 UTC
Confirmed that this has been fixed in rawhide as well as Fedora 33. Thank You both!

$ rpm -qp --requires kdevelop-python-5.5.2-4.fc33.x86_64.rpm | grep python
libkdevpythoncompletion.so()(64bit)
libkdevpythonduchain.so()(64bit)
libkdevpythonparser.so()(64bit)
libpython3.9.so.1.0()(64bit)

$ rpm -qp --requires kdevelop-python-5.5.2-4.fc34.x86_64.rpm | grep python
libkdevpythoncompletion.so()(64bit)
libkdevpythonduchain.so()(64bit)
libkdevpythonparser.so()(64bit)
libpython3.9.so.1.0()(64bit)


Note You need to log in before you can comment on or make changes to this bug.