Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 182743 - Review Request: nessus-libraries
Summary: Review Request: nessus-libraries
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: John Mahowald
QA Contact: Fedora Package Reviews List
URL:
Whiteboard:
Depends On:
Blocks: FE-ACCEPT 182744 182941
TreeView+ depends on / blocked
 
Reported: 2006-02-24 13:49 UTC by Andreas Bierfert
Modified: 2007-11-30 22:11 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2006-03-14 09:06:33 UTC
Type: ---
Embargoed:

Attachments (Terms of Use)
spec diff to enable libpcap and make buildroot consistent (1.60 KB, patch)
2006-03-04 17:51 UTC, John Mahowald 		no flags Details | Diff
View All

Description Andreas Bierfert 2006-02-24 13:49:41 UTC 
Spec Name or Url: http://fedora.lowlatency.de/review/nessus-libraries.spec
SRPM Name or Url: http://fedora.lowlatency.de/review/nessus-libraries-2.2.6-1.src.rpm
Description: Support libraries for nessus
Comment 1 Dawid Gajownik 2006-02-24 14:57:00 UTC 
I've been playing with nessus some time ago. You may want to take a look at my
patches and spec files â http://fedora.pl/~gajownik/nessus/ 

IIRC nessus-plugins was not finished -- after one week of patching I was fed up ;-)
https://www.redhat.com/archives/fedora-extras-list/2005-July/msg00380.html
Comment 2 Andreas Bierfert 2006-02-24 15:47:14 UTC 
Thanks for posting... I will take a look and see what I can use/integrate if you
don't mind :)
Comment 3 Dawid Gajownik 2006-02-24 16:06:20 UTC 
(In reply to comment #2)
> I will take a look and see what I can use/integrate if you don't mind :)

Shure. That's the reason why I gave you link to these patches :)
Comment 4 Andreas Bierfert 2006-02-24 16:22:31 UTC 
Ok here are the first tuneups :) Thanks again =)

http://fedora.lowlatency.de/review/nessus-libraries.spec
http://fedora.lowlatency.de/review/nessus-libraries-2.2.6-2.src.rpm
Comment 5 John Mahowald 2006-03-04 17:48:15 UTC 
Why disable libpcap? It's already a BuildRequirement even.

And $RPM_BUILD_ROOT not consistent.

Otherwise looks good.
Comment 6 John Mahowald 2006-03-04 17:51:21 UTC 
Created attachment 125645 [details]
spec diff to enable libpcap and make buildroot consistent
Comment 7 Dawid Gajownik 2006-03-04 18:21:26 UTC 
(In reply to comment #5)
> Why disable libpcap?

./configure --help

[snip]

  --enable-nessuspcap     use the libpcap that comes with this package

Well, `--disable-nessuspcap' forces nessus-libraries to use system libpcap,
which is a Good Thing⢠;-)
Comment 8 Andreas Bierfert 2006-03-07 09:18:24 UTC 
Will fix the buildroot stuff. As for the libpcap Dawid is right. I'd rather use
the system one.

Any other comments?
Comment 9 John Mahowald 2006-03-14 01:32:02 UTC 
Oh, I assumed the opposite for --disble-nessuspcap

Nope.

Good:

- rpmlint checks return:
* no-version-in-last-changelog, ignoring, long lines

- package meets naming guidelines
- package meets packaging guidelines
- license (GPL) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream
- package compiles on devel (x86)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file
- devel package ok
- no .la files
- post/postun ldconfig ok
- devel requires base package n-v-r 

APPROVED.
Comment 10 Andreas Bierfert 2006-03-14 09:06:33 UTC 
Imported and pushed. 

Thanks for the review.
Note You need to log in before you can comment on or make changes to this bug.