Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at
Bug 1831336 - Bodhi fails to build with click 7.1
Summary: Bodhi fails to build with click 7.1
Alias: None
Product: Fedora
Classification: Fedora
Component: bodhi
Version: 33
Hardware: Unspecified
OS: Unspecified
Target Milestone: ---
Assignee: Fedora Infrastructure SIG
QA Contact: Fedora Extras Quality Assurance
Depends On:
Blocks: F32FTBFS F33FTBFS 1811727 1814243 1823739
TreeView+ depends on / blocked
Reported: 2020-05-04 22:42 UTC by Miro Hrončok
Modified: 2020-10-01 21:24 UTC (History)
5 users (show)

Fixed In Version: 5.2.2
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Last Closed: 2020-10-01 21:24:32 UTC
Type: Bug

Attachments (Terms of Use)

Description Miro Hrončok 2020-05-04 22:42:39 UTC
Description of problem:
Bodhi fails to build in Fedora, after click was updated to 7.1.

Version-Release number of selected component: bodhi-5.1.1-1.fc33, bodhi-5.1.1-1.fc32

____________________ TestEdit.test_wrong_update_id_argument ____________________
self = <bodhi.tests.client.test___init__.TestEdit object at 0x7fd2a046ab80>
    def test_wrong_update_id_argument(self):
        Assert that an error is given if the edit update argument given is not an update id.
        runner = testing.CliRunner()
        result = runner.invoke(
            client.edit, ['drupal7-i18n-1.17-1', '--user', 'bowlofeggs',
                          '--password', 's3kr3t', '--notes', 'this is an edited note',
                          '--url', 'http://localhost:6543'])
        assert result.exit_code == 2
        # Click 7.0 capitalizes UPDATE, and < 7 does not.
        if [int(n) for n in click.__version__.split('.')] < [7, 0]:
            label = 'update'
            label = 'UPDATE'
        expected = 'Usage: edit [OPTIONS] UPDATE\n\n' \
                   'Error: Invalid value for "{}": ' \
                   'Please provide an Update ID\n'
        expected = expected.format(label)
>       assert result.output == expected
E       assert 'Usage: edit ...n Update ID\n' == 'Usage: edit [...n Update ID\n'
E           Usage: edit [OPTIONS] UPDATE
E         - Error: Invalid value for 'UPDATE': Please provide an Update ID
E         ?                          ^      ^
E         + Error: Invalid value for "UPDATE": Please provide an Update ID
E         ?                          ^      ^
bodhi/tests/client/ AssertionError

The quotation marks got replaced in that click version.

Comment 1 Fedora Release Engineering 2020-05-10 04:24:01 UTC
Dear Maintainer,

your package has an open Fails To Build From Source bug for Fedora 32.
Action is required from you.

If you can fix your package to build, perform a build in koji, and either create
an update in bodhi, or close this bug without creating an update, if updating is
not appropriate [1]. If you are working on a fix, set the status to ASSIGNED to
acknowledge this. If you have already fixed this issue, please close this Bugzilla report.

Following the policy for such packages [2], your package will be orphaned if
this bug remains in NEW state more than 8 weeks (not sooner than 2020-06-29).

A week before the mass branching of Fedora 33 according to the schedule [3],
any packages not successfully rebuilt at least on Fedora 31 will be
retired regardless of the status of this bug.


Comment 2 Kevin Fenzi 2020-05-14 23:05:17 UTC
Cverna: Is this something you could look into?

Comment 3 Miro Hrončok 2020-05-14 23:09:28 UTC
This was fixed in distgit, but not built.

Comment 4 Ben Cotton 2020-08-11 13:23:56 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 33 development cycle.
Changing version to 33.

Note You need to log in before you can comment on or make changes to this bug.