Hello,

This is the first reminder (step 3 from https://docs.fedoraproject.org/en-US/fesco/Fails_to_build_from_source_Fails_to_install/#_package_removal_for_long_standing_ftbfs_and_fti_bugs).

I have made some changes and built.
Kind Regards

Thanks Victor,

A few things we need to keep in mind:

- please ensure that both your spec and commit change log explain the change. It's very hard to figure out what the changes in the most recent commits were :(

- Please do not use python3.8dist: that'll break builds when we move on to a new python version. We do not want to hard code the python3 version.

- https://src.fedoraproject.org/rpms/python-lfpy/c/8fe9d9967683f2a678da79d0fd4eb8bb5df04a3f?branch=master -> was this meant to be a `git revert`? If so, please use `git revert`. At the moment, that is your commit with a changelog authored by me. That's very confusing.

- the source code folder should not be checked into SCM, so I've removed that now.

- in your most recent commit, you're disabled the tests again: we can't disable tests like this just to get the package to build. The tests *must* be run. So, we need to fix the test failure here.


If you are not clear on these things, please ask your sponsor @lbazan (cc'd), or please e-mail me or catch me on one of the channels and we can go over it all together.

Another note: all our changes are in rawhide, but this bug is about F32. So we need to merge the master into f32, build, and push an update. 

(I would prefer we wait until we've enabled the tests and fixed the build properly but we could push an update in the meantime to users with tests disabled)

Victor, this is not clean  :(

* c6187d4 - (67 minutes ago) Remove checked in source - Ankur Sinha (Ankur Sinha Gmail) (HEAD -> master, origin/master, origin/HEAD)
* 58cbabd - (9 hours ago) Cosmetic changes to spec Add missing Requires/BR on neuron Enable test List supported arches Remove unneeded test files - victortyau
*   8fe9d99 - (16 hours ago) Cosmetic changes to spec Add missing Requires/BR on neuron Enable test List supported arches Remove unneeded test files - victortyau
|\  
* | 3608ae5 - (16 hours ago) Rebuilt for https://fedoraproject.org/wiki/Fedora_32_Mass_Rebuild - victortyau
| | * 9751aeb - (8 hours ago) Cosmetic changes to spec Add missing Requires/BR on neuron Enable test List supported arches Remove unneeded test files - victortyau (origin/f32)
| | * 318237e - (11 hours ago) Cosmetic changes to spec Add missing Requires/BR on neuron Enable test List supported arches Remove unneeded test files - victortyau
| | * 7d68d07 - (12 hours ago) Cosmetic changes to spec Add missing Requires/BR on neuron Enable test List supported arches Remove unneeded test files - victortyau
| | * b5d7288 - (12 hours ago) Cosmetic changes to spec Add missing Requires/BR on neuron Enable test List supported arches Remove unneeded test files - victortyau
| |/  
| * 92f01a0 - (8 days ago) Enable tests and correct other bits - Ankur Sinha (Ankur Sinha Gmail) (f32)
| * c1c0a98 - (8 days ago) Remove mpi4py from Requires - Ankur Sinha (Ankur Sinha Gmail)
| * 6df7c5e - (8 days ago) Use spaces consistently - Ankur Sinha (Ankur Sinha Gmail)
|/  
* d2cdfb0 - (10 days ago) Rebuilt for https://fedoraproject.org/wiki/Fedora_32_Mass_Rebuild - Victor Tejada Yau
* c2f4161 - (10 days ago) Update python-lfpy.spec - Victor Manuel Tejada Yau
* 6fd2c4b - (4 months ago) - Rebuilt for https://fedoraproject.org/wiki/Fedora_32_Mass_Rebuild - Fedora Release Engineering
* e90e61e - (8 months ago) Rebuilt for Python 3.8.0rc1 (#1748018) - Miro Hrončok


Each commit needs to have a clear message, and the change log needs to be updated clearly also. Now one needs to go through the file changes to see what was changed in these commits since the commit messages themselves are unhelpful. You should not re-use commit messages either. The package was only rebuilt for the mass rebuild once by release engineering. All the other times, the commit message should be something else: listing what you changed there.


For the time being, let us not push directly to the repo. Please fork the repo, open pull requests and we'll review them together and then only merge when things are ready.

Please go through this when you have a minute:
https://chris.beams.io/posts/git-commit/

First PR: https://src.fedoraproject.org/rpms/python-lfpy/pull-request/1

I'm looking into the test failures now.

Filed an issue upstream, let's see what they say. For the time being, we'll disable the tests on ppc64le and armv7hl where they fail.

Victor, for F32, you can just merge master---there's no need to diverge the two branches here.

Please fork the repo and work in your fork. When it builds correctly, please open a PR and we'll review and merge it. That way the main repository remains clean with only useful commits. 

I'm online everyday from 0900--1700 BST (UTC+1), please ping me on the channels if you need to.

ok understood, so for f32 those tests break the fedpkg local and mockbuild.
l

also, the tests are breaking the local for master branch

No, that should not be the case. Did you `git pull` after merging the pull requests? 

With the latest PRs merged (so at this: https://src.fedoraproject.org/rpms/python-lfpy/c/8aa4dd972312fe26ec1b435dde233442d7adaf9a?branch=master), the package builds fine in master. Here's a test scratch build:

- https://koji.fedoraproject.org/koji/taskinfo?taskID=44770560

It will also build fine for F32, but it depends on the neuron update which is in testing:
https://bodhi.fedoraproject.org/updates/FEDORA-2020-082d68e337

So we either request a buildroot override, or we wait for neuron to go to the updates repository in a week or so.

Victor, why have we made more changes to master now? 

That branch was fine, wasn't it? There was no need for further commits after this PRs were merged at this point. You even did a succsesful build, right?

https://src.fedoraproject.org/rpms/python-lfpy/c/8aa4dd972312fe26ec1b435dde233442d7adaf9a?branch=master


Please stop merging directly to the repo now. Please open pull requests so @lbazan and I can verify them before they are merged. The commit history now is completely broken, and you've checked in the source folder for LFPy again, after I had already removed it.

https://src.fedoraproject.org/rpms/python-lfpy/tree/master

The problem is python-lfpy cannot be installed in f32 so we have to wait for neuron update, that's it?

(In reply to Victor Tejada Yau from comment #13)
> The problem is python-lfpy cannot be installed in f32 so we have to wait for
> neuron update, that's it?

Yes, so why are you still pushing to master? What are these new commits doing?

* caba2ce - Thu, 21 May 2020 09:45:30 -0500 (17 minutes ago) (HEAD -> master, scm/master, scm/HEAD)
|           working with ankur pull request - victortyau
* 0bf526e - Thu, 21 May 2020 08:29:03 -0500 (2 hours ago)
|           working on changes from ankur - victortyau

You've made 4 new commits after the PRs were merged: https://src.fedoraproject.org/rpms/python-lfpy/commits/master
In one of them, you've committed the sources again after I already removed them once :(

https://src.fedoraproject.org/rpms/python-lfpy/blob/master/f/LFPy-2.0.7

The source should not be in the repo. We upload it separately to the look-aside cache.

Now please do not push anything directly to the repo. Please only push to your fork and open pull requests if you need to.

Sorry for the new commits I am relative new working with packaging in fedora. rookie mistakes.
Thanks for helping me.
Kind Regards

No worries, that's fine. But since you're unsure of what to do, please do not push directly to the repo. Work in your fork and open pull requests so that we can review the changes before they reach the primary repo.

We're in the #fedora-neuro channel all day. Drop by there and we'll explain how things work. Doing this over bugzilla comments is far from ideal.

FEDORA-2020-0a144d7b67 has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-0a144d7b67

Victor, I've fixed up the commit tree, and built the updated version after requesting a buildroot override for neuron.

Please delete your fork, and re-fork so you get the latest copy of the repo. Please also delete the fork on your computer and re-clone.

FEDORA-2020-0a144d7b67 has been pushed to the Fedora 32 testing repository.
In short time you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2020-0a144d7b67`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-0a144d7b67

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

FEDORA-2020-0a144d7b67 has been pushed to the Fedora 32 stable repository.
If problem still persists, please make note of it in this bug report.