Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1838452 - python-black fails to build with Python 3.9: INTERNAL ERROR: Black produced code that is not equivalent to the source
Summary: python-black fails to build with Python 3.9: INTERNAL ERROR: Black produced c...
Keywords:
Status: CLOSED UPSTREAM
Alias: None
Product: Fedora
Classification: Fedora
Component: python-black
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Christian Heimes
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
: 1841682 (view as bug list)
Depends On:
Blocks: F33FTBFS PYTHON39 1842119
TreeView+ depends on / blocked
 
Reported: 2020-05-21 08:04 UTC by Miro Hrončok
Modified: 2020-06-07 20:43 UTC (History)
7 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-06-07 20:43:11 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github psf black issues 1441 0 None open Test failures with Python 3.9.0b1 2020-06-07 20:41:35 UTC

Description Miro Hrončok 2020-05-21 08:04:22 UTC
python-black fails to build with Python 3.9.0b1.

======================================================================
FAIL: test_beginning_backslash (tests.test_black.BlackTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/usr/lib64/python3.9/unittest/mock.py", line 1337, in patched
    return func(*newargs, **newkeywargs)
  File "/builddir/build/BUILD/black-19.10b0/tests/test_black.py", line 662, in test_beginning_backslash
    black.assert_equivalent(source, actual)
  File "/builddir/build/BUILD/black-19.10b0/black.py", line 3775, in assert_equivalent
    raise AssertionError(
AssertionError: INTERNAL ERROR: Black produced code that is not equivalent to the source.  Please report a bug on https://github.com/psf/black/issues.  This diff might be helpful: 
--- src
+++ dst
@@ -1,17 +1,25 @@
 Module(
   body=
-    Print(
-      dest=
-        None,  # NoneType
-      nl=
-        True,  # bool
-      values=
-        Constant(
-          kind=
-            None,  # NoneType
-          value=
-            b'hello, world',  # bytes
-        )  # /Constant
-    )  # /Print
+    Expr(
+      value=
+        Call(
+          args=
+            Constant(
+              kind=
+                None,  # NoneType
+              value=
+                'hello, world',  # str
+            )  # /Constant
+          func=
+            Name(
+              ctx=
+                Load(
+                )  # /Load
+              id=
+                'print',  # str
+            )  # /Name
+          keywords=
+        )  # /Call
+    )  # /Expr
   type_ignores=
 )  # /Module



======================================================================
FAIL: test_expression (tests.test_black.BlackTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/builddir/build/BUILD/black-19.10b0/black.py", line 3754, in assert_equivalent
    src_ast = parse_ast(src)
  File "/builddir/build/BUILD/black-19.10b0/black.py", line 3686, in parse_ast
    return ast27.parse(src)
  File "/usr/lib64/python3.9/site-packages/typed_ast/ast27.py", line 50, in parse
    return _ast27.parse(source, filename, mode)
  File "<unknown>", line 1
    ...
    ^
SyntaxError: invalid syntax

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/lib64/python3.9/unittest/mock.py", line 1337, in patched
    return func(*newargs, **newkeywargs)
  File "/builddir/build/BUILD/black-19.10b0/tests/test_black.py", line 296, in test_expression
    black.assert_equivalent(source, actual)
  File "/builddir/build/BUILD/black-19.10b0/black.py", line 3756, in assert_equivalent
    raise AssertionError(
AssertionError: cannot use --safe with this file; failed to parse source file.  AST error message: invalid syntax (<unknown>, line 1)

======================================================================
FAIL: test_expression_diff (tests.test_black.BlackTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/builddir/build/BUILD/black-19.10b0/tests/test_black.py", line 340, in test_expression_diff
    self.assertEqual(result.exit_code, 0)
AssertionError: 123 != 0

======================================================================
FAIL: test_expression_ff (tests.test_black.BlackTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/builddir/build/BUILD/black-19.10b0/black.py", line 3754, in assert_equivalent
    src_ast = parse_ast(src)
  File "/builddir/build/BUILD/black-19.10b0/black.py", line 3686, in parse_ast
    return ast27.parse(src)
  File "<unknown>", line 1
    ...
    ^
SyntaxError: invalid syntax

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/builddir/build/BUILD/black-19.10b0/tests/test_black.py", line 327, in test_expression_ff
    black.assert_equivalent(source, actual)
  File "/builddir/build/BUILD/black-19.10b0/black.py", line 3756, in assert_equivalent
    raise AssertionError(
AssertionError: cannot use --safe with this file; failed to parse source file.  AST error message: invalid syntax (<unknown>, line 1)

----------------------------------------------------------------------
Ran 119 tests in 20.821s

For the build logs, see:
https://copr-be.cloud.fedoraproject.org/results/@python/python3.9/fedora-rawhide-x86_64/01396598-python-black/

For all our attempts to build python-black with Python 3.9, see:
https://copr.fedorainfracloud.org/coprs/g/python/python3.9/package/python-black/

Testing and mass rebuild of packages is happening in copr. You can follow these instructions to test locally in mock if your package builds with Python 3.9:
https://copr.fedorainfracloud.org/coprs/g/python/python3.9/

Let us know here if you have any questions.

Python 3.9 will be included in Fedora 33. To make that update smoother, we're building Fedora packages with early pre-releases of Python 3.9.
A build failure prevents us from testing all dependent packages (transitive [Build]Requires), so if this package is required a lot, it's important for us to get it fixed soon.
We'd appreciate help from the people who know this package best, but if you don't want to work on this now, let us know so we can try to work around it on our side.

Comment 1 Miro Hrončok 2020-05-21 08:13:25 UTC
Reported to upstream at https://github.com/psf/black/issues/1441

Comment 2 Miro Hrončok 2020-05-25 13:02:20 UTC
This comment is mass posted to all bugs blocking the Python 3.9 tracker, sorry if it is not 100 % relevant. When in doubt, please ask.


The Python 3.9 rebuild is in progress in a Koji side tag.

If you fix this bug, please don't rebuild the package in regular rawhide, but do it in the side tag with:

    $ fedpkg build --target=f33-python

The rebuild is progressing slowly and it is possible this package won't have all the required build dependencies yet. If that's the case, please just leave the fix committed and pushed and we will eventually rebuild it for you.

You are not asked to go and try rebuild all the missing dependencies yourself. If you know there is a bootstrap loop in the dependencies, let me know and we can untangle it together.

If you want to test your fix or reproduce the failure, you can still use the Copr repo mentioned in the initial comment of this bug: https://copr.fedorainfracloud.org/coprs/g/python/python3.9/

Comment 3 Miro Hrončok 2020-05-29 07:12:06 UTC
Python 3.9 update: The f33-python side tag is currently being merged.

New builds in f33-python are no longer possible, but python3 is not yet updated to Python 3.9 in rawhide. You can check when Python is Python 3.9 with:

    $ koji wait-repo f33-build --build python3.9-3.9.0~b1-3.fc3

And build the packages normally after that.

Comment 4 Miro Hrončok 2020-05-29 15:04:45 UTC
*** Bug 1841682 has been marked as a duplicate of this bug. ***

Comment 6 Christian Heimes 2020-05-30 08:31:13 UTC
Miro has reported the bug upstream. We are waiting for a fix.

Comment 7 Igor Raits 2020-06-04 01:30:04 UTC
Hello,

Please note that this comment was generated automatically. If you feel that this output has mistakes, please contact me via email (ignatenkobrain).

All subpackages of a package agaisnt which this bug was filled are now installable or removed from Fedora 33.

Thanks for taking care of it!

Comment 8 Miro Hrončok 2020-06-07 20:43:11 UTC
A workaround has been pushed and the package has been built. The rest is up to black/cpython upstream.

Thanks, Adam.


Note You need to log in before you can comment on or make changes to this bug.