Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1838696 - python-x2go fails to build with Python 3.9: name 'AF_INET' is not defined (possibly a gevent bug)
Summary: python-x2go fails to build with Python 3.9: name 'AF_INET' is not defined (po...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: python-gevent
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Dan Callaghan
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
: 1841800 (view as bug list)
Depends On: 1840109
Blocks: F33FTBFS F33FailsToInstall PYTHON39
TreeView+ depends on / blocked
 
Reported: 2020-05-21 15:27 UTC by Miro Hrončok
Modified: 2020-06-13 08:54 UTC (History)
9 users (show)

Fixed In Version: python-gevent-20.6.1-1.fc33, python-x2go-0.6.1.3-3.fc33
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-06-13 08:54:02 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Miro Hrončok 2020-05-21 15:27:18 UTC
python-x2go fails to build with Python 3.9.0b1.

+ make -C docs SPHINXBUILD=/usr/bin/sphinx-build-3 html
make: Entering directory '/builddir/build/BUILD/python-x2go-0.6.1.3/docs'
/usr/bin/sphinx-build-3 -b html -d build/doctrees   source build/html
Running Sphinx v2.2.2

Configuration error:
There is a programmable error in your configuration file:

Traceback (most recent call last):
  File "/usr/lib/python3.9/site-packages/sphinx/config.py", line 361, in eval_config_file
    execfile_(filename, namespace)
  File "/usr/lib/python3.9/site-packages/sphinx/util/pycompat.py", line 81, in execfile_
    exec(code, _globals)
  File "/builddir/build/BUILD/python-x2go-0.6.1.3/docs/source/conf.py", line 22, in <module>
    import x2go
  File "/builddir/build/BUILD/python-x2go-0.6.1.3/x2go/__init__.py", line 42, in <module>
    monkey.patch_all()
  File "/usr/lib64/python3.9/site-packages/gevent/monkey.py", line 1168, in patch_all
    patch_ssl(_warnings=_warnings, _first_time=first_time)
  File "/usr/lib64/python3.9/site-packages/gevent/monkey.py", line 194, in ignores
    return func(*args, **kwargs)
  File "/usr/lib64/python3.9/site-packages/gevent/monkey.py", line 965, in patch_ssl
    gevent_mod, _ = _patch_module('ssl', _warnings=_warnings)
  File "/usr/lib64/python3.9/site-packages/gevent/monkey.py", line 412, in _patch_module
    gevent_module = getattr(__import__('gevent.' + name), name)
  File "/usr/lib64/python3.9/site-packages/gevent/ssl.py", line 32, in <module>
    from gevent import _ssl3 as _source # pragma: no cover
  File "/usr/lib64/python3.9/site-packages/gevent/_ssl3.py", line 171, in <module>
    class SSLSocket(socket):
  File "/usr/lib64/python3.9/site-packages/gevent/_ssl3.py", line 184, in SSLSocket
    family=AF_INET, type=SOCK_STREAM, proto=0, fileno=None,
NameError: name 'AF_INET' is not defined

Sounds like a gevent bug? Not sure.


For the build logs, see:
https://copr-be.cloud.fedoraproject.org/results/@python/python3.9/fedora-rawhide-x86_64/01400734-python-x2go/

For all our attempts to build python-x2go with Python 3.9, see:
https://copr.fedorainfracloud.org/coprs/g/python/python3.9/package/python-x2go/

Testing and mass rebuild of packages is happening in copr. You can follow these instructions to test locally in mock if your package builds with Python 3.9:
https://copr.fedorainfracloud.org/coprs/g/python/python3.9/

Let us know here if you have any questions.

Python 3.9 will be included in Fedora 33. To make that update smoother, we're building Fedora packages with early pre-releases of Python 3.9.
A build failure prevents us from testing all dependent packages (transitive [Build]Requires), so if this package is required a lot, it's important for us to get it fixed soon.
We'd appreciate help from the people who know this package best, but if you don't want to work on this now, let us know so we can try to work around it on our side.

Comment 1 Orion Poplawski 2020-05-22 03:39:20 UTC
Unless python-x2go is not using gevent correctly, this seems like a python-gevent bug.  x2go/__init__.py does:

from gevent import monkey
monkey.patch_all()

which seems pretty simple.  But I guess it isn't properly importing the AF_INET name via this path.

Comment 2 Miro Hrončok 2020-05-25 13:01:18 UTC
This comment is mass posted to all bugs blocking the Python 3.9 tracker, sorry if it is not 100 % relevant. When in doubt, please ask.


The Python 3.9 rebuild is in progress in a Koji side tag.

If you fix this bug, please don't rebuild the package in regular rawhide, but do it in the side tag with:

    $ fedpkg build --target=f33-python

The rebuild is progressing slowly and it is possible this package won't have all the required build dependencies yet. If that's the case, please just leave the fix committed and pushed and we will eventually rebuild it for you.

You are not asked to go and try rebuild all the missing dependencies yourself. If you know there is a bootstrap loop in the dependencies, let me know and we can untangle it together.

If you want to test your fix or reproduce the failure, you can still use the Copr repo mentioned in the initial comment of this bug: https://copr.fedorainfracloud.org/coprs/g/python/python3.9/

Comment 3 Miro Hrončok 2020-05-29 07:11:22 UTC
Python 3.9 update: The f33-python side tag is currently being merged.

New builds in f33-python are no longer possible, but python3 is not yet updated to Python 3.9 in rawhide. You can check when Python is Python 3.9 with:

    $ koji wait-repo f33-build --build python3.9-3.9.0~b1-3.fc3

And build the packages normally after that.

Comment 4 Igor Raits 2020-06-12 13:33:42 UTC
Hello,

Please note that this comment was generated automatically. If you feel that this output has mistakes, please contact me via email (ignatenkobrain).

All subpackages of a package agaisnt which this bug was filled are now installable or removed from Fedora 33.

Thanks for taking care of it!

Comment 5 Dan Callaghan 2020-06-13 06:33:51 UTC
This is fixed in the latest gevent release.

Comment 6 Miro Hrončok 2020-06-13 08:44:31 UTC
*** Bug 1841800 has been marked as a duplicate of this bug. ***

Comment 7 Miro Hrončok 2020-06-13 08:54:02 UTC
Thanks.


Note You need to log in before you can comment on or make changes to this bug.