Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 183887 (perl-Net-SSH-Perl) - Review Request: perl-Net-SSH-Perl
Summary: Review Request: perl-Net-SSH-Perl
Keywords:
Status: CLOSED NEXTRELEASE
Alias: perl-Net-SSH-Perl
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jason Tibbitts
QA Contact: Fedora Package Reviews List
URL:
Whiteboard:
Depends On: perl-Crypt-RSA
Blocks: FE-ACCEPT
TreeView+ depends on / blocked
 
Reported: 2006-03-03 13:33 UTC by Paul Howarth
Modified: 2009-03-13 03:09 UTC (History)
0 users

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2006-04-19 16:14:28 UTC
Type: ---
Embargoed:
kevin: fedora-cvs+


Attachments (Terms of Use)

Description Paul Howarth 2006-03-03 13:33:08 UTC
Spec Name or Url: http://www.city-fan.org/~paul/extras/perl-Net-SSH-Perl/perl-Net-SSH-Perl.spec
SRPM Name or Url: http://www.city-fan.org/~paul/extras/perl-Net-SSH-Perl/perl-Net-SSH-Perl-1.29-1.src.rpm
Description:

Net::SSH::Perl is an all-Perl module implementing an SSH (Secure Shell)
client. It is compatible with both the SSH-1 and SSH-2 protocols.

Comment 1 Paul Howarth 2006-03-20 11:20:24 UTC
Updated SRPM (new upstream version):

http://www.city-fan.org/~paul/extras/perl-Net-SSH-Perl/perl-Net-SSH-Perl-1.30-1.src.rpm

Spec URL unchanged.

Comment 2 Jason Tibbitts 2006-04-19 15:13:18 UTC
Now that all of the prerequisites are built:

* package meets naming and packaging guidelines.
* specfile is properly named, is cleanly written, uses macros consistently and
conforms to the Perl template.
* license field matches the actual license.
* license is open source-compatible and included in the package.
* source files match upstream:

* BuildRequires are proper.
* package builds in mock.
* rpmlint is silent.
* final provides and requires are sane.
* no shared libraries are present.
* package is not relocatable.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* %clean is present.
* %check is present and all tests pass.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* no headers.
* no pkgconfig files.
* no libtool .la droppings.
* not a GUI app.

APPROVED.

Comment 3 Paul Howarth 2006-04-19 16:14:28 UTC
Thanks once again for the review.

 7884 (perl-Net-SSH-Perl): Build on target fedora-development-extras succeeded.
     Build logs may be found at
http://buildsys.fedoraproject.org/logs/fedora-development-extras/7884-perl-Net-SSH-Perl-1.30-1.fc6/

FC-4 and FC-5 branches requested.

Comment 4 Paul Howarth 2009-03-11 11:04:39 UTC
Package Change Request
======================
Package Name: perl-Net-SSH-Perl
New Branches: EL-4 EL-5
Owners: pghmcfc
InitialCC: perl-sig

Comment 5 Kevin Fenzi 2009-03-13 03:09:31 UTC
cvs done.


Note You need to log in before you can comment on or make changes to this bug.