Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1845562 - system-upgrade plugin should do "dnf group upgrade" as part of transaction solution
Summary: system-upgrade plugin should do "dnf group upgrade" as part of transaction so...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: dnf-plugins-extras
Version: 33
Hardware: Unspecified
OS: Unspecified
low
unspecified
Target Milestone: ---
Assignee: Pavla Kratochvilova
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
: 1814306 (view as bug list)
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2020-06-09 14:11 UTC by Neal Gompa
Modified: 2020-10-27 01:20 UTC (History)
16 users (show)

Fixed In Version: dnf-plugins-extras-4.0.12-1.fc32 dnf-plugins-extras-4.0.12-1.fc33
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-10-18 15:49:15 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Neal Gompa 2020-06-09 14:11:39 UTC
Description of problem:
Today, "dnf system-upgrade" does not compute "comps upgrades" (updating packages and installing new packages from comps descriptions). This makes system-upgrade runs for Fedora releases inconsistent on package sets from fresh installs in terms of base expected functionality.

Please make it possible for system upgrades to also trigger evaluation of comps groups for target release and trigger update+install behaviors accordingly.

Version-Release number of selected component (if applicable):
4.0.10-2.fc33

Additional info:
This is a request by Workstation WG so that our upgrades work as we expect them to.

Comment 1 Igor Raits 2020-06-09 14:49:13 UTC
Essentially to get installed groups you need: installed_groups = [g.ui_name for g in self.base.comps.groups if self.base.history.group.get(g.id)]

Then to actually run upgrade of them: self.base.env_group_upgrade(installed_groups)

However, the problem is that when Workstation is installed, no groups are in the history, so DNF does not know about any installed group. Bummer.

Comment 2 Igor Raits 2020-06-09 14:51:39 UTC
It actually does record... Some of them..

❯ sudo dnf group list --installed 
Last metadata expiration check: 1:02:48 ago on Tue 09 Jun 2020 03:48:30 PM CEST.
Installed Groups:
   Container Management
   LibreOffice
   GNOME Desktop Environment
   Fonts
   Hardware Support


But I installed Fedora Workstation from Live just yesterday.

Comment 3 James Cassell 2020-06-09 16:24:19 UTC
there's also the thing where it hides most of the groups by default unless you pass some magic flags...

Comment 4 Miro Hrončok 2020-06-11 10:30:00 UTC
1. the user installs a group
2. the user removes a package that is part of the group from (1)
3. the user system upgrades

Which of the following do you propose to happen?

4a. the package removed in (2) is brought back
4b. the package removed in (2) is not brought back (unless required by something else)

Comment 5 Michael Catanzaro 2020-06-11 11:52:16 UTC
4b

The goal is to ensure users get new packages by default, not to second-guess users who remove things.

Comment 6 Miro Hrončok 2020-06-11 12:04:52 UTC
Thanks for clarifying.

Comment 7 Jaroslav Mracek 2020-06-15 13:58:46 UTC
Thank you very much for the report and for the discussion. I see that expected behaviour is not to bring back removed packages and we have to also careful with the default behaviour. Suggestions about why the package is not on the system will only provides inconsistent behaviour between systems, therefore I suggest to create a new option that will update also groups or modules.

Comment 8 Ben Cotton 2020-08-11 15:34:53 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 33 development cycle.
Changing version to 33.

Comment 9 Pavla Kratochvilova 2020-08-31 08:02:02 UTC
Here is a PR that adds upgrading of groups and environments into system-upgrade: https://github.com/rpm-software-management/dnf-plugins-extras/pull/183

It still needs to be tested, but the group upgrade should not install back packages that were explicitly removed or excluded during the groups installation.

Comment 10 Michael Catanzaro 2020-09-26 11:36:31 UTC
*** Bug 1814306 has been marked as a duplicate of this bug. ***

Comment 11 Fedora Update System 2020-10-08 11:59:26 UTC
FEDORA-2020-b40fc174b5 has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2020-b40fc174b5

Comment 12 Fedora Update System 2020-10-08 12:00:24 UTC
FEDORA-2020-5d9f0ce2b3 has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-5d9f0ce2b3

Comment 13 Fedora Update System 2020-10-08 22:19:43 UTC
FEDORA-2020-b40fc174b5 has been pushed to the Fedora 33 testing repository.
In short time you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2020-b40fc174b5`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-b40fc174b5

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 14 Fedora Update System 2020-10-12 21:15:55 UTC
FEDORA-2020-b40fc174b5 has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2020-b40fc174b5

Comment 15 Fedora Update System 2020-10-12 21:23:30 UTC
FEDORA-2020-5d9f0ce2b3 has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-5d9f0ce2b3

Comment 16 Fedora Update System 2020-10-12 22:45:14 UTC
FEDORA-2020-b40fc174b5 has been pushed to the Fedora 33 testing repository.
In short time you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2020-b40fc174b5`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-b40fc174b5

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 17 Fedora Update System 2020-10-13 20:18:11 UTC
FEDORA-2020-5d9f0ce2b3 has been pushed to the Fedora 32 testing repository.
In short time you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2020-5d9f0ce2b3`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-5d9f0ce2b3

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 18 Fedora Update System 2020-10-18 15:49:15 UTC
FEDORA-2020-5d9f0ce2b3 has been pushed to the Fedora 32 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 19 Fedora Update System 2020-10-19 16:53:31 UTC
FEDORA-2020-b40fc174b5 has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2020-b40fc174b5

Comment 20 Fedora Update System 2020-10-20 14:22:47 UTC
FEDORA-2020-b40fc174b5 has been pushed to the Fedora 33 testing repository.
In short time you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2020-b40fc174b5`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-b40fc174b5

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 21 Fedora Update System 2020-10-27 01:20:47 UTC
FEDORA-2020-b40fc174b5 has been pushed to the Fedora 33 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.