Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 185212 - Review Request: freedoom - open source doom game files
Summary: Review Request: freedoom - open source doom game files
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Hans de Goede
QA Contact: Fedora Package Reviews List
URL:
Whiteboard:
Depends On: 185211
Blocks: FE-ACCEPT
TreeView+ depends on / blocked
 
Reported: 2006-03-11 20:48 UTC by Wart
Modified: 2007-11-30 22:11 UTC (History)
0 users

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2006-03-14 20:38:06 UTC
Type: ---
Embargoed:

Attachments (Terms of Use)

Description Wart 2006-03-11 20:48:48 UTC 
Spec Name or Url: http://www.kobold.org/~wart/fedora/freedoom.spec
SRPM Name or Url: http://www.kobold.org/~wart/fedora/freedoom-0.4.1-1.src.rpm
Description: 
Freely distributable game files for Doom.  This is an alternative set of game files to replace the shareware game files for Doom.

This package has a hard requirement on prboom in the .desktop file which is reflected in the Requires tag.  This will eventually be changed to require 'doom-engine' so that it can be played with alternate doom engines.  Note that this introduces a circular dependency where freedoom Requires prboom, and prboom Requires freedoom.
Comment 1 Wart 2006-03-11 20:50:44 UTC 
Adding Hans to cc: per his request.
Comment 2 Wart 2006-03-14 00:07:35 UTC 
Changes to the game data files directory, per the discussion in BZ #185211 (prboom)

http://www.kobold.org/~wart/fedora/freedoom-0.4.1-2.src.rpm
http://www.kobold.org/~wart/fedora/freedoom.spec
Comment 3 Hans de Goede 2006-03-14 08:34:56 UTC 
MUST
====
* Source tarball matches upstream
* Package (and .spec) named properly
* License file included
* Spec file readable, in Am. English
* Builds on FC-5 x86_64
* No locale files
* No excessive BR: or Requires:
* Not relocatable
* buildroot cleaned up in %install and %clean
* No duplicate files
* permissions ok
* Macro usage consistent
* Contains permissable content
* Desktop file included and properly installed

MUST FIX
========
License must be BSD not Distributable

SHOULD FIX
==========
* Use %{version} in Source0
* Remove:
# This package should Provide <enginename>-data for each doom engine
# that it is known to work with.
Concedering the procedure for doom wads we agreed on this is no longer true.
Comment 4 Wart 2006-03-14 15:29:44 UTC 
One more try to address all must and should fix issues:

http://www.kobold.org/~wart/fedora/freedoom-0.4.1-3.src.rpm
http://www.kobold.org/~wart/fedora/freedoom.spec
Comment 5 Hans de Goede 2006-03-14 17:13:05 UTC 
Looks good, APPROVED.
Comment 6 Wart 2006-03-14 20:38:06 UTC 
Imported and built.  Thanks!
Note You need to log in before you can comment on or make changes to this bug.